From: Lance Richardson <lance.richardson@broadcom.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Wenzhuo Lu <wenzhuo.lu@intel.com>,
Xiaoyun Li <xiaoyun.li@intel.com>,
Bernard Iremonger <bernard.iremonger@intel.com>,
Steve Yang <stevex.yang@intel.com>,
dev@dpdk.org, stable@dpdk.org, oulijun@huawei.com,
wisamm@mellanox.com, lihuisong@huawei.com
Subject: Re: [dpdk-stable] [PATCH v5] app/testpmd: fix setting maximum packet length
Date: Mon, 25 Jan 2021 14:41:31 -0500 [thread overview]
Message-ID: <CADyeNEC2Cdej=0PwLjbJNyg5Un_UKXmS4NEAELG7fs8CroZCSw@mail.gmail.com> (raw)
In-Reply-To: <20210125181548.2713326-1-ferruh.yigit@intel.com>
[-- Attachment #1: Type: text/plain, Size: 3216 bytes --]
On Mon, Jan 25, 2021 at 1:15 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> From: Steve Yang <stevex.yang@intel.com>
>
> "port config all max-pkt-len" command fails because it doesn't set the
> 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag properly.
>
> Commit in the fixes line moved the 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload
> flag update from 'cmd_config_max_pkt_len_parsed()' to 'init_config()'.
> 'init_config()' function is only called during testpmd startup, but the
> flag status needs to be calculated whenever 'max_rx_pkt_len' changes.
>
> The issue can be reproduce as [1], where the 'max-pkt-len' reduced and
> 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag should be cleared but it
> didn't.
>
> Adding the 'update_jumbo_frame_offload()' helper function to update
> 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag and 'max_rx_pkt_len'. This
> function is called both by 'init_config()' and
> 'cmd_config_max_pkt_len_parsed()'.
>
> Default 'max-pkt-len' value set to zero, 'update_jumbo_frame_offload()'
> updates it to "RTE_ETHER_MTU + PMD specific Ethernet overhead" when it
> is zero.
> If '--max-pkt-len=N' argument provided, it will be used instead.
> And with each "port config all max-pkt-len" command, the
> 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag, 'max-pkt-len' and MTU is
> updated.
>
> [1]
<snip>
> +/*
> + * Helper function to arrange max_rx_pktlen value and JUMBO_FRAME offload,
> + * MTU is also aligned if JUMBO_FRAME offload is not set.
> + *
> + * port->dev_info should be get before calling this function.
Should this be "port->dev_info should be set ..." instead?
<snip>
> + if (rx_offloads != port->dev_conf.rxmode.offloads) {
> + uint16_t qid;
> +
> + port->dev_conf.rxmode.offloads = rx_offloads;
> +
> + /* Apply JUMBO_FRAME offload configuration to Rx queue(s) */
> + for (qid = 0; qid < port->dev_info.nb_rx_queues; qid++) {
> + if (on)
> + port->rx_conf[qid].offloads |= DEV_RX_OFFLOAD_JUMBO_FRAME;
> + else
> + port->rx_conf[qid].offloads &= ~DEV_RX_OFFLOAD_JUMBO_FRAME;
> + }
Is it correct to set per-queue offloads that aren't advertised by the PMD
as supported in rx_queue_offload_capa?
> + }
> +
> + /* If JUMBO_FRAME is set MTU conversion done by ethdev layer,
> + * if unset do it here
> + */
> + if ((rx_offloads & DEV_RX_OFFLOAD_JUMBO_FRAME) == 0) {
> + ret = rte_eth_dev_set_mtu(portid,
> + port->dev_conf.rxmode.max_rx_pkt_len - eth_overhead);
> + if (ret)
> + printf("Failed to set MTU to %u for port %u\n",
> + port->dev_conf.rxmode.max_rx_pkt_len - eth_overhead,
> + portid);
> + }
> +
> + return 0;
> +}
> +
Applied and tested with a few iterations of configuring max packet size
back and forth between jumbo and non-jumbo sizes, also tried setting
max packet size using the command-line option, all seems good based
on rx offloads and packet forwarding.
Two minor questions above, otherwise LGTM.
next prev parent reply other threads:[~2021-01-25 19:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210125083202.38267-1-stevex.yang@intel.com>
2021-01-25 18:15 ` Ferruh Yigit
2021-01-25 19:41 ` Lance Richardson [this message]
2021-01-26 0:44 ` Ferruh Yigit
2021-01-26 3:22 ` Lance Richardson
2021-01-26 3:45 ` Lance Richardson
2021-01-26 7:54 ` Li, Xiaoyun
2021-01-26 11:01 ` Ferruh Yigit
2021-01-28 21:36 ` Lance Richardson
2021-01-28 22:12 ` Ferruh Yigit
2021-01-26 9:02 ` Wisam Monther
2021-01-27 3:04 ` Li, Xiaoyun
2021-01-28 1:57 ` Chen, BoX C
2021-01-28 9:18 ` Wisam Monther
2021-01-28 9:26 ` Ferruh Yigit
2021-01-28 11:08 ` Wisam Monther
2021-01-28 12:07 ` [dpdk-stable] [PATCH v6] " Ferruh Yigit
2021-01-29 9:34 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADyeNEC2Cdej=0PwLjbJNyg5Un_UKXmS4NEAELG7fs8CroZCSw@mail.gmail.com' \
--to=lance.richardson@broadcom.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=lihuisong@huawei.com \
--cc=oulijun@huawei.com \
--cc=stable@dpdk.org \
--cc=stevex.yang@intel.com \
--cc=wenzhuo.lu@intel.com \
--cc=wisamm@mellanox.com \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).