patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] net/bnxt: fix initialization of filter struct
@ 2021-04-28 22:04 Lance Richardson
  2021-04-29 13:43 ` Lance Richardson
  0 siblings, 1 reply; 3+ messages in thread
From: Lance Richardson @ 2021-04-28 22:04 UTC (permalink / raw)
  To: Ajit Khaparde, Somnath Kotur; +Cc: dev, stable

[-- Attachment #1: Type: text/plain, Size: 752 bytes --]

Initialize filter structure to all zeroes on allocation.

Fixes: 5ef3b79fdfe6 ("net/bnxt: support flow filter ops")
Cc: stable@dpdk.org
Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>
Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
---
 drivers/net/bnxt/bnxt_filter.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/bnxt/bnxt_filter.c b/drivers/net/bnxt/bnxt_filter.c
index 1d08e03b2f..6aadfa9526 100644
--- a/drivers/net/bnxt/bnxt_filter.c
+++ b/drivers/net/bnxt/bnxt_filter.c
@@ -188,6 +188,7 @@ struct bnxt_filter_info *bnxt_get_unused_filter(struct bnxt *bp)
 		return NULL;
 	}
 	STAILQ_REMOVE_HEAD(&bp->free_filter_list, next);
+	memset(filter, 0, sizeof(*filter));
 
 	return filter;
 }
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [PATCH] net/bnxt: fix initialization of filter struct
  2021-04-28 22:04 [dpdk-stable] [PATCH] net/bnxt: fix initialization of filter struct Lance Richardson
@ 2021-04-29 13:43 ` Lance Richardson
  2021-04-29 13:59   ` Lance Richardson
  0 siblings, 1 reply; 3+ messages in thread
From: Lance Richardson @ 2021-04-29 13:43 UTC (permalink / raw)
  To: Ajit Khaparde, Somnath Kotur; +Cc: dev, dpdk stable

[-- Attachment #1: Type: text/plain, Size: 957 bytes --]

On Wed, Apr 28, 2021 at 6:04 PM Lance Richardson
<lance.richardson@broadcom.com> wrote:
>
> Initialize filter structure to all zeroes on allocation.
>
> Fixes: 5ef3b79fdfe6 ("net/bnxt: support flow filter ops")
> Cc: stable@dpdk.org
> Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>
> Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
> ---
>  drivers/net/bnxt/bnxt_filter.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/bnxt/bnxt_filter.c b/drivers/net/bnxt/bnxt_filter.c
> index 1d08e03b2f..6aadfa9526 100644
> --- a/drivers/net/bnxt/bnxt_filter.c
> +++ b/drivers/net/bnxt/bnxt_filter.c
> @@ -188,6 +188,7 @@ struct bnxt_filter_info *bnxt_get_unused_filter(struct bnxt *bp)
>                 return NULL;
>         }
>         STAILQ_REMOVE_HEAD(&bp->free_filter_list, next);
> +       memset(filter, 0, sizeof(*filter));
>
>         return filter;
>  }
> --
> 2.25.1
>
Self-NAK, will send a v2 shortly.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [PATCH] net/bnxt: fix initialization of filter struct
  2021-04-29 13:43 ` Lance Richardson
@ 2021-04-29 13:59   ` Lance Richardson
  0 siblings, 0 replies; 3+ messages in thread
From: Lance Richardson @ 2021-04-29 13:59 UTC (permalink / raw)
  To: Ajit Khaparde, Somnath Kotur; +Cc: dev, dpdk stable, Kalesh Anakkur Purayil

[-- Attachment #1: Type: text/plain, Size: 1286 bytes --]

On Thu, Apr 29, 2021 at 9:43 AM Lance Richardson
<lance.richardson@broadcom.com> wrote:
>
> On Wed, Apr 28, 2021 at 6:04 PM Lance Richardson
> <lance.richardson@broadcom.com> wrote:
> >
> > Initialize filter structure to all zeroes on allocation.
> >
> > Fixes: 5ef3b79fdfe6 ("net/bnxt: support flow filter ops")
> > Cc: stable@dpdk.org
> > Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>
> > Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
> > ---
> >  drivers/net/bnxt/bnxt_filter.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/bnxt/bnxt_filter.c b/drivers/net/bnxt/bnxt_filter.c
> > index 1d08e03b2f..6aadfa9526 100644
> > --- a/drivers/net/bnxt/bnxt_filter.c
> > +++ b/drivers/net/bnxt/bnxt_filter.c
> > @@ -188,6 +188,7 @@ struct bnxt_filter_info *bnxt_get_unused_filter(struct bnxt *bp)
> >                 return NULL;
> >         }
> >         STAILQ_REMOVE_HEAD(&bp->free_filter_list, next);
> > +       memset(filter, 0, sizeof(*filter));
> >
> >         return filter;
> >  }
> > --
> > 2.25.1
> >
> Self-NAK, will send a v2 shortly.

Let's drop this patch, this is already fixed in upstream via
commit 7105de7085b0 ("net/bnxt: reset filter indices on free"),
but that commit should be applied to -stable branches.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-04-29 13:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-28 22:04 [dpdk-stable] [PATCH] net/bnxt: fix initialization of filter struct Lance Richardson
2021-04-29 13:43 ` Lance Richardson
2021-04-29 13:59   ` Lance Richardson

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git