* [PATCH 0/1] eal/linux: Remove unused values
[not found] <20250112185842.9752-1-otilibil@eurecom.fr>
@ 2025-01-13 17:19 ` Ariel Otilibili
2025-01-13 17:19 ` [PATCH 1/1] " Ariel Otilibili
0 siblings, 1 reply; 4+ messages in thread
From: Ariel Otilibili @ 2025-01-13 17:19 UTC (permalink / raw)
To: dev
Cc: Stephen Hemminger, Thomas Monjalon, David Marchand,
Ariel Otilibili, Didier Pallard, Edwin Brossette, Olivier Matz,
Thierry Herbelot, stable
Hello,
This patch clears out a static analysis warning.
Your feedback is much appreciated,
Ariel Otilibili (1):
eal/linux: Remove unused values
lib/eal/linux/eal_dev.c | 3 ---
1 file changed, 3 deletions(-)
--
2.30.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/1] eal/linux: Remove unused values
2025-01-13 17:19 ` [PATCH 0/1] eal/linux: Remove unused values Ariel Otilibili
@ 2025-01-13 17:19 ` Ariel Otilibili
2025-02-12 14:00 ` Thomas Monjalon
0 siblings, 1 reply; 4+ messages in thread
From: Ariel Otilibili @ 2025-01-13 17:19 UTC (permalink / raw)
To: dev
Cc: Stephen Hemminger, Thomas Monjalon, David Marchand,
Ariel Otilibili, Didier Pallard, Edwin Brossette, Olivier Matz,
Thierry Herbelot, stable
Found by static analysis:
In dev_uev_socket_fd_create(), fd is assigned before a return,
and not used.
The same for the variables buf and i in dev_uev_parse().
Fixes: c2bd9367e18f ("lib: remove direct access to interrupt handle")
Fixes: 0d0f478d0483 ("eal/linux: add uevent parse and process")
Signed-off-by: Ariel Otilibili <ariel.otilibili@6wind.com>
---
lib/eal/linux/eal_dev.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/lib/eal/linux/eal_dev.c b/lib/eal/linux/eal_dev.c
index e63f24d108c7..be97f56424de 100644
--- a/lib/eal/linux/eal_dev.c
+++ b/lib/eal/linux/eal_dev.c
@@ -129,7 +129,6 @@ dev_uev_socket_fd_create(void)
return 0;
err:
close(fd);
- fd = -1;
return ret;
}
@@ -165,8 +164,6 @@ dev_uev_parse(const char *buf, struct rte_dev_event *event, int length)
* uevent from udev.
*/
if (!strncmp(buf, "libudev", 7)) {
- buf += 7;
- i += 7;
return -1;
}
if (!strncmp(buf, "ACTION=", 7)) {
--
2.30.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] eal/linux: Remove unused values
2025-01-13 17:19 ` [PATCH 1/1] " Ariel Otilibili
@ 2025-02-12 14:00 ` Thomas Monjalon
2025-02-13 11:12 ` Ariel Otilibili
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Monjalon @ 2025-02-12 14:00 UTC (permalink / raw)
To: Ariel Otilibili
Cc: dev, Stephen Hemminger, David Marchand, Didier Pallard,
Edwin Brossette, Olivier Matz, Thierry Herbelot, stable
13/01/2025 18:19, Ariel Otilibili:
> Found by static analysis:
>
> In dev_uev_socket_fd_create(), fd is assigned before a return,
> and not used.
>
> The same for the variables buf and i in dev_uev_parse().
>
> Fixes: c2bd9367e18f ("lib: remove direct access to interrupt handle")
> Fixes: 0d0f478d0483 ("eal/linux: add uevent parse and process")
>
> Signed-off-by: Ariel Otilibili <ariel.otilibili@6wind.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] eal/linux: Remove unused values
2025-02-12 14:00 ` Thomas Monjalon
@ 2025-02-13 11:12 ` Ariel Otilibili
0 siblings, 0 replies; 4+ messages in thread
From: Ariel Otilibili @ 2025-02-13 11:12 UTC (permalink / raw)
To: Thomas Monjalon
Cc: dev, Stephen Hemminger, David Marchand, Didier Pallard,
Edwin Brossette, Olivier Matz, Thierry Herbelot, stable
[-- Attachment #1: Type: text/plain, Size: 171 bytes --]
Hi Thomas,
On Wed, Feb 12, 2025 at 3:00 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> Applied, thanks.
>
Thanks for the feedback. Have a good day.
Ariel
[-- Attachment #2: Type: text/html, Size: 530 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-02-13 11:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20250112185842.9752-1-otilibil@eurecom.fr>
2025-01-13 17:19 ` [PATCH 0/1] eal/linux: Remove unused values Ariel Otilibili
2025-01-13 17:19 ` [PATCH 1/1] " Ariel Otilibili
2025-02-12 14:00 ` Thomas Monjalon
2025-02-13 11:12 ` Ariel Otilibili
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).