Re: [PATCH v8 2/2] net/af_xdp: Refactor af_xdp_tx_zc

[Ariel Otilibili <ariel.otilibili@6wind.com>]

[-- Attachment #1: Type: text/plain, Size: 708 bytes --]

Hi Maryam, hi Stephen;

On Fri, Feb 7, 2025 at 10:14 AM Maryam Tahhan <mtahhan@redhat.com> wrote:

> Sorry if my remarks were confusing, it was just missing from the previous
> patch and it needs to be:
> desc->len = mbuf->pkt_len;
>
> We need to keep this the same as the original code. This is a scenario
> where we need to copy the data from an mbuf that isn't in from the pool of
> buffers allocated for the umem. So the desc->len needs to be set to that of
> the (non umem) mbuf.
>
> The other changes look good. Nearly there,
>
> Thanks again
>

Thanks for the feedback. There is it,
http://inbox.dpdk.org/dev/20250207104552.1663519-1-ariel.otilibili@6wind.com/

>
> <snip>
>

[-- Attachment #2: Type: text/html, Size: 1547 bytes --]