* [dpdk-stable] [PATCH] net/bonding: fix invalid port id error
@ 2018-07-18 11:12 Radu Nicolau
2018-07-19 17:45 ` [dpdk-stable] [dpdk-dev] " Chas Williams
0 siblings, 1 reply; 3+ messages in thread
From: Radu Nicolau @ 2018-07-18 11:12 UTC (permalink / raw)
To: dev; +Cc: declan.doherty, chas3, thomas, Radu Nicolau, stable
setting up the bonding options before calling rte_eth_dev_probing_finish
triggers an invalid port id error because of port state not set, or set
unused
Fixes: fbe90cdd776c ("ethdev: add probing finish function")
Cc: stable@dpdk.org
Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
---
drivers/net/bonding/rte_eth_bond_pmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
index fc4d4fd..1320cfd 100644
--- a/drivers/net/bonding/rte_eth_bond_pmd.c
+++ b/drivers/net/bonding/rte_eth_bond_pmd.c
@@ -3238,6 +3238,7 @@ bond_probe(struct rte_vdev_device *dev)
internals = rte_eth_devices[port_id].data->dev_private;
internals->kvlist = kvlist;
+ rte_eth_dev_probing_finish(&rte_eth_devices[port_id]);
if (rte_kvargs_count(kvlist, PMD_BOND_AGG_MODE_KVARG) == 1) {
if (rte_kvargs_process(kvlist,
@@ -3257,7 +3258,6 @@ bond_probe(struct rte_vdev_device *dev)
rte_eth_bond_8023ad_agg_selection_set(port_id, AGG_STABLE);
}
- rte_eth_dev_probing_finish(&rte_eth_devices[port_id]);
RTE_BOND_LOG(INFO, "Create bonded device %s on port %d in mode %u on "
"socket %u.", name, port_id, bonding_mode, socket_id);
return 0;
--
2.7.5
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH] net/bonding: fix invalid port id error
2018-07-18 11:12 [dpdk-stable] [PATCH] net/bonding: fix invalid port id error Radu Nicolau
@ 2018-07-19 17:45 ` Chas Williams
2018-07-20 15:12 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Chas Williams @ 2018-07-19 17:45 UTC (permalink / raw)
To: Radu Nicolau; +Cc: dev, Declan Doherty, Chas Williams, Thomas Monjalon, stable
This seems fine. The bond PMD seems to call back into itself early.
On Wed, Jul 18, 2018 at 7:19 AM Radu Nicolau <radu.nicolau@intel.com> wrote:
> setting up the bonding options before calling rte_eth_dev_probing_finish
> triggers an invalid port id error because of port state not set, or set
> unused
>
> Fixes: fbe90cdd776c ("ethdev: add probing finish function")
> Cc: stable@dpdk.org
>
> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
>
Signed-off-by: Chas Williams <chas3@att.com>
> ---
> drivers/net/bonding/rte_eth_bond_pmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c
> b/drivers/net/bonding/rte_eth_bond_pmd.c
> index fc4d4fd..1320cfd 100644
> --- a/drivers/net/bonding/rte_eth_bond_pmd.c
> +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
> @@ -3238,6 +3238,7 @@ bond_probe(struct rte_vdev_device *dev)
> internals = rte_eth_devices[port_id].data->dev_private;
> internals->kvlist = kvlist;
>
> + rte_eth_dev_probing_finish(&rte_eth_devices[port_id]);
>
> if (rte_kvargs_count(kvlist, PMD_BOND_AGG_MODE_KVARG) == 1) {
> if (rte_kvargs_process(kvlist,
> @@ -3257,7 +3258,6 @@ bond_probe(struct rte_vdev_device *dev)
> rte_eth_bond_8023ad_agg_selection_set(port_id, AGG_STABLE);
> }
>
> - rte_eth_dev_probing_finish(&rte_eth_devices[port_id]);
> RTE_BOND_LOG(INFO, "Create bonded device %s on port %d in mode %u
> on "
> "socket %u.", name, port_id, bonding_mode,
> socket_id);
> return 0;
> --
> 2.7.5
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH] net/bonding: fix invalid port id error
2018-07-19 17:45 ` [dpdk-stable] [dpdk-dev] " Chas Williams
@ 2018-07-20 15:12 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2018-07-20 15:12 UTC (permalink / raw)
To: Chas Williams, Radu Nicolau
Cc: dev, Declan Doherty, Chas Williams, Thomas Monjalon, stable
On 7/19/2018 6:45 PM, Chas Williams wrote:
> This seems fine. The bond PMD seems to call back into itself early.
>
> On Wed, Jul 18, 2018 at 7:19 AM Radu Nicolau <radu.nicolau@intel.com> wrote:
>
>> setting up the bonding options before calling rte_eth_dev_probing_finish
>> triggers an invalid port id error because of port state not set, or set
>> unused
>>
>> Fixes: fbe90cdd776c ("ethdev: add probing finish function")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
>>
>
> Signed-off-by: Chas Williams <chas3@att.com>
Signed-off-by replaced with:
Acked-by: Chas Williams <chas3@att.com>
If intention was really sign-off, please let me know
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-20 15:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-18 11:12 [dpdk-stable] [PATCH] net/bonding: fix invalid port id error Radu Nicolau
2018-07-19 17:45 ` [dpdk-stable] [dpdk-dev] " Chas Williams
2018-07-20 15:12 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).