From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 63CE9A04B5 for ; Thu, 29 Oct 2020 10:23:14 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3F6E8C82A; Thu, 29 Oct 2020 10:23:13 +0100 (CET) Received: from mail-il1-f193.google.com (mail-il1-f193.google.com [209.85.166.193]) by dpdk.org (Postfix) with ESMTP id 1720DC82A for ; Thu, 29 Oct 2020 10:23:10 +0100 (CET) Received: by mail-il1-f193.google.com with SMTP id z2so2272141ilh.11 for ; Thu, 29 Oct 2020 02:23:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zptlrpfryOKMG+R7b2kSAH2lO8PUdZ0/okZ83lJk2eM=; b=FxtZGD888CDNWAx6zrQPZqFVglpMd5EGb4nQHZ67Ev6g+C0EHs0dKapHHA3MXodGxz qxJIt94o2viRL8cMH130BYIDOM8TPaIDjtlMQtxOQc1SQu/A4olXNtjVte6AFTN4lYoJ MRBVdLMiDPe19S9Xb0R8cqfyk8Os0fCtoOCyE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zptlrpfryOKMG+R7b2kSAH2lO8PUdZ0/okZ83lJk2eM=; b=cPExZ3IQwLcwMmVpJCT4JDnr3VdRWZDfyuq8DVYwjD4XGwlBHLAj4FBQi8RL7weO4A sVLeFbio6H/yzMhDBeWdheVNMDHqaQXD4YwPiV8b2U6DIcnotOdfdIdfhSTAEdzfP02O uZOo9bRdLx9zbbF8KqOBz8Dptx5gOb96kEW5uUTnjXmFI2UXyXueq2dsS+5/ItooH0ng nHFHXtkPtwlVxc979VfszFTxoMVIFqUMDiD1rcJBNesv570uPbZ2gP2s7IuSLeRNY6h3 owOGALyrIrl95wbVURI24dJWOvLImisIw9Qa4tJEWt2pT0CLN2l6KG7n5pCrlJ33rLd4 kiaA== X-Gm-Message-State: AOAM532rpkxoBwe+58BvtUYJwb26wpmYri5EKySCBVc5W20GCnZsv9b7 LcEnGoH9RlixlwxubNHFctS3t/Q4lJqclBQBTe4LEQ== X-Google-Smtp-Source: ABdhPJxMjcLO4BcVtTdugVjdiPxE53rJqmcGoHci30Mj/rJfhIlGZegJrR9+DLaQMsIVKGv/QCQj+xmjsKI0Dw+Y/lU= X-Received: by 2002:a92:5b54:: with SMTP id p81mr2485466ilb.290.1603963387696; Thu, 29 Oct 2020 02:23:07 -0700 (PDT) MIME-Version: 1.0 References: <20201028104606.3504127-1-luca.boccassi@gmail.com> <20201028104606.3504127-70-luca.boccassi@gmail.com> In-Reply-To: <20201028104606.3504127-70-luca.boccassi@gmail.com> From: Kalesh Anakkur Purayil Date: Thu, 29 Oct 2020 14:52:56 +0530 Message-ID: To: Luca Boccassi Cc: Somnath Kotur , Ajit Khaparde , dpdk stable Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-stable] patch 'net/bnxt: fix link status during device recovery' has been queued to stable release 19.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi Luca, On Wed, Oct 28, 2020 at 4:19 PM wrote: > Hi, > > FYI, your patch has been queued to stable release 19.11.6 > > Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. > It will be pushed if I get no objections before 10/30/20. So please > shout if anyone has objections. > > Also note that after the patch there's a diff of the upstream commit vs the > patch applied to the branch. This will indicate if there was any rebasing > needed to apply to the stable branch. If there were code changes for > rebasing > (ie: not only metadata diffs), please double check that the rebase was > correctly done. > > Thanks. > > Luca Boccassi > > --- > From 77d290729b074c88263d3024229f806fa176e684 Mon Sep 17 00:00:00 2001 > From: Kalesh AP > Date: Tue, 22 Sep 2020 11:04:16 +0530 > Subject: [PATCH] net/bnxt: fix link status during device recovery > > [ upstream commit 6fcd0de92298f61b8f96ba170db9e81923019626 ] > > Driver should not send the phy_cfg request to bring link down > during reset recovery. If the driver sends the phy_cfg request > in recovery process, then FW needs to re-establish the link which > in turn increases the recovery time based on PHY type and link partners. > > Fixes: df6cd7c1f73a ("net/bnxt: handle reset notify async event from FW") > > Signed-off-by: Kalesh AP > Reviewed-by: Somnath Kotur > Reviewed-by: Ajit Khaparde > --- > drivers/net/bnxt/bnxt_ethdev.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c > b/drivers/net/bnxt/bnxt_ethdev.c > index d6afd03e56..bbfe883c15 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -942,7 +942,9 @@ static void bnxt_dev_stop_op(struct rte_eth_dev > *eth_dev) > > bnxt_cancel_fw_health_check(bp); > > - bnxt_dev_set_link_down_op(eth_dev); > + /* Do not bring link down during reset recovery */ > + if (!is_bnxt_in_error(bp)) > + bnxt_dev_set_link_down_op(eth_dev); > > /* Wait for link to be reset and the async notification to process. > * During reset recovery, there is no need to wait and > @@ -3908,7 +3910,7 @@ static void bnxt_write_fw_reset_reg(struct bnxt *bp, > uint32_t index) > > static void bnxt_dev_cleanup(struct bnxt *bp) > { > - bnxt_set_hwrm_link_config(bp, false); > + bp->eth_dev->data->dev_link.link_status = 0; > bp->link_info.link_up = 0; > if (bp->eth_dev->data->dev_started) > bnxt_dev_stop_op(bp->eth_dev); > -- > 2.20.1 > > --- > Diff of the applied patch vs upstream commit (please double-check if > non-empty: > --- > --- - 2020-10-28 10:35:13.947167689 +0000 > +++ 0070-net-bnxt-fix-link-status-during-device-recovery.patch 2020-10-28 > 10:35:11.556830789 +0000 > @@ -1,15 +1,16 @@ > -From 6fcd0de92298f61b8f96ba170db9e81923019626 Mon Sep 17 00:00:00 2001 > +From 77d290729b074c88263d3024229f806fa176e684 Mon Sep 17 00:00:00 2001 > From: Kalesh AP > Date: Tue, 22 Sep 2020 11:04:16 +0530 > Subject: [PATCH] net/bnxt: fix link status during device recovery > > +[ upstream commit 6fcd0de92298f61b8f96ba170db9e81923019626 ] > + > Driver should not send the phy_cfg request to bring link down > during reset recovery. If the driver sends the phy_cfg request > in recovery process, then FW needs to re-establish the link which > in turn increases the recovery time based on PHY type and link partners. > > Fixes: df6cd7c1f73a ("net/bnxt: handle reset notify async event from FW") > -Cc: stable@dpdk.org > > Signed-off-by: Kalesh AP > Reviewed-by: Somnath Kotur > @@ -19,10 +20,10 @@ > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c > b/drivers/net/bnxt/bnxt_ethdev.c > -index 05e9a6abbf..e0afaac694 100644 > +index d6afd03e56..bbfe883c15 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > -@@ -1323,7 +1323,9 @@ static void bnxt_dev_stop_op(struct rte_eth_dev > *eth_dev) > +@@ -942,7 +942,9 @@ static void bnxt_dev_stop_op(struct rte_eth_dev > *eth_dev) > > bnxt_cancel_fw_health_check(bp); > > @@ -33,13 +34,13 @@ > > /* Wait for link to be reset and the async notification to process. > * During reset recovery, there is no need to wait and > -@@ -4377,7 +4379,7 @@ static void bnxt_write_fw_reset_reg(struct bnxt > *bp, uint32_t index) > +@@ -3908,7 +3910,7 @@ static void bnxt_write_fw_reset_reg(struct bnxt > *bp, uint32_t index) > > static void bnxt_dev_cleanup(struct bnxt *bp) > { > - bnxt_set_hwrm_link_config(bp, false); > + bp->eth_dev->data->dev_link.link_status = 0; > - bp->link_info->link_up = 0; > + bp->link_info.link_up = 0; > if (bp->eth_dev->data->dev_started) > bnxt_dev_stop_op(bp->eth_dev); > Luca, I see that the rebase is not correct, I will fix and send the patch to 19.11 LTS. Regards, Kalesh > -- > -- Regards, Kalesh A P