From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 064DBA04F0 for ; Thu, 19 Dec 2019 15:58:14 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DBE331C01F; Thu, 19 Dec 2019 15:58:13 +0100 (CET) Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) by dpdk.org (Postfix) with ESMTP id CDA071C01F for ; Thu, 19 Dec 2019 15:58:12 +0100 (CET) Received: by mail-io1-f65.google.com with SMTP id v18so6052488iol.2 for ; Thu, 19 Dec 2019 06:58:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MzMnQMskN4aOK10UuVsgXGr9zKshlzeSVtjmyQ/SpF0=; b=O3AOCs61BIPdqcDE0VS6XXrKQ9WRt8YUW/MdmXEo3iIagtN0LuCUI6WJESC3twIywB xMz3nvdra+1PetoQv/FHQaHg98l2EFEgXvh0rfGThsl11a2CDkHt3YFNWKp/m0i83nPE 1hBxN60ghHvS2uRZT3s3+1T4T8jDKquRXBBPs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MzMnQMskN4aOK10UuVsgXGr9zKshlzeSVtjmyQ/SpF0=; b=fWsvbE81NBeQ+HkcxZgIF2iqDIhsvWwCK+6ADYOoj4WskL3zdfss5Q7tXeklH7hbC1 NIWxQ7Og6vx7cQ1ihTew0CLfWedvaRVAD+6vrEI2qawhAitZPMAbV3O0LC3bHBXg5DT0 ncX2MzA5Zipp7I6n/BcG78sckYcBrArg17itIpGYyCxCuSL0GMzx133knr6cyKjwISXX g23kw/tQ07+/ln3D8NBBlHM5jd4AZC9p9Pr0g5Tbs5NPpbS1rFpY7LbfaXF8YdXzoHyT 7xrGJLC/celh42fjGaP6yjHntHurSkozE4k01ihmk+Ni4WYPTG2MzN0w+9G7zBtDTSJj AHfA== X-Gm-Message-State: APjAAAVRwMD1sSWj2U3gAH835jE0i3NBj8cwWUXjubjUHqQZe7HNmFTQ pqx31UmwzTbKFgjktvjMWzEZRgGw9OLy1SL/yxNvKw== X-Google-Smtp-Source: APXvYqyqgruBZqu3adq6j2Eoat3hkBF/Ko6yZ0LKYP8vMhElVPpmMiwAvkviWoG0nvQLhKH3zp3hbMIVAKTJvpG3nCs= X-Received: by 2002:a6b:8e51:: with SMTP id q78mr5903529iod.179.1576767492150; Thu, 19 Dec 2019 06:58:12 -0800 (PST) MIME-Version: 1.0 References: <20191219143447.21506-1-luca.boccassi@gmail.com> <20191219143447.21506-69-luca.boccassi@gmail.com> In-Reply-To: <20191219143447.21506-69-luca.boccassi@gmail.com> From: Kalesh Anakkur Purayil Date: Thu, 19 Dec 2019 20:27:52 +0530 Message-ID: To: luca.boccassi@gmail.com Cc: Somnath Kotur , Ajit Khaparde , dpdk stable Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-stable] patch 'net/bnxt: fix error handling in xstats' has been queued to LTS release 17.11.10 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi Luca, NAK for this patch as the rebasing was not correctly done. You can ignore this patch for now from 17.11 stable inclusion. Regards, Kalesh On Thu, Dec 19, 2019 at 8:07 PM wrote: > Hi, > > FYI, your patch has been queued to LTS release 17.11.10 > > Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. > It will be pushed if I get no objections before 12/21/19. So please > shout if anyone has objections. > > Also note that after the patch there's a diff of the upstream commit vs the > patch applied to the branch. This will indicate if there was any rebasing > needed to apply to the stable branch. If there were code changes for > rebasing > (ie: not only metadata diffs), please double check that the rebase was > correctly done. > > Thanks. > > Luca Boccassi > > --- > From cf96c144f07d6ac3800a8abccef4f7d3d7e367f6 Mon Sep 17 00:00:00 2001 > From: Kalesh AP > Date: Fri, 11 Oct 2019 10:46:44 +0530 > Subject: [PATCH] net/bnxt: fix error handling in xstats > > [ upstream commit 9bc556e3ecec6c1127c6d6c99660742315c59282 ] > > Add missing return instead of setting the error status in case of error. > > Fixes: bfb9c2260be2 ("net/bnxt: support xstats get/reset") > > Signed-off-by: Kalesh AP > Reviewed-by: Somnath Kotur > Reviewed-by: Ajit Khaparde > --- > drivers/net/bnxt/bnxt_stats.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/bnxt/bnxt_stats.c b/drivers/net/bnxt/bnxt_stats.c > index 6497926162..e85db7f6d0 100644 > --- a/drivers/net/bnxt/bnxt_stats.c > +++ b/drivers/net/bnxt/bnxt_stats.c > @@ -365,6 +365,7 @@ void bnxt_dev_xstats_reset_op(struct rte_eth_dev > *eth_dev) > if (BNXT_VF(bp) || !BNXT_NPAR_PF(bp) || > !(bp->flags & BNXT_FLAG_PORT_STATS)) { > RTE_LOG(ERR, PMD, "Operation not supported\n"); > + return; > } > > ret = bnxt_hwrm_port_clr_stats(bp); > -- > 2.20.1 > > --- > Diff of the applied patch vs upstream commit (please double-check if > non-empty: > --- > --- - 2019-12-19 14:32:29.067360477 +0000 > +++ 0069-net-bnxt-fix-error-handling-in-xstats.patch 2019-12-19 > 14:32:26.153298777 +0000 > @@ -1,30 +1,30 @@ > -From 9bc556e3ecec6c1127c6d6c99660742315c59282 Mon Sep 17 00:00:00 2001 > +From cf96c144f07d6ac3800a8abccef4f7d3d7e367f6 Mon Sep 17 00:00:00 2001 > From: Kalesh AP > Date: Fri, 11 Oct 2019 10:46:44 +0530 > Subject: [PATCH] net/bnxt: fix error handling in xstats > > +[ upstream commit 9bc556e3ecec6c1127c6d6c99660742315c59282 ] > + > Add missing return instead of setting the error status in case of error. > > Fixes: bfb9c2260be2 ("net/bnxt: support xstats get/reset") > -Cc: stable@dpdk.org > > Signed-off-by: Kalesh AP > Reviewed-by: Somnath Kotur > Reviewed-by: Ajit Khaparde > --- > - drivers/net/bnxt/bnxt_stats.c | 2 +- > - 1 file changed, 1 insertion(+), 1 deletion(-) > + drivers/net/bnxt/bnxt_stats.c | 1 + > + 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/bnxt/bnxt_stats.c b/drivers/net/bnxt/bnxt_stats.c > -index f486a5634b..fa29f9de19 100644 > +index 6497926162..e85db7f6d0 100644 > --- a/drivers/net/bnxt/bnxt_stats.c > +++ b/drivers/net/bnxt/bnxt_stats.c > -@@ -575,7 +575,7 @@ int bnxt_dev_xstats_reset_op(struct rte_eth_dev > *eth_dev) > - if (BNXT_VF(bp) || !BNXT_SINGLE_PF(bp) || > +@@ -365,6 +365,7 @@ void bnxt_dev_xstats_reset_op(struct rte_eth_dev > *eth_dev) > + if (BNXT_VF(bp) || !BNXT_NPAR_PF(bp) || > !(bp->flags & BNXT_FLAG_PORT_STATS)) { > - PMD_DRV_LOG(ERR, "Operation not supported\n"); > -- ret = -ENOTSUP; > -+ return -ENOTSUP; > + RTE_LOG(ERR, PMD, "Operation not supported\n"); > ++ return; > } > > ret = bnxt_hwrm_port_clr_stats(bp); > -- Regards, Kalesh A P