patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Lance Richardson <h.lance.richardson@gmail.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Lance Richardson <lance.richardson@broadcom.com>,
	 Ajit Khaparde <ajit.khaparde@broadcom.com>,
	Somnath Kotur <somnath.kotur@broadcom.com>,
	 Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>,
	dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/bnxt: limit per-poll Rx representor pkts
Date: Wed, 6 Jan 2021 15:54:32 -0500
Message-ID: <CAH5C7_1Q01uVaEEVaDD9APDtOnspN0tYUGDuQG2g397iJ1vOfg@mail.gmail.com> (raw)
In-Reply-To: <e6b63511-c01d-1456-021c-a183cadcde60@intel.com>

On Wed, Jan 6, 2021 at 4:27 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> On 12/14/2020 6:53 PM, Lance Richardson wrote:
> > Limit number of representor packets transferred per poll
> > to requested burst size.
> >
>
> Hi Lance,
>
> Can you please describe the impact of the change? Since it has a fixes line, it
> seems it is fixing something but it is not clear what is fixed.
>
Hi Ferruh,

How does this look:

Without some limit on the number of packets transferred from the
hw ring to the representor ring per burst receive call, an entire ring's
worth of packets can be transferred. This can break assumptions
about ring indices (index on return could be identical to the index
on entry, which is assumed to mean that no packets were processed),
and can result in representor packets being dropped unnecessarily
due to representor ring overflow.

Fix by limiting the number of representor packets transferred per
poll to requested burst size.

Thanks,
    Lance

  reply	other threads:[~2021-01-06 20:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-14 18:53 [dpdk-stable] " Lance Richardson
2020-12-17 23:54 ` [dpdk-stable] [dpdk-dev] " Ajit Khaparde
2021-01-06  9:27 ` [dpdk-stable] " Ferruh Yigit
2021-01-06 20:54   ` Lance Richardson [this message]
2021-01-07 15:33     ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAH5C7_1Q01uVaEEVaDD9APDtOnspN0tYUGDuQG2g397iJ1vOfg@mail.gmail.com \
    --to=h.lance.richardson@gmail.com \
    --cc=ajit.khaparde@broadcom.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=lance.richardson@broadcom.com \
    --cc=somnath.kotur@broadcom.com \
    --cc=stable@dpdk.org \
    --cc=venkatkumar.duvvuru@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git