From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C24164550C for ; Thu, 27 Jun 2024 14:37:29 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D2B4242D27; Thu, 27 Jun 2024 14:37:23 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 4D00A40E27 for ; Thu, 27 Jun 2024 14:37:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1719491831; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7Lfibz63AMhz2sdAXQraDxBw2szBmCJ7Ed2mrXAwTLA=; b=H+qzZwS6Zx492Mo+Hx8wMjs89RsZuapDdosVdsb0Bfc4v5XX3q5x8X3ImQgjNDEg37+kKN XqNgw1sHUdEibov0puXcX5fuzx0ug+GOC9RCnnGLraVB11Y4BhZ8VsusuzQdRoyEP76JWd drDtdN87srNdG/E4U57O5sQWuWVcCTY= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-374-zlfrr3tBNHG8pk293SJeag-1; Thu, 27 Jun 2024 08:37:08 -0400 X-MC-Unique: zlfrr3tBNHG8pk293SJeag-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2ee4ab40417so3761601fa.0 for ; Thu, 27 Jun 2024 05:37:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719491827; x=1720096627; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7Lfibz63AMhz2sdAXQraDxBw2szBmCJ7Ed2mrXAwTLA=; b=au6W9ID9praJG4/5c1mUXlv90n25Kf4ZCfB4uupw+5BiiDAvu7aZr59TF3O0tLJZ5d NbjHWxLSfECJIs/Vq/51YPufDrreJJ+jt29ofFGTNbrHVO+CbZqO+lCh+S/yKgdpGxzA oL/bFQ/FsOA9FXdmeOTTNs3mUSf0yfEVOZLFKgK8f+rVarFFAVE4CsJzRu6uIOq3xNXC CxsIe5nz/sjRRa6trxm/VzE3f45jL/O3rQthSYHtSTBpVGF6ZIV1FOc4mgod1HjFkEaa VIjvbIfgSL+fh+H1XibVS+L3Ccw0Zwv7k3Bn5UsZA/G0On6Naab9xjvwQx2EzqgbALZV l5sw== X-Forwarded-Encrypted: i=1; AJvYcCXEzMYttxTKr6NEJmTXFx5j1t9OeYK5rCYZQcmqeN8KEP573Qn6saR/v1Ue8Xh/qF2ZueqEeJb+QE9d9sg2goc= X-Gm-Message-State: AOJu0YwyVpnhacCC7RZOmiro7lABpiDrVBScYDCaZ5s9ZqtnzDH/1ej1 lsHsuCSKUfyty5/enn9CLIrEz7k1ZF6oxqiPbuyM/g8svf5eRPN3m2AQG4rnVB9CW1m2iNfTERs 4XJ/H7c8U1A5j8U1DeVHIdZ3HV2UAqNh+2Dn2szO3U6lz0tWqPA9DssnUQnteJLHmInJQE0eSNX XdvWop0iNzfBGxpgvE88c= X-Received: by 2002:a2e:8850:0:b0:2ec:6e09:8e9d with SMTP id 38308e7fff4ca-2ee4963dbf9mr5602951fa.15.1719491827160; Thu, 27 Jun 2024 05:37:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFz/RMRYiCU2lpqy74GxqQqw9qcsiM7x86Bldcb3347aW0zjdjsoWNIMYEJ+qgMF2lQhJm2bRNCtZyqBzOtlPA= X-Received: by 2002:a2e:8850:0:b0:2ec:6e09:8e9d with SMTP id 38308e7fff4ca-2ee4963dbf9mr5602891fa.15.1719491826796; Thu, 27 Jun 2024 05:37:06 -0700 (PDT) MIME-Version: 1.0 References: <20240320155814.617220-1-alialnu@nvidia.com> In-Reply-To: From: David Marchand Date: Thu, 27 Jun 2024 14:36:55 +0200 Message-ID: Subject: Re: [PATCH] buildtools: fix build with clang 17 To: Ali Alnubani Cc: dev@dpdk.org, thomas@monjalon.net, stable@dpdk.org, Bruce Richardson , Mingjin Ye X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Wed, Mar 20, 2024 at 5:30=E2=80=AFPM David Marchand wrote: > > Hello Ali, Thomas, > > On Wed, Mar 20, 2024 at 5:01=E2=80=AFPM Ali Alnubani = wrote: > > > > On Fedora 39 with Clang 17.0.3 and ASan enabled, > > RTE_PMD_EXPORT_NAME seems to be done twice for a single > > lib, which results in load_drivers() returning a list > > consisting of 2 drivers (e.g., ['mlx5_common_pci', '']). > > image.find_by_prefix("this_pmd_name") returns 2 symbols in this case, > > "mlx5_common_pci" and an empty string ''. This didn't reproduce > > with clang version 16.0.6. > > > > This patch ensures that a symbol with an empty string_value doesn't > > cause an addition to the list of drivers. > > I suppose this comes from ASan instrumenting the code: > # nm /root/dpdk/build-clang/drivers/libtmp_rte_common_mlx5.a | grep this_= pmd > 0000000000000000 r this_pmd_name3 > 0000000000000000 n this_pmd_name3.e5676185d74e2e1a9de646deebca963f > 0000000000000000 r this_pmd_name3 > 0000000000000000 n this_pmd_name3.a2533baf7a46959f41383725087d4086 > > The name of the symbols this script should look for has a clear > format, which is this_pmd_name[0-9]+. > Filtering with this pattern, there would be no need to go and > interpret a symbol content. Ali, can you send a v2? --=20 David Marchand