patches for DPDK stable branches
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: dev@dpdk.org, rmelton@cisco.com, davejo@cisco.com,
	speechu@cisco.com,  chenbo.xia@outlook.com, mbumgard@cisco.com,
	cbrezove@cisco.com,  stable@dpdk.org
Subject: Re: [PATCH] net/virtio: fix descriptors buffer addresses on 32 bits builds
Date: Wed, 20 Sep 2023 15:53:28 +0200	[thread overview]
Message-ID: <CAJFAV8w2WcT0Ln3Sv-Mhsg+zp3fUdEidg7vjvqfJ8x+C=hsuCA@mail.gmail.com> (raw)
In-Reply-To: <20230920130147.1567735-1-maxime.coquelin@redhat.com>

On Wed, Sep 20, 2023 at 3:02 PM Maxime Coquelin
<maxime.coquelin@redhat.com> wrote:
>
> With Virtio-user, the Virtio descriptor buffer address is the
> virtual address of the mbuf's buffer. On 32 bits builds, it is
> expected to be 32 bits.
>
> With Virtio-PCI, the Virtio descriptor buffer address is the
> physical address of the mbuf's buffer. On 32 bits builds running
> on 64 bits kernel, it is expected to be up to 64 bits.
>
> This patch introduces a new mask field in virtqueue's struct to
> filter our the upper 4 bytes of the address only when necessary.
> An optimization is introduced for 64 bits builds to remove the
> masking, as the address is always 64 bits wide.
>
> Fixes: ba55c94a7ebc ("net/virtio: revert forcing IOVA as VA mode for virtio-user")
> Cc: stable@dpdk.org
>
> Reported-by: Sampath Peechu <speechu@cisco.com>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Reviewed-by: David Marchand <david.marchand@redhat.com>

-- 
David Marchand


  reply	other threads:[~2023-09-20 13:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-20 13:01 Maxime Coquelin
2023-09-20 13:53 ` David Marchand [this message]
2023-09-29 14:47 ` Dave Johnson (davejo)
2023-10-12 13:50 ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8w2WcT0Ln3Sv-Mhsg+zp3fUdEidg7vjvqfJ8x+C=hsuCA@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=cbrezove@cisco.com \
    --cc=chenbo.xia@outlook.com \
    --cc=davejo@cisco.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=mbumgard@cisco.com \
    --cc=rmelton@cisco.com \
    --cc=speechu@cisco.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).