From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B9404461BC for ; Fri, 7 Feb 2025 15:41:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B4741410E3; Fri, 7 Feb 2025 15:41:23 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 4D0AF410E3 for ; Fri, 7 Feb 2025 15:41:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738939281; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mNlWZVG6V1O4Elg6eLB35ubsz91znETIwE1eCauRS/o=; b=HauEaiKC/3eR5xf+x4py5K13mZo+phFnCK/nsnntW/dg29OxlDx1GvO9Y6I4pAR/2/L1N2 eK1QTOWK5pnreaCRKvtyuBr1KOuUdLcNIk7j4ZtdkDOuPnz1hHkl8LOe4kUQnZW4l/Ic6d XGlEs4wpDIQFq+wKKW2u1TWkFVl5hSE= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-26-z0ZobkG_OKamqK5IGuSRnQ-1; Fri, 07 Feb 2025 09:41:20 -0500 X-MC-Unique: z0ZobkG_OKamqK5IGuSRnQ-1 X-Mimecast-MFC-AGG-ID: z0ZobkG_OKamqK5IGuSRnQ Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-54400b11ed0so1317297e87.3 for ; Fri, 07 Feb 2025 06:41:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738939279; x=1739544079; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mNlWZVG6V1O4Elg6eLB35ubsz91znETIwE1eCauRS/o=; b=dWs5acuCUcZONSm6O1dtMkTtzIdjMY1pjwgZ8XlJD4DuhB0O6lvrMSfW5ianXAElwZ 5E4KhOIX1WBa/VZigKiYKWWej1Bk+e6hvTHy5nonC3oQsHzhWZ8NcFu0F4GW172QH9Q1 H5O3AadvK9mo5AsV85lpfaFZk//vLSbhf8SEDkFp63XfJ1w3UFgixfQjZZnlFttG/99v z4e5cHN7qwfY89HAbaXbwHD3ivPyICV4oSdV/ATvXYFjwHLmHM0kFQvnHNbq2HSbASkm e5MSWPhe1ArqGoAnPFaDCoOG0IBHM1z3LYbd6dLTbYdaqMV2shmqReZXE2DgClmqjWbj 8wUQ== X-Forwarded-Encrypted: i=1; AJvYcCWK7E1u7QW2r9ZwV2hExu+tszhgLgDKFCf9yW1ISvJEHXbd/VulGzbICYtdcg2VacgGHwkVKcI=@dpdk.org X-Gm-Message-State: AOJu0YyMz6k6b0YL4YsB9w8PFlFcK2rX4+GuGyRPVgySPhKYcEhPRJjx X1t/qHdpiYL2M9TWRk15TJKQs0kKVsSjfHEwN87oFydktnaXRwuJPThVGiKM2KLjpOuo2Y4syFt u7IVPnRtLTvRZJlEHe5ZUFqA0UtO4M6RPzz8GmgVi1mFZJNn+Byl/66X03J9914Gt2fY4i4GEc2 Q4zZr9TTVFyfpzll6+BK0= X-Gm-Gg: ASbGncsx1ny7QKYkyr3ozr/60lwAc9K7Zg6KxEMfC9pQ1fDMzWJqZJE73+wD+dkiUvr 8pEjdE6CBrjcvjGET0Z+4fCSRfcO/fqyqmmhhE0C5Rlfy/CSvCuZYc1qcr9MTLtZq X-Received: by 2002:a05:6512:718:b0:544:11e4:d53e with SMTP id 2adb3069b0e04-54414b06e0fmr990120e87.48.1738939279062; Fri, 07 Feb 2025 06:41:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IHncPa5Rh7OH4JeNZcLbFhs5BAjt3qXZ0WKlPuTvmY7IQ37Z+rKvmTNY+nfm2iQDVuqXgNJhxwEaDmM60/oTHk= X-Received: by 2002:a05:6512:718:b0:544:11e4:d53e with SMTP id 2adb3069b0e04-54414b06e0fmr990109e87.48.1738939278669; Fri, 07 Feb 2025 06:41:18 -0800 (PST) MIME-Version: 1.0 References: <20241226081020.3479-1-ming.1.yang@nokia-sbell.com> <20250102085838.991-1-ming.1.yang@nokia-sbell.com> In-Reply-To: <20250102085838.991-1-ming.1.yang@nokia-sbell.com> From: David Marchand Date: Fri, 7 Feb 2025 15:41:06 +0100 X-Gm-Features: AWEUYZny6B2wnTYn7c2w8azRUUyl1CWrh3vFR7c1zthrAc6Lc2Bhixw_WPfVK2Y Message-ID: Subject: Re: [PATCH v2] eal: fix unused memseg length To: Yang Ming Cc: dev@dpdk.org, anatoly.burakov@intel.com, stable@dpdk.org, Dmitry Kozlyuk X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 5D9Ousi_k6Do6qYM06c0t73r8K81xAcbikIjPUy_Xgw_1738939279 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Thu, Jan 2, 2025 at 9:59=E2=80=AFAM Yang Ming wrote: > > Fix the issue where OS memory is mistakenly freed with rte_free > by setting the length (len) of unused memseg to 0. > > When `eal_legacy_hugepage_init()` releases the VA space for > unused memseg lists(MSLs), it does not reset MSLs' length to 0. > As a result, `mlx5_mem_is_rte()` may incorrectly identify OS > memory as rte memory. > This can lead to `mlx_free()` calling `rte_free()` on OS memory, > causing an "EAL: Error: Invalid memory" log and failing to free > the OS memory. > > This issue is occasional and occurs when the DPDK program=E2=80=99s > memory map places the heap address range between 0 and len(32G). > In such cases, malloc may return an address less than len, > causing `mlx5_mem_is_rte()` to incorrectly treat it as rte > memory. > > Also, consider how the MSL with `base_va =3D=3D NULL` ends up in > `mlx5_mem_is_rte()`. It comes from `rte_mem_virt2memseg_list()` > which iterates MSLs and checks that an address belongs to > [`base_va`; `base_va+len`) without checking whether > `base_va =3D=3D NULL` i.e. that the MSL is inactive. So this patch > also corrects `rte_mem_virt2memseg_list()` behavior. > > Fixes: 66cc45e293ed ("mem: replace memseg with memseg lists") > Cc: stable@dpdk.org > > Signed-off-by: Yang Ming > Acked-by: Dmitry Kozlyuk Applied, thanks for the fix. --=20 David Marchand