patches for DPDK stable branches
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Declan Doherty <declan.doherty@intel.com>,
	 Pablo de Lara <pablo.de.lara.guarch@intel.com>,
	Chas Williams <chas3@att.com>,  "humin (Q)" <humin29@huawei.com>
Cc: dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org>,
	 Lance Richardson <lance.richardson@broadcom.com>
Subject: Re: [dpdk-stable] [PATCH] app/test: fix IPv6 header initialization
Date: Tue, 11 May 2021 16:31:29 +0200
Message-ID: <CAJFAV8w=c140Hxce6ay+sm=LTSPhvu_Nztkqj+Y0w=_XSxf__w@mail.gmail.com> (raw)
In-Reply-To: <20210326163732.763862-1-lance.richardson@broadcom.com>

On Fri, Mar 26, 2021 at 5:37 PM Lance Richardson
<lance.richardson@broadcom.com> wrote:
>
> Fix two issues found when writing PMD unit tests for HW ptype and
> L4 checksum offload:

Would those unit tests be interesting to other pmd driver writers?


>
>    - The version field in the IPv6 header was being set to zero,
>      which prevented hardware from recognizing it as IPv6. The
>      IP version field is now set to six.
>    - The payload_len field was being initialized using host byte
>      order, which (among other things) resulted in incorrect L4
>      checksum computation. The payload_len field is now set using
>      network (big-endian) byte order.
>
> Fixes: 92073ef961ee ("bond: unit tests")

Odd that this never got caught before, I guess nobody ran the bonding
test with ipv6.

Adding new maintainers for the bonding code since this helper is only
used in the bonding ut.
Should we take this in 21.05 or wait 21.08?


> Cc: stable@dpdk.org
>
> Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>

Reviewed-by: David Marchand <david.marchand@redhat.com>


-- 
David Marchand


  reply	other threads:[~2021-05-11 14:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-26 16:37 Lance Richardson
2021-05-11 14:31 ` David Marchand [this message]
2021-05-11 14:42   ` Lance Richardson
2021-06-21 12:40     ` Lance Richardson
2021-06-21 12:49       ` David Marchand
2021-07-05  8:22 ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8w=c140Hxce6ay+sm=LTSPhvu_Nztkqj+Y0w=_XSxf__w@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=chas3@att.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=humin29@huawei.com \
    --cc=lance.richardson@broadcom.com \
    --cc=pablo.de.lara.guarch@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git