From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A3D51A09E4 for ; Fri, 29 Jan 2021 09:04:05 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 75C0D40395; Fri, 29 Jan 2021 09:04:05 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id A919040395 for ; Fri, 29 Jan 2021 09:04:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611907442; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Go8VLHaUTk2xUKwOjSRUushJxtnHziaSMrlMTs03oYc=; b=OZFUt99FqxUd/4WDDqKj5YVhhph69vXhR7Wkgqu6+H6dtb1UCV857qE8vHfpaFJN1grzum fhjse5Z7esJwKnhKdsyYp6qjhdzb7EK1j4v3A/nbsJzrl8FmWzmI6lM8DPn8xEFsiU+6ui cnWsRuojiJO/HG/SXxt9+CalGc4flrg= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-485-10hMGg-yNB2kSTr888abaQ-1; Fri, 29 Jan 2021 03:04:00 -0500 X-MC-Unique: 10hMGg-yNB2kSTr888abaQ-1 Received: by mail-vk1-f197.google.com with SMTP id n14so2340238vkq.2 for ; Fri, 29 Jan 2021 00:04:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Go8VLHaUTk2xUKwOjSRUushJxtnHziaSMrlMTs03oYc=; b=LBXkwBqgJfoAy+ZSKxYiyNVFQUrBeJg+BS7EynKpSIosHspQZdxLuZausb+RQMGdrk ixZIg8LLoTE8fM4xHZkmiG5BBJvue7KPw/cyhJxpCKSkIq/3NF1J5ZegCqMcwGKisbdK e7nY0724tH3i2ZsYW9fN/3tHtx9angXEqONTkuJlNKNt0NtTuXf4fPR2dSt6gPsL24NY kAs12UBx0LCYAffICaqh7GjUJ7Qc+L70He6+ZE04MQ+/shx1dUwNnOMGDfmNKFpYY1su S5abFAnwrxq4P5uVo0/+bFZXgSxR7HINWCMmD79WPO0jqJzwNsZm4bRrado4MZUvPmiv hpYQ== X-Gm-Message-State: AOAM531tuZui308VUHgexBhk8D+IdVx9S86wIiKkwtkPZv8/HWItwjMC bfJHfrh4UIeqb9dtZ7ZuNtTT7FaPafhmNylQKKE1njJ1ukXEngL29/7Jj17eNGPH3WcOeBggrrX wwG9QP4I84SJPDSYWih1niq0= X-Received: by 2002:a05:6102:3136:: with SMTP id f22mr2276357vsh.17.1611907440271; Fri, 29 Jan 2021 00:04:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJyI12QZ+VFurf9I2VhPrZkMSr8MTmfaU4dTEIEG3/A3ugKrD0tZr0XsBfWGFMcfyGj+BM6Yv1sw8HfaYfoussM= X-Received: by 2002:a05:6102:3136:: with SMTP id f22mr2276350vsh.17.1611907440069; Fri, 29 Jan 2021 00:04:00 -0800 (PST) MIME-Version: 1.0 References: <20210119035910.8324-1-l.wojciechow@partner.samsung.com> <20210119035910.8324-2-l.wojciechow@partner.samsung.com> In-Reply-To: From: David Marchand Date: Fri, 29 Jan 2021 09:03:49 +0100 Message-ID: To: Lukasz Wojciechowski , David Hunt , Bruce Richardson Cc: dev , dpdk stable , "Ruifeng Wang (Arm Technology China)" , ci@dpdk.org Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [PATCH v1 1/1] test/distributor: prevent return buffer overload X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Thu, Jan 28, 2021 at 3:10 PM David Marchand wrote: > > On Tue, Jan 19, 2021 at 4:59 AM Lukasz Wojciechowski > wrote: > > > > The distributor library implementation uses a cyclic queue to store > > packets returned from workers. These packets can be later collected > > with rte_distributor_returned_pkts() call. > > However the queue has limited capacity. It is able to contain only > > 127 packets (RTE_DISTRIB_RETURNS_MASK). > > > > Big burst tests sent 1024 packets in 32 packets bursts without waiting > > until they are processed by the distributor. In case when tests were > > run with big number of worker threads, it happened that more than > > 127 packets were returned from workers and put into cyclic queue. > > This caused packets to be dropped by the queue, making them impossible > > to be collected later with rte_distributor_returned_pkts() calls. > > However the test waited for all packets to be returned infinitely. > > > > This patch fixes the big burst test by not allowing more than > > queue capacity packets to be processed at the same time, making > > impossible to drop any packets. > > It also cleans up duplicated code in the same test. > > > > Bugzilla ID: 612 > > Fixes: c0de0eb82e40 ("distributor: switch over to new API") > > Cc: stable@dpdk.org > > > > Signed-off-by: Lukasz Wojciechowski > Tested-by: David Marchand Reviewed-by: David Hunt Applied, thanks Lukasz. This should fix the issue seen at UNH on the ARM server. -- David Marchand