From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dmarchan@redhat.com>
Received: from mail-vs1-f53.google.com (mail-vs1-f53.google.com
 [209.85.217.53]) by dpdk.org (Postfix) with ESMTP id 218841B120
 for <stable@dpdk.org>; Tue, 18 Dec 2018 11:38:09 +0100 (CET)
Received: by mail-vs1-f53.google.com with SMTP id x1so9664573vsc.10
 for <stable@dpdk.org>; Tue, 18 Dec 2018 02:38:09 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=tC1gLeQNzVOcPtv5A4mafW/toqWIjjT5WjYDm4gmjlo=;
 b=WZXnwg/GCtEtGdyhSijl7DXWufCbNcmsdqca8IVxqb3Z79gZHZzdKORV7xMoDa/HDD
 Pw3xFembHVHeO40RFE2QM95p3bYw0/nJoPKPQvu89x56wvwTMI7fCmf69SIj7ovgKW6h
 37VsDP/HvxkH/9nST8By0wPTV/tF8dnJ6SnQo1DGs9jYWSoaZ0ld7lYefai+rXV6aaXb
 krqhM5l7/fctnipuhJWh69KnD8vA6NJpnGWlaX5Pmbz0SLq9GZE4q8HzRu6KzD6USOHk
 QRMfHjJCQDoDLP/XO2n3p1LrpjSugILH+h4553L6CPS30Y/VvBE3+/ARn4ah5LxfeiIi
 k8+g==
X-Gm-Message-State: AA+aEWYGmMAn5vs99vwaI6Lx+lyN/DbC5TgU7xWdc3L6bH2Hv6OoVUn+
 916Jufpod0qSKHynbTcHBbmU7u9NFsyv6af7/FKQtA==
X-Google-Smtp-Source: AFSGD/W/rCQg9u3BBH+4bMhYTTbnrgh8Pw7gZeHR/rCyJBws8jC3pssnPHjCLPhT0+zh0ozuL27zRJL7vJ0cZfyJVPg=
X-Received: by 2002:a67:c48a:: with SMTP id d10mr1585634vsk.105.1545129488563; 
 Tue, 18 Dec 2018 02:38:08 -0800 (PST)
MIME-Version: 1.0
References: <1543957065-20990-1-git-send-email-david.marchand@redhat.com>
 <a12c2d1a-c50f-1c46-8c3a-05de781a934d@nxp.com>
 <CAJFAV8z8TRkagOg5FzxYjD9WP=wDa8XbyjcGzHXdKvr5GJrLeA@mail.gmail.com>
 <20181214123538.GA28669@hmswarspite.think-freely.org>
 <3D3765A8CDB52A4C8B410430AA19CB23709189AF@IRSMSX104.ger.corp.intel.com>
In-Reply-To: <3D3765A8CDB52A4C8B410430AA19CB23709189AF@IRSMSX104.ger.corp.intel.com>
From: David Marchand <david.marchand@redhat.com>
Date: Tue, 18 Dec 2018 11:37:57 +0100
Message-ID: <CAJFAV8wM6NksBF_+j_569oS78SEp_Vd9wr2gNJD7wL5CuDofSg@mail.gmail.com>
To: Akhil Goyal <akhil.goyal@nxp.com>
Cc: Neil Horman <nhorman@tuxdriver.com>, "dev@dpdk.org" <dev@dpdk.org>, 
 "stable@dpdk.org" <stable@dpdk.org>,
 "tredaelli@redhat.com" <tredaelli@redhat.com>, 
 "Yigit, Ferruh" <ferruh.yigit@intel.com>, amr.mokhtar@intel.com
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] bbdev: add missing
	experimental tags
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Dec 2018 10:38:09 -0000

Hello Akhil,

On Fri, Dec 14, 2018 at 1:52 PM Mokhtar, Amr <amr.mokhtar@intel.com> wrote:

>
> > -----Original Message-----
> > From: Neil Horman [mailto:nhorman@tuxdriver.com]
> > Sent: Friday 14 December 2018 12:36
> > To: David Marchand <david.marchand@redhat.com>
> > Cc: Akhil Goyal <akhil.goyal@nxp.com>; dev@dpdk.org; stable@dpdk.org;
> > tredaelli@redhat.com; Yigit, Ferruh <ferruh.yigit@intel.com>; Mokhtar,
> > Amr <amr.mokhtar@intel.com>
> > Subject: Re: [dpdk-dev] [PATCH] bbdev: add missing experimental tags
> >
> > On Fri, Dec 14, 2018 at 11:00:17AM +0100, David Marchand wrote:
> > > On Fri, Dec 14, 2018 at 10:54 AM Akhil Goyal <akhil.goyal@nxp.com>
> > wrote:
> > >
> > > > Hi David,
> > > >
> > > > I can see that there are other APIs as well which are not marked as
> > > > experimental like rte_bbdev_dec_op_alloc_bulk
> > > > rte_bbdev_dec_op_free_bulk, rte_bbdev_enqueue_enc_ops etc.
> > > >
>
> It seems that all APIs defined in rte_bbdev_op.h are missing their
> experimental tags.
>
> > >
> > > Well, that's the problem with inlines...
> > > I don't think we can detect these easily.
> > >
> > We can, if the symbols get added to the version map as they should.  But
> > (as you
> > note), because these functions are inlines, theres no error thrown for
> not
> > following that rule.
> >
>
> Right, there are some APIs missing in the map file.
> I am submitting a patch of those functions missing.
>

Sorry, did not follow up on this.
My patch has been marked as "Changes Requested" in pw but Amr volunteered
to fix those issues.

How do we proceed, do you want a single fix ? or you can already pick mine.


-- 
David Marchand