From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C802DA0A0E for ; Mon, 10 May 2021 15:35:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B0A72410E3; Mon, 10 May 2021 15:35:11 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id F12D040395 for ; Mon, 10 May 2021 15:35:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620653709; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AkQHIVC/LXoAS6y4l+fekjuOSzUXDN3Tu7pZIT2KGJI=; b=WInsJFKkIbyfNy9ilhQ/p4H3N9PbP5xZ8ziOqPqiBysELzzkuhLgQVPPnBNTPs2ggOohXL 0JizaJ1rm/uSM51fR7lk+pv1DCKdrlASlEnejtLnUnVNNDI9BVvRnkIG0HyHlwidA8EILI uqqX9BopuUaGV3YcxpEH/LKhMciaVLg= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-413-nt7JlT_QM2SzCnVTGKF7_w-1; Mon, 10 May 2021 09:35:07 -0400 X-MC-Unique: nt7JlT_QM2SzCnVTGKF7_w-1 Received: by mail-vs1-f70.google.com with SMTP id l6-20020a67d5060000b0290228235bc72dso8166215vsj.13 for ; Mon, 10 May 2021 06:35:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AkQHIVC/LXoAS6y4l+fekjuOSzUXDN3Tu7pZIT2KGJI=; b=Q5YJtkRQYxMwxgvy86lcUJCqd9VCdKzE3kFghqmUsmAwZbYEpobmVfMGO4AVBBbAFc FCfcYGAmimbocBwHlWZ59pj/2o/XB0ovZ14COpJBZ5UqEMk2LmvkA0WKJPL2/ScyWp53 4bmbXSwKCNHIs8kO20b/dnX0z7y6rQAWwKNjWM/WDewp/wXL5LSpqy86lxBNRn6gksCr jqGMDO8Pb9RdzFjWcrujB8zg1bsabbuvx99bJBTtoQakoxruMkAkW9dMTZl9Sqnodx4I 4GOo3XrZmzOtKeMn9kPkq+Ax5aVPW092o0GFxgV+WaSgCi6SIrzaxhW00hqOA+UP23ky MJbg== X-Gm-Message-State: AOAM531ufNoQoyxZhkpbBQV+TDXlCNZFn8q7hNUIJEsfcTWnRSaVn1SB o8w6/bdyhuTSwXzhNwdHYcYNETEQOdLvaDL0SKuiRdj3pJm9hn7bIseDSFV4tIbJDFEmdzEFX0+ noBUbPu+Txb6e5PkASXtXw40= X-Received: by 2002:a1f:a681:: with SMTP id p123mr17486519vke.22.1620653705130; Mon, 10 May 2021 06:35:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzLGdBku6USKMVsKJ89bh1uNZOjQmH1LXKR9pgPkGUkWoJlulAgYHAb79ogQbmJThdrOoKSxTyFNvTgyeyTmjM= X-Received: by 2002:a1f:a681:: with SMTP id p123mr17486352vke.22.1620653703453; Mon, 10 May 2021 06:35:03 -0700 (PDT) MIME-Version: 1.0 References: <20210509171803.1385-1-pbhagavatula@marvell.com> <20210509171803.1385-2-pbhagavatula@marvell.com> <20210509123931.463d6861@hermes.local> In-Reply-To: From: David Marchand Date: Mon, 10 May 2021 15:34:52 +0200 Message-ID: To: Pavan Nikhilesh Bhagavatula Cc: Stephen Hemminger , Haiyue Wang , Jiawen Wu , Jian Wang , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , "dev@dpdk.org" , "stable@dpdk.org" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [EXT] Re: [dpdk-dev] [PATCH 2/2] eal: fix side effects in ptr align macros X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hello Pavan, On Mon, May 10, 2021 at 11:50 AM Pavan Nikhilesh Bhagavatula wrote: > > >On Sun, 9 May 2021 22:48:02 +0530 > > wrote: > > > >> From: Pavan Nikhilesh > >> > >> Avoid expanding parameters inside RTE_*_ALIGN macros. > >> Update common_autotest to detect macro side effects. > >> Workaround static arrays relying on RTE_ALIGN macros. > >> > >> Fixes: af75078fece3 ("first public release") > >> Cc: stable@dpdk.org > >> > >> Signed-off-by: Pavan Nikhilesh > >> Signed-off-by: David Marchand > > > >Why not split these up? It looks like the Intel driver and common part > >could be separate? > > The common changes break intel/mlx5 driver compilation can't separate them. Thanks for working on this. The CI still reports a build error in mlx5. -- David Marchand