From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DD0E3A0540 for ; Mon, 14 Nov 2022 11:03:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D666041148; Mon, 14 Nov 2022 11:03:23 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 8C5794014F for ; Mon, 14 Nov 2022 11:03:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668420202; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yIAD4BsMLY5DGoVCHwWXsRnkbhltXaI4SrHQ8iTEbkg=; b=Jetw60mV6MRY4IUQI6fzncjB4d2VEUhT2qcIWIHBu9QRV0tIw7Exy/IbmXQLyrhkMsvMjv fRpusPoS8YYuwd/vj8bK1/bqhF/WvLWkReBoHfvzvUMQ/f5K1793fv56gMXQezzTt4Rgri weWTzZdjdcyrsMd3IwBSJlAhKs+68uE= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-247-uLOuEUN_MwyBMpjdXJ0SdA-1; Mon, 14 Nov 2022 05:03:18 -0500 X-MC-Unique: uLOuEUN_MwyBMpjdXJ0SdA-1 Received: by mail-pl1-f200.google.com with SMTP id k15-20020a170902c40f00b001887cd71fe6so8637351plk.5 for ; Mon, 14 Nov 2022 02:03:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yIAD4BsMLY5DGoVCHwWXsRnkbhltXaI4SrHQ8iTEbkg=; b=HAJosoWFa6t1d+BFoc8njBWX/6SJ0OdrqafZ+BXAz80ekPXpgYM+M+BjTJ4oNudd94 kGJh1jiXTTAtsFm3GBli89LbiNNGNhO7b4nFepTjjLIojgp9P5SuXrw7F5MwDDowQpU1 HYybojhZ2etc9o6T+XtVbz0aoh7E4KM2PFGJJUFgPg90+tLFIXk/Swuwfwp8cShbQOED ItiZStXSyiWnAy82LCsxEgeosmgavMD28t4mm9X79EFyB9Qw5BqU0g4/GH8AJ0EKGy7o pZfqLdQMXDSUL4jRMOBJF6xFPLbTlxzTro8fq1An50Ule/mqGNZm/+sEogcdHMI5IfXB ajJA== X-Gm-Message-State: ANoB5pmvIxdvUx4vhTFomh1XVzsCyn6B+EeoZeZf8f1yEXLrQcKXuCdw juy4/DcE3fefpyCY2SmzCiRNpCsHB+tDndD92x7r5vAN14BmnOckkAPrg9r7renkzPPM/rVUpd/ Y4JIsETksrV8h1qTrzeSPIKI= X-Received: by 2002:a17:90b:795:b0:212:c877:e948 with SMTP id l21-20020a17090b079500b00212c877e948mr13392339pjz.39.1668420197760; Mon, 14 Nov 2022 02:03:17 -0800 (PST) X-Google-Smtp-Source: AA0mqf75K4hQa4dGvL7oJyh/uIvG9qStWOqZQV/UdQAw3kc5FyPzKfillqTLIlmNpsd5iPjYfwY/PfvRMIIx5/Dxxe4= X-Received: by 2002:a17:90b:795:b0:212:c877:e948 with SMTP id l21-20020a17090b079500b00212c877e948mr13392320pjz.39.1668420197514; Mon, 14 Nov 2022 02:03:17 -0800 (PST) MIME-Version: 1.0 References: <20221104095123.487630-1-jun.qiu@jaguarmicro.com> In-Reply-To: <20221104095123.487630-1-jun.qiu@jaguarmicro.com> From: David Marchand Date: Mon, 14 Nov 2022 11:03:06 +0100 Message-ID: Subject: Re: [PATCH] hash: fix memory leak of hash_rcu_cfg To: Jun Qiu Cc: dev@dpdk.org, yipeng1.wang@intel.com, lei.cai@jaguarmicro.com, stable@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Fri, Nov 4, 2022 at 10:52 AM Jun Qiu wrote: > > The memory of h->hash_rcu_cfg which is allocated in > rte_hash_rcu_qsbr_add was leaked. > > Fixes: 769b2de ("hash: implement RCU resources reclamation") Please, use 12 chars format for commit hash, as documented. git config alias.fixline "log -1 --abbrev=12 --format='Fixes: %h (\"%s\")%nCc: %ae'" > Cc: stable@dpdk.org > > Signed-off-by: Jun Qiu Reviewed-by: David Marchand Applied, thanks. -- David Marchand