From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1BA97431EE for ; Tue, 24 Oct 2023 11:49:58 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ED1E3402BE; Tue, 24 Oct 2023 11:49:57 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id DC1FD40285 for ; Tue, 24 Oct 2023 11:49:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698140996; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7jtbfOK7W0xmCL9hSR8pVdXhwx7GLJ4/b4nn5YfQ64Y=; b=PHvPqH5YXTREaUHv90w6aClT6AQ9k7UW9ArGCvGhrTN9t5rNEV1Bs/fNLpf/6FyxYGGe/T LxAkEs42uTPuNwb18P54m+4CJ3nzoeyPcwELu1ztm9OHD3Ik3fm8jgMtcfeGU3mrHCnWnz yc1P16HS4vq/A4ejJyGoCQRh3t45AGI= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-655-253Y60uzN-i7oyRckUc6wg-1; Tue, 24 Oct 2023 05:49:54 -0400 X-MC-Unique: 253Y60uzN-i7oyRckUc6wg-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2ba1949656bso36141181fa.0 for ; Tue, 24 Oct 2023 02:49:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698140992; x=1698745792; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7jtbfOK7W0xmCL9hSR8pVdXhwx7GLJ4/b4nn5YfQ64Y=; b=m7i+XansNVvSbf5COXKemtcAvM59KgN/WbF0PZ7kqs29/9YFkciL+Z1rnFLq+ePYVf y+Z9xrhY9HF3NZ3SGQ7v/fLg6jVqcz1GFxZbY4nyfSxQvcB+JROsY4UJEPXOcg3OBvkM 9Rmt02pYcAKMWS6O8P3VIhDG3cnmkTpRjgDkDOL57S4LmRN9AexFSQQ5yhQS7LRzX5Qj eCH+afWerL/M7XxehcPpbFot+t5sbPspePXH+G2MXKHdtRwfnIOTL1rfMwCYb2iIUkfe 9E+yH1XZHvj3KFVNPOXR1zbxvtNjflQjbrx8759d777HA2lq2CVnUIMdhNX1MR2SiS1B bbZQ== X-Gm-Message-State: AOJu0Yx27EOErrc4glNKp+aOfyRzzmIhfnwU8z6LlLqtUumrUsI7Rzsw Qft5PtP1Bg3U1Uo46DWxbqohHfpqitSpgybvxa+2PsKs2NOvamBUFuf3NOPP7VDSy278Ex+RCae kqSbn+S9cCsP90KfElYLgsSs= X-Received: by 2002:a2e:b172:0:b0:2c5:1388:e369 with SMTP id a18-20020a2eb172000000b002c51388e369mr9287718ljm.43.1698140992373; Tue, 24 Oct 2023 02:49:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHAvxKj3qC4UFGqSldzQ4hn0WB3tYTnEzGO9K2ehqIjuRJmCZbePe7LIiIlct/5j0efmYPlOVLs3uvAPrgPs54= X-Received: by 2002:a2e:b172:0:b0:2c5:1388:e369 with SMTP id a18-20020a2eb172000000b002c51388e369mr9287698ljm.43.1698140992076; Tue, 24 Oct 2023 02:49:52 -0700 (PDT) MIME-Version: 1.0 References: <20231024091328.11933-1-radu.nicolau@intel.com> In-Reply-To: <20231024091328.11933-1-radu.nicolau@intel.com> From: David Marchand Date: Tue, 24 Oct 2023 11:49:39 +0200 Message-ID: Subject: Re: [PATCH] net/iavf: fix IAVF_TX_OFFLOAD_MASK definition To: Radu Nicolau Cc: Jingjing Wu , Beilei Xing , dev@dpdk.org, stable@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Tue, Oct 24, 2023 at 11:13=E2=80=AFAM Radu Nicolau wrote: > > IAVF_TX_OFFLOAD_MASK definition contained > RTE_ETH_TX_OFFLOAD_SECURITY instead of > RTE_MBUF_F_TX_SEC_OFFLOAD. > > Fixes: 6bc987ecb860 ("net/iavf: support IPsec inline crypto") > Cc: stable@dpdk.org > > Signed-off-by: Radu Nicolau Something is not clear to me. How was the IPsec inline crypto feature supposed to work with this driver so far? Any packet with the RTE_MBUF_F_TX_SEC_OFFLOAD flag should have been refused in iavf_prep_pkts. --=20 David Marchand