From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 23B17A0093 for ; Tue, 19 May 2020 09:44:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EE0361D5C9; Tue, 19 May 2020 09:44:00 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 35F291D423 for ; Tue, 19 May 2020 09:43:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589874237; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Cet4FmXP0/ZISBR6Jmgr4O11eqXlNFF7fQzHKD1sOGI=; b=PGc1KuQARcf7kEe1BZlabTB88sWNiJBtNFYYvqVE/nCqhTDoV7Hl5uot6VNWlki02HwV3Y mIp24/BpcWrfiE/x+cbpicphDDZ7fGANwwgrOJWmMBUK241ZFd0Rj4CaupN4sCZzCL4mYf SsHLAvi0y3xmMc6Md4j6kYqas51GWbA= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-248-2SK8YIM6M1C_kmHcsx_a4A-1; Tue, 19 May 2020 03:43:56 -0400 X-MC-Unique: 2SK8YIM6M1C_kmHcsx_a4A-1 Received: by mail-vs1-f70.google.com with SMTP id n64so58049vsd.10 for ; Tue, 19 May 2020 00:43:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Cet4FmXP0/ZISBR6Jmgr4O11eqXlNFF7fQzHKD1sOGI=; b=J44iFD4+spSxuJytBUDzvX4GKoht5G68dZLBrd9xwYyiGuPLc2vwq/KshUBpT904Ok eRYrLQH6BPOZQxTMZN1Hyf2ACI4R8LdXrLlKDjZW6CfnrrK/doghL8ca0myFVw70lMuw LWC9OgFS43t/9Li1j4OHKtXOuF3dwF2ghKDHAuSuv+ycpmo8T4CtRdqlqzAdV4HgAdBJ CYEVYU8wKi/Zp9z6IY9p9CSXmaiTnqP7e/QX+wJwDcYaJ4VYLUt8Oxv11SU5dPGiaaQI f4qIQvyS0/8nPlbeWbVMdbfzb4DMyowOptHC7rSzOSC5NekaTrXDzZHyuKF52dqKwUk7 Mnug== X-Gm-Message-State: AOAM530gudelSKgeexIu4TJaKJf2iLSWsS5OgSu4tsOYRW+OasSpn4Ao H7y5e0WFVQ+sAoAelUQK5r9wJDUGarU7cXJnU9Oy75ow7+dbGQ/deS2X7ZAMndVfpELIeZzaAmc rTnIfoS75y13cQbeqedXkJog= X-Received: by 2002:a9f:2c87:: with SMTP id w7mr15010807uaj.41.1589874235490; Tue, 19 May 2020 00:43:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyLY+bniWAADxQ4EizeTZcd4Oi1kyQKlHuxHfbS+aC33R8PcacMSgtgkT+uyirl5qNWsSIwG1rSMvvu3zofaBc= X-Received: by 2002:a9f:2c87:: with SMTP id w7mr15010792uaj.41.1589874235214; Tue, 19 May 2020 00:43:55 -0700 (PDT) MIME-Version: 1.0 References: <1589859720-16224-1-git-send-email-wangyunjian@huawei.com> In-Reply-To: <1589859720-16224-1-git-send-email-wangyunjian@huawei.com> From: David Marchand Date: Tue, 19 May 2020 09:43:44 +0200 Message-ID: To: wangyunjian , "Burakov, Anatoly" , Luca Boccassi , Kevin Traynor Cc: dev , Hemant Agrawal , Sachin Saxena , "Lilijun (Jerry)" , xudingke , dpdk stable X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 1/2] vfio: fix check for vfio_group_fd X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Tue, May 19, 2020 at 5:42 AM wangyunjian wrote: > > From: Yunjian Wang > > The issue is that a file descriptor at 0 is a valid one. Currently > the file not found, the return value will be set to 0. As a result, > it is impossible to distinguish between a correct descriptor and a > failed return value. Fix it to return -ENOENT instead of 0. > > Fixes: b758423bc4fe ("vfio: fix race condition with sysfs") > Fixes: ff0b67d1c868 ("vfio: DMA mappinge") > Cc: stable@dpdk.org This patch reverts the (marked for stable) fix b758423bc4fe ("vfio: fix race condition with sysfs") and comes with a different fix. - Kevin, Luca, I would put this b758423bc4fe backport on hold. - Anatoly, I don't want to put 20.05 at risk. My simple question for 20.05 is, should we revert b758423bc4fe? - This patchset will go to 20.08 as I don't feel confident in taking it now. -- David Marchand