From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 9646FA0096 for ; Wed, 5 Jun 2019 11:35:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 69E761BA5A; Wed, 5 Jun 2019 11:35:16 +0200 (CEST) Received: from mail-vs1-f66.google.com (mail-vs1-f66.google.com [209.85.217.66]) by dpdk.org (Postfix) with ESMTP id 800961BA8F for ; Wed, 5 Jun 2019 11:35:15 +0200 (CEST) Received: by mail-vs1-f66.google.com with SMTP id n21so9549824vsp.12 for ; Wed, 05 Jun 2019 02:35:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Zh7X2klEYoeLEapZJ0d7zgxra+jKeWiNkWLsmJCRn9Q=; b=rTlwbxHwJ9TClBQVSrsIQs89v1fb1WlBFzY0jdia2ZSg++jszh0eYEV1bVXWg0oBpT I0AXmr2nw1YJdqc3+yVagSGGnEHZO7GjnLzrAwQkb7nS3CZElN09IFTjMtw9+7thDcJa XNbIQVvmgb0kjidqKl77QJBXls9V4wUZU9KRWYruSp4ireb3TTEEjEUMkIpdNEQlZ9ew ziEeZ8yBxtdpH6k+8jecKIDFWUbfqkNCkZ+lFchfFUWs0UCQ94F9V4hPVfDmvrFkD6UY gklQVNVc7pFZYSDX1WYxe+3ycbRr4yDx1xmKICXvxyPKZjK9Deri2BqnvQq7B5VnoAO5 pzLQ== X-Gm-Message-State: APjAAAXnbBzWGoNAPjCkuUGSGxMl0TQx/ztCPC1sJD+CHfCBAM8LaKJP xvCeZvPAZdQGFrDFHPbxnuV5A/1RuWSahVJ9NkSN9Q== X-Google-Smtp-Source: APXvYqyUK9vpZb9nCMAF7p8ZI/J+FPteTGORR0o87adBrBHh0hittGJK+sWNr+HGTTiSORBuUxYZEo8k6XX0KAQGugU= X-Received: by 2002:a67:e9ca:: with SMTP id q10mr8403383vso.105.1559727314969; Wed, 05 Jun 2019 02:35:14 -0700 (PDT) MIME-Version: 1.0 References: <20190605081005.15716-1-maxime.coquelin@redhat.com> <20190605081005.15716-5-maxime.coquelin@redhat.com> In-Reply-To: <20190605081005.15716-5-maxime.coquelin@redhat.com> From: David Marchand Date: Wed, 5 Jun 2019 11:35:04 +0200 Message-ID: To: Maxime Coquelin Cc: dev , ybrustin@cisco.com, Tiwei Bie , Jens Freimann , dpdk stable Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2 4/4] net/virtio: remove useless pointers checks X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Wed, Jun 5, 2019 at 10:11 AM Maxime Coquelin wrote: > This patch removes uses checks on 'prev' pointer, as it > is always set before with a valid value. > > Signed-off-by: Maxime Coquelin > --- > drivers/net/virtio/virtio_rxtx.c | 15 ++++----------- > 1 file changed, 4 insertions(+), 11 deletions(-) > > diff --git a/drivers/net/virtio/virtio_rxtx.c > b/drivers/net/virtio/virtio_rxtx.c > index 33dbc78906..fabd2e31d5 100644 > --- a/drivers/net/virtio/virtio_rxtx.c > +++ b/drivers/net/virtio/virtio_rxtx.c > @@ -1517,9 +1517,7 @@ virtio_recv_pkts_inorder(void *rx_queue, > > rx_pkts[nb_rx]->pkt_len += (uint32_t)(len[i]); > > - if (prev) > - prev->next = rxm; > - > + prev->next = rxm; > prev = rxm; > seg_res -= 1; > } > @@ -1703,9 +1701,7 @@ virtio_recv_mergeable_pkts(void *rx_queue, > rx_pkts[nb_rx]->pkt_len += (uint32_t)(len[i]); > rx_pkts[nb_rx]->data_len += (uint16_t)(len[i]); > > - if (prev) > - prev->next = rxm; > - > + prev->next = rxm; > prev = rxm; > seg_res -= 1; > } > @@ -1879,9 +1875,7 @@ virtio_recv_mergeable_pkts_packed(void *rx_queue, > rx_pkts[nb_rx]->pkt_len += (uint32_t)(len[i]); > rx_pkts[nb_rx]->data_len += (uint16_t)(len[i]); > > - if (prev) > - prev->next = rxm; > - > + prev->next = rxm; > prev = rxm; > seg_res -= 1; > } > @@ -1924,8 +1918,7 @@ virtio_recv_mergeable_pkts_packed(void *rx_queue, > } else { > PMD_RX_LOG(ERR, > "No enough segments for packet."); > - if (prev) > - virtio_discard_rxbuf(vq, prev); > + virtio_discard_rxbuf(vq, prev); > rxvq->stats.errors++; > break; > } > -- > 2.21.0 > > Reviewed-by: David Marchand -- David Marchand