From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id 93D56A0471
	for <public@inbox.dpdk.org>; Wed, 19 Jun 2019 16:30:43 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 5C65C1C2EF;
	Wed, 19 Jun 2019 16:30:43 +0200 (CEST)
Received: from mail-io1-f65.google.com (mail-io1-f65.google.com
 [209.85.166.65]) by dpdk.org (Postfix) with ESMTP id 192231C2F7
 for <stable@dpdk.org>; Wed, 19 Jun 2019 16:30:42 +0200 (CEST)
Received: by mail-io1-f65.google.com with SMTP id k20so38528994ios.10
 for <stable@dpdk.org>; Wed, 19 Jun 2019 07:30:42 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=uYqN5A2bts1FF9kSCr8fJ9t+flawZmUNlZ2z+88BUSw=;
 b=ntJjF3di3Xr+UacS0ojc8baSGZuh3/msIM/exIAGyY9m/lN8u36Kjud/YlZEaZN94Q
 K4UNQGNUTYgvRSNkadkXboqo7ZotkuY1XfiCixzdBPh0wMx91z2QNjUjF2Mt/b/qhizp
 Lk9Kwu2d2xTSwUKijOTU29+F8Id/O1jP6iLQPyT27KpkPbkabv3g8zEsRy6qlgSq6QiC
 C297MkpPaz64WRE5MmzTqtq4aOfV7SxMjVNUHGBGoehCRTnj5TIo/O5P8xeN+MKbLjgk
 oNvP1R6fqU+QsGRQpBu51CMvL42Q3HONVnisHYbKB8RV4hjc4hzSOCUodabeiJ1Y8aQy
 5DZw==
X-Gm-Message-State: APjAAAXLBFVno2+ljcth8WlyGTOQvM2sPpNuoPAuuJcv3kdLN9vLGmhL
 pOWl3qlnhLQ6qEltVgvf3ETWSLzx59Ih0os5MppSLA==
X-Google-Smtp-Source: APXvYqyTU15wTUsuso0FUAs246z0kn2U8a0cQ2M1+GnFh1S5AJ6+sOHEU96IU36m47tL8G56xRvn+t2J8J/uEUnh0oA=
X-Received: by 2002:a02:c6b8:: with SMTP id o24mr51748613jan.80.1560954641449; 
 Wed, 19 Jun 2019 07:30:41 -0700 (PDT)
MIME-Version: 1.0
References: <20190618105950.9599-1-andrius.sirvys@intel.com>
 <CAJFAV8y4By=-uK_TxtjZLySd2jHz8hLVeG+Xvvivb5-Uqbp5kg@mail.gmail.com>
 <49C20589590A5F43815A562C49658C1E70D38D90@IRSMSX101.ger.corp.intel.com>
 <CAJFAV8yMQ_5F+w+MAUBKhM=cTkC+CxuZoccRTSZrp-ySWZ+bsg@mail.gmail.com>
In-Reply-To: <CAJFAV8yMQ_5F+w+MAUBKhM=cTkC+CxuZoccRTSZrp-ySWZ+bsg@mail.gmail.com>
From: David Marchand <david.marchand@redhat.com>
Date: Wed, 19 Jun 2019 16:30:30 +0200
Message-ID: <CAJFAV8wYJ5HeRzWRWdSiYmdtSXxD3YBsvc-_O+fX=KLNCu8QvA@mail.gmail.com>
To: "Sirvys, Andrius" <andrius.sirvys@intel.com>
Cc: dpdk stable <stable@dpdk.org>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, 
 "Wu, Jingjing" <jingjing.wu@intel.com>, "Iremonger,
 Bernard" <bernard.iremonger@intel.com>, 
 "Yigit, Ferruh" <ferruh.yigit@intel.com>, dev <dev@dpdk.org>
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-stable] [PATCH] test-pmd: removed references to crc_strip
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>

On Wed, Jun 19, 2019 at 4:23 PM David Marchand <david.marchand@redhat.com>
wrote:

>
> On Wed, Jun 19, 2019 at 4:13 PM Sirvys, Andrius <andrius.sirvys@intel.com>
> wrote:
>
>> That sounds like a good idea. Do you have any examples by chance of
>> something like this or any advice how to implement.
>>
>> The string needs to be generated beforehand so where would we be able to
>> put the code in for that.
>>
>
> For the usage strings, you only need to call a wrapper that dynamically
> outputs the list separated by |.
> For the
> cmd_config_per_port_rx_offload/cmd_config_per_port_rx_offload_result_offload
> tokens init, you have an example with cmd_set_fwd_retry_mode_init() which
> updates cmd_set_fwd_retry_mode/cmd_setfwd_retry_mode tokens.
>

See: https://git.dpdk.org/dpdk/commit/?id=769ce6b17835


-- 
David Marchand