From: David Marchand <david.marchand@redhat.com>
To: Jens Freimann <jfreimann@redhat.com>
Cc: dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
Tiwei Bie <tiwei.bie@intel.com>,
Zhihong Wang <zhihong.wang@intel.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/virtio: remove useless check on mempool
Date: Fri, 17 May 2019 10:16:27 +0200 [thread overview]
Message-ID: <CAJFAV8wYzaCx6M9ZjEcpLthmVqcHjjEpdwESfNh_Q+RNHQx3iA@mail.gmail.com> (raw)
In-Reply-To: <20190509132901.nvcvz374pi53mnip@jenstp.localdomain>
On Thu, May 9, 2019 at 3:29 PM Jens Freimann <jfreimann@redhat.com> wrote:
> On Thu, May 09, 2019 at 10:03:48AM +0200, David Marchand wrote:
> >This .rx_queue_setup devop is called after ethdev already dereferenced
> >the mempool pointer.
> >No need to check and we can remove this rte_exit.
> >
> >Fixes: 48cec290a3d2 ("net/virtio: move queue configure code to proper
> place")
> >Cc: stable@dpdk.org
> >
> >Signed-off-by: David Marchand <david.marchand@redhat.com>
>
> Agree, the pointer is accessed before in the caller. That said, afaics the
> pointer is never checked in rte_eth_rx_queue_setup() before it's
> dereferenced...
>
Yep, sent a patch.
http://patchwork.dpdk.org/patch/53503/
Thanks for the review Jens.
--
David Marchand
next prev parent reply other threads:[~2019-05-17 8:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-09 8:03 [dpdk-stable] " David Marchand
2019-05-09 13:29 ` [dpdk-stable] [dpdk-dev] " Jens Freimann
2019-05-17 8:16 ` David Marchand [this message]
2019-05-17 15:08 ` [dpdk-stable] " Maxime Coquelin
2019-06-05 12:29 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8wYzaCx6M9ZjEcpLthmVqcHjjEpdwESfNh_Q+RNHQx3iA@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jfreimann@redhat.com \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).