From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2CE2B45610 for ; Fri, 12 Jul 2024 13:05:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 24101402E5; Fri, 12 Jul 2024 13:05:56 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 0306C40261 for ; Fri, 12 Jul 2024 13:05:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720782353; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Cpwru2yak3fh+noUeX7TR7ad1ICo095zVkqjTzKGuXE=; b=eXWkTa16RgWKDsAOFIzlUiVGaO+2LWxFZuFS3mSifC67gJFyVrg+8ZtG9G7w6RKK0xZDhH OHJEcJv4ibS7bMjlSNCTRMTbDxRprixTD0klJMGzse9cFZyRUiZRbZtHP+ypQjApYzpqkY 7pOiBP/HH9uNmAJt7YAJS8YrNlwakvA= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-446-TJx3hTBbPtW9AueuN5K43Q-1; Fri, 12 Jul 2024 07:05:52 -0400 X-MC-Unique: TJx3hTBbPtW9AueuN5K43Q-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2ee91e5be95so21931301fa.2 for ; Fri, 12 Jul 2024 04:05:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720782351; x=1721387151; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Cpwru2yak3fh+noUeX7TR7ad1ICo095zVkqjTzKGuXE=; b=mw2yQm1zTkTi/f+/T/Hipq/GRLs5bIn35CDgSnhwo73388yWvH7DZ+BEvSY1vDBx90 xTSuegcaG3crheh9jC1gmMpj34h30oMO2xCnxeO/9IRuxKEa77VSEqiWR947O+iHG2qe 8HUYJ+I2crRMJEiw1LBoZljDWH+qSJBj1KanCKfcqpTpeWyJEXmNonyD4PDrZpdubkYb I06mR46uW3Gpc4bcgG/WKWfZO8g4JSUGA/5QsUMrBOjXSoGay7Lk1pN/zBMhz9NDrd/e pzSc2TOA/PTfx+SZPjNmUBSHWLSCYN84ozTNLRx1I9qmkLDtj4vqTeGgYyWyPqFVZXDE hVBA== X-Forwarded-Encrypted: i=1; AJvYcCU1mqK0VfXpxXP2Ujmfe73Rms8DDdIApl0uReeEntHBN3EFA2pkSbEO17xN7treD7VxFBgMbWx1LuRaBzbnZ9Y= X-Gm-Message-State: AOJu0YwWBrherNh88d51h9P8bGs5IFGdnWhzQw3GtGI1g/cumxeGbRHt psIebhKB4jtDTQvW2aiL9sCklH6zrjevW4ulFWSA90kiDMp8/+OVPfzi7E6xJJue2mHnTF1A00T AU1vWYDJPgIUZsJ2fagEg7U03BI/6CpckyD2yIGreAy+Gy7Rim3l9OuoYAnOeUWs2bIvZsGbbN1 bnG5Zt5HF0tgYCGT2RLmg= X-Received: by 2002:a2e:9845:0:b0:2ee:8aed:ddbe with SMTP id 38308e7fff4ca-2eeb30babc9mr92720071fa.6.1720782350850; Fri, 12 Jul 2024 04:05:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHro4fCHOerMG7bTA6DUL29sq2vRvGmwgTIVEp/FVkUKJZc17tYw+Oj6rlDCgnZXaox6565wshKDS6YRODbdho= X-Received: by 2002:a2e:9845:0:b0:2ee:8aed:ddbe with SMTP id 38308e7fff4ca-2eeb30babc9mr92719861fa.6.1720782350478; Fri, 12 Jul 2024 04:05:50 -0700 (PDT) MIME-Version: 1.0 References: <20240712104528.308638-1-xuemingl@nvidia.com> <20240712104528.308638-4-xuemingl@nvidia.com> In-Reply-To: <20240712104528.308638-4-xuemingl@nvidia.com> From: David Marchand Date: Fri, 12 Jul 2024 13:05:38 +0200 Message-ID: Subject: Re: patch 'eal/unix: support ZSTD compression for firmware' has been queued to stable release 23.11.2 To: Xueming Li Cc: Bruce Richardson , dpdk stable X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hello Xueming, On Fri, Jul 12, 2024 at 12:46=E2=80=AFPM Xueming Li w= rote: > diff --git a/lib/eal/unix/eal_firmware.c b/lib/eal/unix/eal_firmware.c > index 1a7cf8e7b7..33e989188e 100644 > --- a/lib/eal/unix/eal_firmware.c > +++ b/lib/eal/unix/eal_firmware.c > @@ -15,6 +15,8 @@ > > #include "eal_firmware.h" > > +static const char * const compression_suffixes[] =3D { "xz", "zst" }; > + > #ifdef RTE_HAS_LIBARCHIVE > > struct firmware_read_ctx { > @@ -36,7 +38,11 @@ firmware_open(struct firmware_read_ctx *ctx, const cha= r *name, size_t blocksize) > > err =3D archive_read_support_filter_xz(ctx->a); > if (err !=3D ARCHIVE_OK && err !=3D ARCHIVE_WARN) > - goto error; > + RTE_LOG(DEBUG, EAL, "could not initialise libarchive for = xz compression"); > + > + err =3D archive_read_support_filter_zstd(ctx->a); > + if (err !=3D ARCHIVE_OK && err !=3D ARCHIVE_WARN) > + RTE_LOG(DEBUG, EAL, "could not initialise libarchive for = zstd compression"); EAL_LOG (in the main branch) appends a \n. However RTE_LOG() won't do it for you. So a \n is missing in both calls above. --=20 David Marchand