From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0241146B9B for ; Thu, 17 Jul 2025 10:19:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F06BB402DE; Thu, 17 Jul 2025 10:19:50 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 187D6402D7 for ; Thu, 17 Jul 2025 10:19:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752740388; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5BJXjiOFJocpNVsi4NcabPetvR7k8KLxrPw/JEkgZPk=; b=i4xUbc+hCS+RIwCcvuT65mlHEnK29YdCnDn40t2YFNeGrpbC4xLR4a+xfKbKtC3fXX1nnZ VP1dnfE4i200ovKqsmy1pgayWVlsfYJsXNnWvQ64glPOHWbB4vEDCeVQlCakrJwk/RPu59 qeCyFcRUg+cjOZxhR7r8gv/HiPe0Z5I= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-567-JLx1fRWtNWGurjm6WRAtMw-1; Thu, 17 Jul 2025 04:19:41 -0400 X-MC-Unique: JLx1fRWtNWGurjm6WRAtMw-1 X-Mimecast-MFC-AGG-ID: JLx1fRWtNWGurjm6WRAtMw_1752740380 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-55a04ed9c19so445370e87.1 for ; Thu, 17 Jul 2025 01:19:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752740380; x=1753345180; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5BJXjiOFJocpNVsi4NcabPetvR7k8KLxrPw/JEkgZPk=; b=Pn0ioV0ud6vZVV1hA5aBemr1gI4hCWgfydYfXicgyeLeP7G6h6PpbIZN05fTs/YfDk t659aYxCvbj0GMKvM47YfigV5BDENNkWeoHqD0EzwyoZGuKps8l+xPgOQ0qDFP+i0JV2 tJ65n01LI8OemYxZG+ItBOVJ1S/ygPkhUB0zc2jQ1tzIHtcT8YCsU/WKxN7AmlhAioN8 115Tiyg1RKo9n0+n/7dNxBqvAqPibDOkJ7oSbZS7AY2DVvf3JEa2E1SwvOij/zjqFPG2 0OVyIKzQmXVYPShMdZJMMXnMBR8ZqHXDiZS4tF4X3XAEA0BHDjeLmhfT1shuFK7EbaN1 bkmQ== X-Forwarded-Encrypted: i=1; AJvYcCXu/k5JgaYD8Zy7mRTqqz18xLgQWzDbrDa+RZDvSZwz2zT06rGJcn0doP4sMuIuGkqbyms71NU=@dpdk.org X-Gm-Message-State: AOJu0Yxq2Dq9hlvA6qkSKVhxodO4kgJVnVnNfdKv6GX+IQ+ZnKRWePS4 RFvPaFxQB7A6XSuxMktt+YscbEZp9U3bvjL8OpJRUPn/rVH4McmXzMvUKEwViDbWWbucSgwPgIe dVVqDv1JTSU0q5KRSZbUVAkrpJKh2S6jyLg0bxQTwXi31j+m98ulNAIh+WiDrSTppPlSS0ncL1S BGt+R/CTbG9Wg+l/PaEdNBOCk= X-Gm-Gg: ASbGncsgBUH0SS6d8b0foe5eavac0YxMcV4KYH7cuvK4vEoyk3FG6MtW8y1iSdRA+dN EtCwraJKJMMJBO4H0BKdlznQFbmYUDOfVZkfSg3POydgXteHo+FUMplojqlqWh4QfYts24/NwZ+ y5Az3NE9jSUO4V9Asp6uZo6xo= X-Received: by 2002:a05:6512:3985:b0:553:a60d:6898 with SMTP id 2adb3069b0e04-55a23f8020bmr1617305e87.45.1752740377559; Thu, 17 Jul 2025 01:19:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHYq1Sj5UC5JU/NHMzZY7w0Yn234tNZ1GWdPO5MyxgZoBnNWHGosW/TDTDm5SWn/TGj6FzM1RMz0j5XJLxTkUI= X-Received: by 2002:a05:6512:3985:b0:553:a60d:6898 with SMTP id 2adb3069b0e04-55a23f8020bmr1617298e87.45.1752740377047; Thu, 17 Jul 2025 01:19:37 -0700 (PDT) MIME-Version: 1.0 References: <20250716173922.688476-1-bruce.richardson@intel.com> In-Reply-To: <20250716173922.688476-1-bruce.richardson@intel.com> From: David Marchand Date: Thu, 17 Jul 2025 10:19:24 +0200 X-Gm-Features: Ac12FXziyULeTKdvH6qwRP1OqfxGQlKMEwqycPkwmBlesfuiGE1Qn_hY-y-nJ0M Message-ID: Subject: Re: [PATCH] net/ice: fix assumption about tag placement order To: Bruce Richardson Cc: dev@dpdk.org, stable@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: M-hVMixJc2wfiAo_lP-nASHKPHMkxoMjr92Avlq93vo_1752740380 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Wed, Jul 16, 2025 at 7:39=E2=80=AFPM Bruce Richardson wrote: > > The specific placement of outer/inner VLAN tags in E810 and related NICs > is configurable. Therefore, remove the assumption that if the L2Tag2 > field is filled in, that the L2Tag1 must also be. Instead, check the > existing mbuf VLAN flags, and move tags and set flags as appropriate. > This fixes an issue where, with QinQ packets with different Tag ethtypes > (0x88a8 vs 0x8100), we get an mbuf reporting two valid tags, but only > having had one tag stripped. > > Fixes: e0dcf94a0d7f ("net/ice: support VLAN ops") > Cc: stable@dpdk.org > > Signed-off-by: Bruce Richardson The ice code seems copy/pasted from i40e. So I guess i40e is affected as well. --=20 David Marchand