From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E163746E24 for ; Sat, 8 Nov 2025 16:35:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DC18D40261; Sat, 8 Nov 2025 16:35:24 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 9347240261 for ; Sat, 8 Nov 2025 16:35:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762616123; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KLm9yj/3avHTdgbJkewvPjtCUs+5Lb1DvGYPODmPmqs=; b=gCI4wxhTaRZfBa5BynSnFQhQl8FPChcEIoC6IyNFafdoC8xiTb8AP5o8IEyrbCJWMrsp8e t8jUUqL0GTrz6Pr/bWFZqPb+Py375ZfCpEHXnTia+dMFA3eZGt/UdGdwOeGz0Tn4ZDe9SJ dYW0SVvVm4JCPLVPN3q89KwH1UC4grc= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-500-6e6zPgiQO-C-e2pusRxDyQ-1; Sat, 08 Nov 2025 10:35:21 -0500 X-MC-Unique: 6e6zPgiQO-C-e2pusRxDyQ-1 X-Mimecast-MFC-AGG-ID: 6e6zPgiQO-C-e2pusRxDyQ_1762616120 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-594285c6850so758843e87.2 for ; Sat, 08 Nov 2025 07:35:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762616120; x=1763220920; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KLm9yj/3avHTdgbJkewvPjtCUs+5Lb1DvGYPODmPmqs=; b=j0DOujDqB14e6juIYAE9YT3Il6flnvYbUtztkO46dMgTrO+1wvPJn8ROK6EO1jriHj kfAlHX0OmT2Djrwl5hiasz8P+H6A5NgGD32pmQbAB4VsfldQkp15QR3InwxO09eXSI2z ehXTXhu/HTq0fjNOsmmRJT9BxIT8dthE5DlYtrCwGxrM98QKYPRRfvz9Zg2BZGzTa046 oEcm6DKeA0nwRoJy7oowh5CLvMSvohHBl/ZHZgSVURVDmngZqaphOOlRDVArxSd6VAQF 6TCbXfTjSlLzpdFtm1fSatu9b0ozQTfPMtLx9cyuA8aCi5WAZk6lEbk5JO8VMRS87bHY 59iw== X-Forwarded-Encrypted: i=1; AJvYcCW5VvSxkb4VZ+96XUKkQBE6+SM23XcOIPjDjdxXz9mbgOCtDnslTv3RwpCV8VvQzMBeEQLVCxM=@dpdk.org X-Gm-Message-State: AOJu0YzzhpMeDWbI78ld3wA38fgIvEssD7zlRxZ9DqYNXRGtUPUlsKSW iLL77NMOmkP25ilo60ZMCh/QktT2B/o8wEEeLLEXs1d0ID4LFv9NC2oF0E/A/Qf+Z9bHZ028g6w xaWUcTS8nCnAvf/LW5VjUnttw5fnKGSQpf5gt6Mu2ceVD1OC5s+9klzaItIjiSUGAeG+rLNFuI7 Gh5JS+yUV7dqSrNfMLY0B2NbU= X-Gm-Gg: ASbGncvNVbiCaEi+AgI/0H3LTJUXxpcZymUy6oaaP2PR17UmT4VwzHFI418Ulha9/Nc Vqyo5nzWw8h6R0ayMKxZ1OYKRcwEY3VDijs5R50GuNBm7HPX9cOPbsZdqRdGSNru93R9/WwO6j5 G5iNlvchknvIvPEIq8+tdBRkUhqNOCHc5gIE81zdPoEDlYYkLZ7O49Rtu8yw== X-Received: by 2002:a05:6512:128a:b0:594:49ed:3cf1 with SMTP id 2adb3069b0e04-5945f15da00mr732007e87.10.1762616120102; Sat, 08 Nov 2025 07:35:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IFklu01q8slJbjdDpzA6IvVGb0nzB2CixBH7FVROnenDG6oUsLyWW1KslT4Y3aFGsd23lIKIyHnMpzB0NaYvyM= X-Received: by 2002:a05:6512:128a:b0:594:49ed:3cf1 with SMTP id 2adb3069b0e04-5945f15da00mr731998e87.10.1762616119692; Sat, 08 Nov 2025 07:35:19 -0800 (PST) MIME-Version: 1.0 References: <20251106163807.201451-1-hemant.agrawal@nxp.com> In-Reply-To: From: David Marchand Date: Sat, 8 Nov 2025 16:35:08 +0100 X-Gm-Features: AWmQ_bmGdIPY3Igxe0wIqBKGGGwQY4X884_Ro31b0YDryF9FMuwJDccShZnJSdM Message-ID: Subject: Re: [PATCH 1/3] net/dpaa2: fix duplicate calling of dpaa2 dev close To: Hemant Agrawal Cc: dev@dpdk.org, stephen@networkplumber.org, sachin.saxena@nxp.com, stable@dpdk.org, maxime@leroys.fr X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: AERsHdcpT6kmTkDOTSvvCv3W44rPJ4DTiwfk9DKK7aQ_1762616120 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Fri, 7 Nov 2025 at 09:32, David Marchand wrote: > > diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c > > index 7da32ce856..f3db7982a4 100644 > > --- a/drivers/net/dpaa2/dpaa2_ethdev.c > > +++ b/drivers/net/dpaa2/dpaa2_ethdev.c > > @@ -3347,14 +3347,17 @@ static int > > rte_dpaa2_remove(struct rte_dpaa2_device *dpaa2_dev) > > { > > struct rte_eth_dev *eth_dev; > > - int ret; > > + int ret = 0; > > > > eth_dev = dpaa2_dev->eth_dev; > > Having a back reference of the "class" object in a "device" object > seems wrong to me (and there is a dev_priv->eth_dev too...). > It breaks the separation that was introduced with rte_device years ago. I went and had a try: https://patchwork.dpdk.org/project/dpdk/list/?series=36627 No promise it works, but it is cleaner this way. -- David Marchand