From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A585BA04C0 for ; Thu, 17 Sep 2020 17:33:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7E5CC1D67A; Thu, 17 Sep 2020 17:33:40 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 33E5F1D449 for ; Thu, 17 Sep 2020 17:33:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600356818; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=36jMEpVNc5/Y8T3bn3EJBmR2p0wYtkKoOvxVXZHlNJY=; b=OVJGqdEOb5P77lpkowKAfsXBGUpbaJ4LGZeYm0fWrWkuuNZxuOfhn6JuVFPj8lZuJNRyh4 zQkdLMfFdo8Om8QbF8hH+vmyrG8xEDsvK9884OOpAGSyz9zOTEcFDYOgczi9Gf5/04xPBE oPL0zowKRCCf3cN56F+rE1zOEq8kBPY= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-374-EbpMOWXAOAKWV_1WrcWnkA-1; Thu, 17 Sep 2020 11:33:35 -0400 X-MC-Unique: EbpMOWXAOAKWV_1WrcWnkA-1 Received: by mail-ua1-f72.google.com with SMTP id 48so304899uai.2 for ; Thu, 17 Sep 2020 08:33:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=36jMEpVNc5/Y8T3bn3EJBmR2p0wYtkKoOvxVXZHlNJY=; b=jeNcJYpXWQADoe9TfWUbyvOvpA+SZViN0CJij2mcJlL8y95txi72pr1s68iax5U1RT /nJL/7Vw/r7SPEZLXefvA9/bMEE3XN0tYuzcFHUSKJC4eatx7Yp4IhYrlJcU/6TaVDxN 8Jr1VDSx3LiNHvyXUsA8FaTJ8jJznshqrFWtBnAjp8lgAoYxOuCzj44s4k/ED7xZUlsQ hG1Rv4hPMGYGrj3c1Rs0QakgtNQrfLH70z5Tcf+ojovNwZyrBN703eh3vbNZUc+Osig/ lTFF5g7P8DFFf3KXE2JUMzoozn6r7slpdY/DkEaJHWhFbNQcKAOWAU9TvGh/ajZJj0Ak 5yyA== X-Gm-Message-State: AOAM530X4PC8H6J5wCgpSOaleIXQ94h14A5SSDw/M2eHueMqVkDlz5h+ bapiTlyKZ1zKsyNRCIjP/XcU2P7znyunek66ibDDKABmelmHkoqGyvsSdGePakc/2x2gWNbV2A8 23JSs85/sM4eKrJshcG5gEoY= X-Received: by 2002:a67:e2c2:: with SMTP id i2mr18263511vsm.27.1600356815035; Thu, 17 Sep 2020 08:33:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyr0pZkY+dTffGir+cdh37lrNhMvMiHfK3YBrRLqrU1sEgoBY8eUPuOFHIafhsbSdU9XrV5IxCMUQyDI27gssE= X-Received: by 2002:a67:e2c2:: with SMTP id i2mr18263477vsm.27.1600356814688; Thu, 17 Sep 2020 08:33:34 -0700 (PDT) MIME-Version: 1.0 References: <20200917150917.22945-1-david.marchand@redhat.com> <20200917152920.GH1568@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20200917152920.GH1568@bricha3-MOBL.ger.corp.intel.com> From: David Marchand Date: Thu, 17 Sep 2020 17:33:23 +0200 Message-ID: To: Bruce Richardson Cc: dev , dpdk stable , Fan Zhang , Luca Boccassi Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] crypto/scheduler: fix header install with meson X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Thu, Sep 17, 2020 at 5:29 PM Bruce Richardson wrote: > > On Thu, Sep 17, 2020 at 05:09:17PM +0200, David Marchand wrote: > > The headers variable is only used in lib/meson.build context. > > For drivers, an explicit install_headers() is necessary. > > > > Reproduced while compiling the l2fwd-crypto example out of meson > > (which can be done by adding it in devtools/test-meson-builds.sh > > examples build test). > > > > Fixes: cd2b6458a1cb ("crypto/scheduler: add in meson build") > > Cc: stable@dpdk.org > > > > Signed-off-by: David Marchand > > --- > > drivers/crypto/scheduler/meson.build | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > Originally I only put the "headers" variable in the "lib" folder > meson.build because it was not expected that many drivers should have > private headers. However, perhaps it's worthwhile adding it now: > a) because private headers, while not common, are not unusual > b) for consistency and ease of use. > > Thoughts? Yep, I can do it in a followup patch now, still looking at your RFC series though.. :-) -- David Marchand