From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 84A5A46F42 for ; Fri, 19 Sep 2025 12:16:09 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7D36D402CE; Fri, 19 Sep 2025 12:16:09 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 345394028F for ; Fri, 19 Sep 2025 12:16:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758276967; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2J1O4Vs/VZFqLqzMB8WsDpKQ8ZfkUzZ5lPfLr//yyik=; b=fzHRYpq5l0ZnUvmKXpjBMggXOlsw0CZkoe5MK+DupqJi3BFRw2hwfz1quD2jtN9FNSZN6g UIzjvMkpN3vy7I12ms10tnZU7EdKJoDaTQ0dMO0gI3t/I1nrFc3KJMgeBFsjrqpED38IWS n3eDjOH6PC5guRQKdBRQwYwBRGhj28E= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-492-OBsqBgLfNcKbXxKzdwNSgA-1; Fri, 19 Sep 2025 06:16:06 -0400 X-MC-Unique: OBsqBgLfNcKbXxKzdwNSgA-1 X-Mimecast-MFC-AGG-ID: OBsqBgLfNcKbXxKzdwNSgA_1758276965 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-55f6f4dea68so1160889e87.0 for ; Fri, 19 Sep 2025 03:16:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758276965; x=1758881765; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2J1O4Vs/VZFqLqzMB8WsDpKQ8ZfkUzZ5lPfLr//yyik=; b=d3m3/Cznx75QmH6N/miMwzB89i1dkWtnRNOxK4FCjVcj0ZOOnkmhSFMaTAbpD31zAr DXKTqA4i3vsnRTvOBNGYy4FBipVjLA7lxC/UoAitL8ZPHXon7tWTTUY4fsAKb/2gZHCk 2sM4n+CuxQ/XU/SlELDOkp4qlkoPJWH70HezS9Xr8KLCnSuuSPfsMmY4O1xCG89NkhaE A+wqW+ShJsQcT7KuM/zjERodFeruMIblbWHkAnJzC1tD+9L5M53QQAEXpdUPnJVDV1OC 2Ef7tLByepmQNVPj0TLIACV4u/ADYhtkNaTjC0Bni5hMBpgczbIK6inmNP/dphLzIEE3 qWHQ== X-Forwarded-Encrypted: i=1; AJvYcCVEvCzRSUniNQPI2vAflbMZMfkfINbteAqQ8fg+PhxTTPMQ3y0ss4OZKdunKV6oaUpW28nY0bE=@dpdk.org X-Gm-Message-State: AOJu0YydWTUlbN5ZTFAQz6SoVCpO7HvdmwEJUdBWx4xI9dzVcbHD43w8 L/7D3/N/rfJ9RvUVjRIiDZTfRWU784gMVEHpgQu9sjGIQ6khU5uiV8k7aWw1eSfQgb6Th4zTHK3 Fm1IR/VvZlfrrzHa/jLMIsYs8vDQtG8066vXBiMtiSg8xP+ePUCc6pl+G9R2oe99vvu7n/qstdc W+sMd7QcPQ2hlSbP3c+SW1FF0= X-Gm-Gg: ASbGncvmIeYK6zzNmK8umJrftb4crguyUyz+HqoY9FMBRiPMoLaDEKULce5ucGKQT5e wzHEfrkokBSAqxyOyxNv6LHWRj8M6IabXxyIpvEuf27Jnodwns3Yb3loNQCqEXLrsJJXd6wL909 GWA61K8chnb5l5m24U5psbU4w= X-Received: by 2002:ac2:4bcb:0:b0:55f:5685:b5e9 with SMTP id 2adb3069b0e04-579dfbd43damr1196100e87.8.1758276964923; Fri, 19 Sep 2025 03:16:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG+bdVCv1yqE0cVXVKsIxneUMeL4z+We3vqWNuYBHl/LbYNbZAEkgq8oVds8infj5rSglLHxY7zwHNDc2QbwfA= X-Received: by 2002:ac2:4bcb:0:b0:55f:5685:b5e9 with SMTP id 2adb3069b0e04-579dfbd43damr1196080e87.8.1758276964505; Fri, 19 Sep 2025 03:16:04 -0700 (PDT) MIME-Version: 1.0 References: <20240829085724.270041-1-konrad.sztyber@intel.com> <20241011111533.20746-1-konrad.sztyber@intel.com> In-Reply-To: <20241011111533.20746-1-konrad.sztyber@intel.com> From: David Marchand Date: Fri, 19 Sep 2025 12:15:53 +0200 X-Gm-Features: AS18NWCfLVdSog8oIcOuI1DAsiy07ZbZQOz4aGpt3hspzihV9jhBRj6JgwHPm9o Message-ID: Subject: Re: [PATCH v3] bus/pci: don't open uio device in secondary process To: Konrad Sztyber , Anatoly Burakov , Chenbo Xia , Nipun Gupta Cc: dev@dpdk.org, Chaoyong He , Stephen Hemminger , stable@dpdk.org, Long Wu , Zerun Fu , Thomas Monjalon X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 6umE4c_qj-motwPttgbUaLxg7N34k16pPBToH-lnoro_1758276965 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Fri, 11 Oct 2024 at 13:17, Konrad Sztyber wrote: > > The uio_pci_generic driver clears the bus master bit when the device > file is closed. So, when the secondary process terminates after probing > a device, that device becomes unusable in the primary process. > > To avoid that, the device file is now opened only in the primary process > and the secondary gets it over UNIX domain socket via SCM_RIGHTS. > > Fixes: 847d78fb9530 ("bus/pci: fix FD in secondary process") > Cc: stable@dpdk.org > > Signed-off-by: Konrad Sztyber Sorry I let this patch slip out of my radar. I see nothing wrong in this v3, but could you rebase and resend it so it goes through our CI? Anatoly, Chenbo, Nipun, please have a look. Thanks. -- David Marchand