From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 69219A056C for ; Wed, 4 Mar 2020 11:18:03 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 32E3E2BB8; Wed, 4 Mar 2020 11:18:03 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 71D722BB8 for ; Wed, 4 Mar 2020 11:18:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583317081; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MOK7mFYmKskghJo3nyuXHlDaYCRv5s/M+Icr7nJKcLI=; b=M5FX0hKmA6pW4wYH/rRjcuxlN99iaVT0GhhGAJeCqPc8TIB7+Y6OwoFZvoKN89T0oN56V8 dvlV09ExenWoXsQigQiu5Ziv3vZTn+E0dW7UtOltyGJPDmv9L6F77YGUOb7GCL91tKcyRr Y68aBNyHbRBX7c93bJ4d9X6e1Ya6jm4= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-208-zd-u5QduMGGTcwUZb1IjpA-1; Wed, 04 Mar 2020 05:18:00 -0500 X-MC-Unique: zd-u5QduMGGTcwUZb1IjpA-1 Received: by mail-vk1-f198.google.com with SMTP id n9so526274vkc.14 for ; Wed, 04 Mar 2020 02:18:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MNFsmG0RQbstkjVTPgy1YFuQaESnDeLCCXnLwu1H3iQ=; b=p/fPg0X0yGx3tupeGg5SrE4uEGKur+G5i8gJltdB3zabM8Xo/6fV9HLsuVGAS05KC0 Ri18qlIjO5as974qsgIx7Xvm5ZHNQ7Yfe/fcz/Y6U8N9MeaBOHrfsrvzjMzM+L6hSlAp kfsTS5m0s5kKwU/N/mC2TrQGVNiiDJGKNE4AXTxwGvEcW1uRtl9YddE66gX7C0tt+WR+ p8U4eD9wLXsDkx9J/8XilQICrwBiY2omZ/sfScOjJizKsDw2WfmLREQOTqqP1CtLXXYR OII2ZKna1ykoDNL531FxIwBbRrXBV4U9kJEOPtP2VbAJ1M/yJy33FqJiOunT5a6UXWaL ipxQ== X-Gm-Message-State: ANhLgQ29J9hH8kjrkja6TbTcRssqhhjwEaNcgmZZWd/Xn9LFAH/YmsF+ W5XMsEPBa9UuCr9VQWpooV4P6cvweLgMKyW8Olg7Vmo/5X3B2rOOIRbi6QM0qMnIaZNbjP5wLK3 xem8NPtcobIRTLCzaAM+oM+0= X-Received: by 2002:a67:905:: with SMTP id 5mr1312055vsj.105.1583317079836; Wed, 04 Mar 2020 02:17:59 -0800 (PST) X-Google-Smtp-Source: ADFU+vuQw8FAVR7JsPt2R429aH2QroohaMQBueOBP7sR0aM8iAaCuRY2cvC5iwjZzETu4sjNupRsKAUbeVFLFyghoMQ= X-Received: by 2002:a67:905:: with SMTP id 5mr1312047vsj.105.1583317079561; Wed, 04 Mar 2020 02:17:59 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: David Marchand Date: Wed, 4 Mar 2020 11:17:48 +0100 Message-ID: To: Timothy Redaelli Cc: dev , dpdk stable X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 0/3] examples: fix building with GCC 10 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Wed, Mar 4, 2020 at 10:37 AM David Marchand wrote: > > On Wed, Feb 5, 2020 at 2:47 PM Timothy Redaelli wr= ote: > > > > GCC 10 defaults to -fno-common, this means a linker error will now be > > reported if the same global variable is defined in more than one > > compilation unit. > > > > See https://gcc.gnu.org/gcc-10/porting_to.html for more informations. > > > > I didn't put -fcommon to CFLAGS since: > > Compiling with -fno-common is useful on targets for which it provides > > better performance, or if you wish to verify that the program will wo= rk > > on other systems that always treat uninitialized variable definitions > > this way. > > from gcc man page > > For the series, > Acked-by: David Marchand Series applied, thanks. --=20 David Marchand