From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 353F746873 for ; Wed, 4 Jun 2025 11:53:04 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 254FD427C6; Wed, 4 Jun 2025 11:53:04 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 44AE3427C0 for ; Wed, 4 Jun 2025 11:53:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749030781; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PhfTmBtDbqLCJcEiskcyo4+nL+rdVAI61TmV8fOIv4E=; b=daXqJWXHksurLItbA/pFxvi8c9RlYXgD5z9mp4jhuPR7nZ4jOdWm+Syf4gHhns7P16EqVa u0rAc10thbAFhj4Yr9XAHFdZMDGUATK8d2/XIKVZx8+CqCrXssW+YUvTvebWrkfeg+7917 BbpjI3KaeasDdAcumiZZUdD3+hCD4Ag= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-636-o26K3JBbMzm9Am5jnLOKSw-1; Wed, 04 Jun 2025 05:52:58 -0400 X-MC-Unique: o26K3JBbMzm9Am5jnLOKSw-1 X-Mimecast-MFC-AGG-ID: o26K3JBbMzm9Am5jnLOKSw_1749030777 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-55328b79ec3so404161e87.0 for ; Wed, 04 Jun 2025 02:52:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749030777; x=1749635577; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PhfTmBtDbqLCJcEiskcyo4+nL+rdVAI61TmV8fOIv4E=; b=pu4GCnQeOs1GsiNT1uHt6Xh1zzdMLZghjWLooRtFUqVyMaJFCYXPILCqKtElGFBxOB prk9U26+DUepRGsFl3HEoawmfIoBSD2GAtb4J+Hw7zDjU2LBlx+78BSO1CEu6TaXmhhq 2leKIuye4qDUR15LMVMV/eXMtU2dBaMIAQ2vl1KbXqHMeC1BhFcgsWKIL2yxDizddvoi BuQqJ01VOeaccwymHf4JQ5sjwdZRubsnhJJkOT28QfSgq9NLvDdfYboGn8s7KkCxT+bG PoGUDnKytu9Mc2+F6BEQs1skTWYAXvgLSSDMRPxQ+L8OKACYjVHrMEuOTFD8y4sGwiQG RxSg== X-Forwarded-Encrypted: i=1; AJvYcCWqm2D06iLBJplFes3CIl+aN6ne2oUe+5aUeB1DqD6EyM44yRpnKe8kc7mbi2fYzVHTlajBeRY=@dpdk.org X-Gm-Message-State: AOJu0YwcpNavqjbXoeaOU8q5gT6mDHEXFsI9KeShbi4/mZtu/iMMFyJd dl97iIceAFDrOwj8y/w2ieWz01CJc9PnnzQaYZYDLg0YFc/FWByw5uwOrTw1J+lvwDQwhGWO988 JDPJ0mXF9U8BB52thDVZt3EqIUNDCaf/wzVFw7MWdWVzTxVsPCsDULrh/c28zAWLGVeyEDA+6rA nyGwPU0102bPpr2qj0VPZhpKQ= X-Gm-Gg: ASbGncuDzKVTwbJwemaKD9nzlbVM8mrwSqvD4xL7cdGTsO6EHxFBSVEIKHwFYW8AlIk ehzQYayT65sek4u2W9r6yHvtJaYggXCRQGf5pTVbM+h7GjXddFCKuu2lFKyIPF3M99Hq6xUc= X-Received: by 2002:a05:6512:3f1e:b0:54d:6a90:5ba6 with SMTP id 2adb3069b0e04-55356e2b89bmr657874e87.0.1749030776922; Wed, 04 Jun 2025 02:52:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHdsCykrTn8fxp8KpTn/U0RByYl0IM8bfXFsS067LJJYRWfAovZtECGrBvs6cpttvszvvLelsGjK1vKtcJxo+U= X-Received: by 2002:a05:6512:3f1e:b0:54d:6a90:5ba6 with SMTP id 2adb3069b0e04-55356e2b89bmr657867e87.0.1749030776510; Wed, 04 Jun 2025 02:52:56 -0700 (PDT) MIME-Version: 1.0 References: <20250528093644.2456221-1-maxime.coquelin@redhat.com> <20250603175334.x4iknunhjbrsceat@ds-vm-debian.local> In-Reply-To: <20250603175334.x4iknunhjbrsceat@ds-vm-debian.local> From: David Marchand Date: Wed, 4 Jun 2025 11:52:44 +0200 X-Gm-Features: AX0GCFsLT-nHTnX5UzgniWJB99lLyGjO3gUEGy4NzYVJf1X1fVMPYEjwQHAm7T0 Message-ID: Subject: Re: [PATCH] net/mlx5: avoid setting kernel MTU if not needed To: Dariusz Sosnowski Cc: Maxime Coquelin , dev@dpdk.org, viacheslavo@nvidia.com, stable@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ZE2ofdEnPke8FSxaK5xCV55J7zK7bj2Kin6HrN62iPs_1749030777 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Tue, Jun 3, 2025 at 7:54=E2=80=AFPM Dariusz Sosnowski wrote: > > Atm, I don't see the need for keeping such a cached mtu value in priv. > > There is only one user of the value, and it is for configuration > > operation that can do a query to the kernel. > > I agree. It's not really needed, especially since the same value is also > stored in dev->data->mtu, so the kernel query can easily be replaced > with reading dev->data->mtu. Good point, which makes this priv->mtu even less useful. Thanks Dariusz. --=20 David Marchand