From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AE86DA0A0F for ; Wed, 30 Jun 2021 09:25:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A455341221; Wed, 30 Jun 2021 09:25:03 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 353DF41221 for ; Wed, 30 Jun 2021 09:25:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625037899; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Q/skYA/ul8ekI9Iupfb+vlGzLhgrmd1GKajXfiJEMCc=; b=jHvStWBj2Cck99gJPp07HMn7hX1rl/5nZ4CSyRRmNR+g0HZkcdVlZl0O+WGlTDVrWzH1jA 2k2a7y0thcgSFlHMsLTLtTBeLGNw9v54zZ/q7VYU0ZGsl3yzfNIX2fDPQcqSHRB7hxNXy9 vHQ84AWK77skVJack4vy6S3cqJs5pt4= Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-283-xn6j25gnPMK815v0P0sw8w-1; Wed, 30 Jun 2021 03:24:48 -0400 X-MC-Unique: xn6j25gnPMK815v0P0sw8w-1 Received: by mail-vs1-f72.google.com with SMTP id i4-20020a67f5840000b0290274a00a20d6so647841vso.19 for ; Wed, 30 Jun 2021 00:24:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Q/skYA/ul8ekI9Iupfb+vlGzLhgrmd1GKajXfiJEMCc=; b=WAg/xYCDE0ZSeKru/e/EiOOKklc2TdcC8zIgGztSSg/Hpgf9SeJJdrPjkHXBgLMtWT DiAlUIOJbRf4niKqU41a09SXeEo3rjHlQSQi9CA0lf8avJc94zYfT8/IBH4p5oYLVJut ZcRiFQycMiHuKTghD/7hT6gSQuDax5A4bN2OgUB9a1B44kNN/BBlzUlyydox98eahMuU rnwfnoFjCbdD/Ksm5jdc7s3jaZrtDEFDcrVIJKvIfFTTLlpEv0J1ZGuaEBK2tdMh19Nh JdXEjZzAHD96Tqs/DF9kxDQXcz8MK0HXaBN5fCNd/vP+TXZ7+NhYfHFmZZCI8DZ26rr+ cEIQ== X-Gm-Message-State: AOAM533Fr//wdOEokLBo2ybbZW9AqjHkDROhtwr5FPUZS/p3W1vlhImw EKktkeaSw5nnGhT8hc3VhVcBf66uyIaFu/bNBbXGpIaXEiLj9ffFZ03+v1r/y9dtr0CM218kunt Np4ebSk9HzAYe1sPQgQoXJD8= X-Received: by 2002:ab0:1484:: with SMTP id d4mr17492981uae.86.1625037888124; Wed, 30 Jun 2021 00:24:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzY1QuDYLdQI+zpGj0K3gbhJfpbjL1dK96XrQJHelw65QVgt3k2S05oS91hhOnroieTjeQARAaT4YEPk/xBYR0= X-Received: by 2002:ab0:1484:: with SMTP id d4mr17492971uae.86.1625037887964; Wed, 30 Jun 2021 00:24:47 -0700 (PDT) MIME-Version: 1.0 References: <20210629161133.79472-1-maxime.coquelin@redhat.com> <20210629161133.79472-5-maxime.coquelin@redhat.com> In-Reply-To: <20210629161133.79472-5-maxime.coquelin@redhat.com> From: David Marchand Date: Wed, 30 Jun 2021 09:24:36 +0200 Message-ID: To: Maxime Coquelin Cc: dev , "Xia, Chenbo" , dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [PATCH v7 4/7] vhost: fix NUMA reallocation with multiqueue X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Tue, Jun 29, 2021 at 6:11 PM Maxime Coquelin wrote: > > Since the Vhost-user device initialization has been reworked, > enabling the application to start using the device as soon as > the first queue pair is ready, NUMA reallocation no more > happened on queue pairs other than the first one since > numa_realloc() was returning early if the device was running. > > This patch fixes this issue by only preventing the device > metadata to be allocated if the device is running. For the Hum, I understand the meaning, but I think we could make it easier to read: This patch fixes this issue by reallocating the device metadata only if the device is not running. WDYT? > virtqueues, a vring state change notification is sent to > notify the application of its disablement. Since the callback > is supposed to be blocking, it is safe to reallocate it > afterwards. -- David Marchand