patches for DPDK stable branches
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Harman Kalra <hkalra@marvell.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
	Ravi Kerur <rkerur@gmail.com>,
	 Thomas Monjalon <thomas@monjalon.net>, dev <dev@dpdk.org>,
	dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] examples/l3fwd: fix max Tx queue count
Date: Tue, 12 Jan 2021 09:58:06 +0100
Message-ID: <CAJFAV8wr2CskNcECJ8ozRntm0HfC=nsrcvxQqmjzBkiA4neibw@mail.gmail.com> (raw)
In-Reply-To: <20201214190255.16429-1-hkalra@marvell.com>

On Mon, Dec 14, 2020 at 8:03 PM Harman Kalra <hkalra@marvell.com> wrote:
>
> In l3fwd no of transmit queues is calculated based on no of
> lcores with which it is launched. Hence maximum no of tx
> queues possible per port should depend on RTE_MAX_LCORE value.

For the title, we are not "fixing" the Tx queue count.
WDYT of:
examples/l3fwd: remove limitation on Tx queue count

>
> Fixes: 268888b5b020 ("examples/l3fwd: modularize")

This commit simply moves code around, so it is unlikely to be the origin.
Afaiu, this behavior has been present since the start.
I'd rather flag

Fixes: af75078fece3 ("first public release")

> Cc: stable@dpdk.org
>
> Signed-off-by: Harman Kalra <hkalra@marvell.com>
> ---
>  examples/l3fwd/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c
> index d62dec434..bb49e5faf 100644
> --- a/examples/l3fwd/main.c
> +++ b/examples/l3fwd/main.c
> @@ -48,7 +48,7 @@
>  #include "l3fwd.h"
>  #include "l3fwd_event.h"
>
> -#define MAX_TX_QUEUE_PER_PORT RTE_MAX_ETHPORTS
> +#define MAX_TX_QUEUE_PER_PORT RTE_MAX_LCORE
>  #define MAX_RX_QUEUE_PER_PORT 128
>
>  #define MAX_LCORE_PARAMS 1024

Later in the code, the associated check on nb_lcores > RTE_MAX_LCORE
does not make much sense.
But keeping this MAX_TX_QUEUE_PER_PORT macro is a way to document how
the txq are allocated.
So this change lgtm.

Reviewed-by: David Marchand <david.marchand@redhat.com>


--
David Marchand


  parent reply	other threads:[~2021-01-12  8:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-14 19:02 Harman Kalra
2021-01-11 17:18 ` Harman Kalra
2021-01-12  8:58 ` David Marchand [this message]
2021-01-12 18:18   ` [dpdk-stable] [EXT] " Harman Kalra
2021-01-12 18:24   ` [dpdk-stable] [PATCH v2] examples/l3fwd: remove limitation on " Harman Kalra
2021-01-19 12:16     ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8wr2CskNcECJ8ozRntm0HfC=nsrcvxQqmjzBkiA4neibw@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=hkalra@marvell.com \
    --cc=rkerur@gmail.com \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git