From: David Marchand <david.marchand@redhat.com>
To: Ciara Power <ciara.power@intel.com>
Cc: Olivier Matz <olivier.matz@6wind.com>,
Andrew Rybchenko <arybchenko@solarflare.com>, dev <dev@dpdk.org>,
Bruce Richardson <bruce.richardson@intel.com>,
dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] lib: fix unnecessary double negation
Date: Fri, 14 Feb 2020 17:39:32 +0100 [thread overview]
Message-ID: <CAJFAV8wtN2qwwdnarQVcdkPTiUvQ7fq5a0CWWDPNaLGHFJi0ng@mail.gmail.com> (raw)
In-Reply-To: <20200214161725.36104-1-ciara.power@intel.com>
On Fri, Feb 14, 2020 at 5:28 PM Ciara Power <ciara.power@intel.com> wrote:
>
> An equality expression already returns either 0 or 1.
> There is no need to use double negation for these cases.
>
> Fixes: ea672a8b1655 ("mbuf: remove the rte_pktmbuf structure")
> Fixes: a0fd91cefcc0 ("mempool: rename functions with confusing names")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ciara Power <ciara.power@intel.com>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied, thanks.
--
David Marchand
prev parent reply other threads:[~2020-02-14 16:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 9:15 [dpdk-stable] [PATCH] lib: fix unnecessary boolean casts Ciara Power
2019-12-02 11:58 ` Ferruh Yigit
2019-12-26 16:21 ` Olivier Matz
2020-02-14 16:17 ` [dpdk-stable] [PATCH v2] lib: fix unnecessary double negation Ciara Power
2020-02-14 16:39 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8wtN2qwwdnarQVcdkPTiUvQ7fq5a0CWWDPNaLGHFJi0ng@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=arybchenko@solarflare.com \
--cc=bruce.richardson@intel.com \
--cc=ciara.power@intel.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).