From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EF936A04E7 for ; Tue, 3 Nov 2020 22:36:45 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B6373AAB7; Tue, 3 Nov 2020 22:36:44 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 737DD69A4 for ; Tue, 3 Nov 2020 22:36:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604439399; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OTAfyNtTqfliPrCBTxiX6p6FsBNmQCWxZZh+0HAaXbc=; b=FM6/oRYCUm/s749DdTOLB0/xFNFxIISLzHqSOJkxsnXDo6wpOLfpF/5vthEHVwpTOH7a/Q 5O1uHGDXkc/7tyLV/odsdzyMDSfA1bb9K06wgD51OLRv5YtMx0UDZ37OWtD1bP4nsOn3pM KvVZFidpJkixD9hr4ug+2AueSSTa/uU= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-75-Ok6ax4xfNd2dzG9I6L8mog-1; Tue, 03 Nov 2020 16:36:38 -0500 X-MC-Unique: Ok6ax4xfNd2dzG9I6L8mog-1 Received: by mail-vs1-f71.google.com with SMTP id c14so6781826vso.9 for ; Tue, 03 Nov 2020 13:36:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OTAfyNtTqfliPrCBTxiX6p6FsBNmQCWxZZh+0HAaXbc=; b=QiFu6jVY/GiWs81z4tBj2gcvXrSOyQOkiofQcQbYhLZ7fKmkn1sa3oAVlgZ/nek/ep hpV9HOBxbc8C0fKCtlM+Xj+5FJIm4WX3EIxjgzciXXZCArtBjRYIquXK21RHqblx/Ams 2L3FbU5DskhJ0K53GVh4lHQbn/mHPvudkFCXi/p+tXCRMyguV1RuCQqXUpeDAYudgmpl gO2X1WW8DRMAOf16Sjk4CCRdkJsyJwyTxHF6DjMKbBCFvOZqRDT0xt1/t9jRB2XQ0+yJ K4hbRzNzTWPo9gRnvtZJEJ+cbdaMfxD/PXSvLmznM4ZG2l2tjH8yxkvqzH7cNdGtFBZI Od5w== X-Gm-Message-State: AOAM5316e1METf2wZUjnXpGyD3CB2oB1SC2R7YTSJu/g47gEsLwpjHtU jLt5nhz9XoQSpLGkEaZZEjxW/evAOZVliCZXtmGII4DCpm8PJ/R3a5ZP2PllE40gZ6G/yDfC/G3 7uoNbDjitJouygSYBLqFpGkQ= X-Received: by 2002:a67:2fca:: with SMTP id v193mr20765008vsv.18.1604439397929; Tue, 03 Nov 2020 13:36:37 -0800 (PST) X-Google-Smtp-Source: ABdhPJw3f9PtexzmqKRVnNA9P2z9JCJon91MwTdlGqORWN8FluhBtvCRWW3gcNoluPYcq83L1C/vg/OhvXAkYbS5Y4A= X-Received: by 2002:a67:2fca:: with SMTP id v193mr20764996vsv.18.1604439397764; Tue, 03 Nov 2020 13:36:37 -0800 (PST) MIME-Version: 1.0 References: <20200917150341.66298-1-ciara.power@intel.com> In-Reply-To: <20200917150341.66298-1-ciara.power@intel.com> From: David Marchand Date: Tue, 3 Nov 2020 22:36:26 +0100 Message-ID: To: Ciara Power Cc: dev , dpdk stable , Keith Wiles , Gaurav Singh , Honnappa Nagarahalli Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] metrics: fix resource leak on memory allocation fail X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Thu, Sep 17, 2020 at 5:06 PM Ciara Power wrote: > > If an error occurred when allocating memory for metrics or names, > the function returned without freeing allocated memory. This is now > fixed to avoid the resource leak in the case that either metrics or > names had been successfully allocated memory. > > Coverity issue: 362053 > Fixes: c5b7197f662e ("telemetry: move some functions to metrics library") > Cc: stable@dpdk.org > Gaurav reported the same issue and proposed a patch, but I went with yours as it describes the issue, is minimal and has the proper tags for backport. Reported-by: Gaurav Singh > Signed-off-by: Ciara Power Acked-by: John McNamara Applied, thanks. -- David Marchand