From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 87BB7A0579 for ; Thu, 8 Apr 2021 14:58:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A0D23140FA4; Thu, 8 Apr 2021 14:58:35 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 963C1140FA4 for ; Thu, 8 Apr 2021 14:58:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617886714; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uJicGLQF0/09OhtxiBjaPc/EkiLnoyE+AIUScMV3gdE=; b=gEitM+mPn5pX78pUnK4w6SybzDhKlajhAAmq9QONcx6aT++/drulJx+lgA11eyKMC/OphQ iXbN31RM59Lo6LCV2weNxioRPPmZEy/vt1V1R7N0SdSn2cl3ZjDgx/w52SNcKsNPIlMv1D SscDcbX08txSheEO9yAuxF1is7BdaB0= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-162-r7fsqKtQMrGijKvkRLpARg-1; Thu, 08 Apr 2021 08:58:30 -0400 X-MC-Unique: r7fsqKtQMrGijKvkRLpARg-1 Received: by mail-lj1-f199.google.com with SMTP id e29so682724ljp.10 for ; Thu, 08 Apr 2021 05:58:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uJicGLQF0/09OhtxiBjaPc/EkiLnoyE+AIUScMV3gdE=; b=ozQfVhYo7q07XjVb1kqWi2hqz4yBPmihnwtBGmHAWfaFV8H++a0fGEJgRl0UsliYr1 /8LCtwNRLucl8sjoKPUzKRtAJCZ3aZLIkcbJQD9i4P3ScN/vBND57yYwPoJJenOIwRYU dQfvm8LRh+bsO4t2WKiLjE+skvvTXxhHBsoYhD6JCx7saXhAABDgGR5+GhN2ClrSrqc6 MeNwSq4PlxXj/5irVBaGI02/+8VuTCI/Q0TtCb9gwlS3jJq9fuX06WiMXwBa4gtb1tFd AiV+xG7SAqIE8XpQHwQDpX5uwQSEBf3flJVGHZvva8Gj1gouR/Rb5bDe1bPN+YXzISra ZG4A== X-Gm-Message-State: AOAM532kzft/IjJ2baKTG3xAZjAAzlCflybYejxbLfW4g6uh3qkB38Mg nCFeBlshR/U5S2Lz0uOdMLPicpXblhpvnHNl0C2fR6BcxRxfwDmU9l70bLhCGTVhy4ijoNDf2pS svw9sJKTupFMX+/rORRCcCMM= X-Received: by 2002:a2e:a589:: with SMTP id m9mr5829153ljp.134.1617886708908; Thu, 08 Apr 2021 05:58:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzp1BJCRgBXgSGnAMxI6WnLwWLj0uIveHlhP9e1l4cZWEt6cfZ9ZO2vysEOgg2sE5zSGELyFdciGq/zQX6hL6U= X-Received: by 2002:a2e:a589:: with SMTP id m9mr5829144ljp.134.1617886708695; Thu, 08 Apr 2021 05:58:28 -0700 (PDT) MIME-Version: 1.0 References: <20210407090656.29176-1-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Thu, 8 Apr 2021 14:58:17 +0200 Message-ID: To: "Van Haaren, Harry" Cc: "dev@dpdk.org" , "stable@dpdk.org" , Ray Kinsella , Neil Horman , Pavan Nikhilesh Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [PATCH] service: clean references to removed symbol X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Thu, Apr 8, 2021 at 2:54 PM Van Haaren, Harry wrote: > > > -----Original Message----- > > From: David Marchand > > Sent: Wednesday, April 7, 2021 10:07 AM > > To: dev@dpdk.org > > Cc: stable@dpdk.org; Van Haaren, Harry ; Ray > > Kinsella ; Neil Horman ; Pavan > > Nikhilesh > > Subject: [PATCH] service: clean references to removed symbol > > > > rte_service_get_id() was removed in v17.11 but the API description > > still referenced it and a version node was still present in EAL map. > > > > Fixes: 8edc9aaaf217 ("service: use id in get by name function") > > Cc: stable@dpdk.org > > > > Signed-off-by: David Marchand > > For rte_service.h doc changes I'm all fine. > > For ABI consistency, this removes a function from the DPDK_21 version map that didn't exist in > the shared object itself. I'm not sure if that's an ABI break or not... I see ABI experts on CC, > and will let them comment on that topic. The symbol is not in the API anymore. Applications can't have a reference to this symbol without a definition. -- David Marchand