From: David Marchand <david.marchand@redhat.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: dev <dev@dpdk.org>, Wenzhuo Lu <wenzhuo.lu@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>,
"Iremonger, Bernard" <bernard.iremonger@intel.com>,
Rami Rosen <ramirose@gmail.com>,
Andrew Rybchenko <arybchenko@solarflare.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v4 1/4] app/testpmd: add missing newline when showing statistics
Date: Fri, 22 Mar 2019 18:23:02 +0100 [thread overview]
Message-ID: <CAJFAV8x1Yt=KxTNEyyX=SRWENmbvz_9DQrUoRgukpC_DZSFnXA@mail.gmail.com> (raw)
In-Reply-To: <3f88ea40-fbc3-1ee7-ecef-5dc93ad4ff83@redhat.com>
On Fri, Mar 22, 2019 at 6:17 PM Maxime Coquelin <maxime.coquelin@redhat.com>
wrote:
>
>
> On 3/22/19 2:37 PM, David Marchand wrote:
> > Having the standard stats and the rx burst stats on the same line gives a
> > really long line and is not consistent with the rest.
> >
> > Before:
> > RX-packets: 3542977 TX-packets: 3542971 TX-dropped: 6
> RX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts + 61% of
> others]
> > TX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts + 61% of others]
> >
> > After:
> > RX-packets: 4629969 TX-packets: 4629969 TX-dropped: 0
> > RX-bursts : 663328 [19% of 2 pkts + 17% of 3 pkts + 64% of others]
> > TX-bursts : 663328 [19% of 2 pkts + 17% of 3 pkts + 64% of others]
> >
> > Fixes: af75078fece3 ("first public release")
> > Cc:stable@dpdk.org
>
> While the patch is good, I wonder whether we should backport it.
> Indeed, it might break some scripts parsing testpmd output.
>
> Any thoughts?
>
It seems unlikely, this feature is disabled by default.
But yes, I would avoid backporting it.
--
David Marchand
next prev parent reply other threads:[~2019-03-22 17:23 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1550158972-21895-1-git-send-email-david.marchand@redhat.com>
[not found] ` <1552318522-18777-1-git-send-email-david.marchand@redhat.com>
2019-03-11 15:35 ` [dpdk-stable] [PATCH v2 1/4] app/testpmd: remove unused fwd_ctx field David Marchand
2019-03-19 18:29 ` Ferruh Yigit
[not found] ` <1553076154-3907-1-git-send-email-david.marchand@redhat.com>
2019-03-20 10:02 ` [dpdk-stable] [PATCH v3 1/4] app/testpmd: add missing newline when showing statistics David Marchand
2019-03-20 13:49 ` Andrew Rybchenko
2019-03-20 10:02 ` [dpdk-stable] [PATCH v3 2/4] app/testpmd: extend fwd statistics to 64bits David Marchand
2019-03-20 13:55 ` Andrew Rybchenko
2019-03-20 10:02 ` [dpdk-stable] [PATCH v3 3/4] app/testpmd: remove useless casts on statistics David Marchand
2019-03-20 13:58 ` Andrew Rybchenko
[not found] ` <1553261824-1881-1-git-send-email-david.marchand@redhat.com>
2019-03-22 13:37 ` [dpdk-stable] [PATCH v4 1/4] app/testpmd: add missing newline when showing statistics David Marchand
2019-03-22 17:03 ` [dpdk-stable] [dpdk-dev] " Maxime Coquelin
2019-03-22 17:17 ` Maxime Coquelin
2019-03-22 17:23 ` David Marchand [this message]
2019-03-22 17:31 ` Andrew Rybchenko
2019-03-22 17:35 ` [dpdk-stable] " Andrew Rybchenko
2019-03-22 17:43 ` David Marchand
2019-03-23 19:12 ` David Marchand
2019-03-25 6:34 ` [dpdk-stable] [dpdk-dev] " Andrew Rybchenko
2019-03-22 13:37 ` [dpdk-stable] [PATCH v4 2/4] app/testpmd: extend fwd statistics to 64bits David Marchand
2019-03-22 17:06 ` [dpdk-stable] [dpdk-dev] " Maxime Coquelin
2019-03-22 13:37 ` [dpdk-stable] [PATCH v4 3/4] app/testpmd: remove useless casts on statistics David Marchand
2019-03-22 17:11 ` [dpdk-stable] [dpdk-dev] " Maxime Coquelin
[not found] ` <1553503906-1508-1-git-send-email-david.marchand@redhat.com>
2019-03-25 8:51 ` [dpdk-stable] [PATCH v5 1/4] app/testpmd: add missing newline when showing statistics David Marchand
2019-03-25 8:55 ` Andrew Rybchenko
2019-03-25 8:51 ` [dpdk-stable] [PATCH v5 2/4] app/testpmd: extend fwd statistics to 64bits David Marchand
2019-03-25 8:51 ` [dpdk-stable] [PATCH v5 3/4] app/testpmd: remove useless casts on statistics David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8x1Yt=KxTNEyyX=SRWENmbvz_9DQrUoRgukpC_DZSFnXA@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=arybchenko@solarflare.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jingjing.wu@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=ramirose@gmail.com \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).