From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id B7B33A00E6 for ; Fri, 22 Mar 2019 18:23:16 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A0B141B722; Fri, 22 Mar 2019 18:23:15 +0100 (CET) Received: from mail-vs1-f52.google.com (mail-vs1-f52.google.com [209.85.217.52]) by dpdk.org (Postfix) with ESMTP id D62941B722 for ; Fri, 22 Mar 2019 18:23:13 +0100 (CET) Received: by mail-vs1-f52.google.com with SMTP id n4so1832106vsm.3 for ; Fri, 22 Mar 2019 10:23:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ckb65Ig5nIAF25L/s2oW/9ivLYfr8qy+nuGmoEBsgLg=; b=nkZ0twWmwKiZFR/tBPpdzdWuKqUfAlZBeOU8kh8JBfZqE4cq6BVsFjaZxOMc1jIRZ/ t9TJZXm4U5bwnj+8Ikf/7h5tS46+bI2KotJ/npMr6o/VWuvsR1YXDu6XdmivEM3Kinxj 39RD18WgIED8QLzkeCArRItknAmKXbkdYyUnMDjJt8qUPhAigdXtQb8PyZeroXq22pBv RMNqbmNsxv1zNTbVoiRQYxqcktR5ZQrCe9m8cN9Seyu1huT4JOYePal73siy27OJXg0x nxYhogEyRT04+257goSNIsHf2khfQdBvPwP9mKs+zgoUjSNznOxEiWGfiyCldHtks/rT LGJw== X-Gm-Message-State: APjAAAU3GjqvZ5WrB28nyjPU/SIpfpX7M3d/gNf0VC4XX0COMzcJPuiK ik0Ys82fafwrAp+0wOm6pFgawDz6DhTZBJ+6nmgWBg== X-Google-Smtp-Source: APXvYqzRn45CpvCF65zy98cAuXaqxtpWZllJJjWQ/jIGvHLgzMTKDFWnP9dI5Ve+c4aPYW0WxY0o3Ctd89iRUCvFR8g= X-Received: by 2002:a67:ea02:: with SMTP id g2mr6623974vso.141.1553275393242; Fri, 22 Mar 2019 10:23:13 -0700 (PDT) MIME-Version: 1.0 References: <1553076154-3907-1-git-send-email-david.marchand@redhat.com> <1553261824-1881-1-git-send-email-david.marchand@redhat.com> <1553261824-1881-2-git-send-email-david.marchand@redhat.com> <3f88ea40-fbc3-1ee7-ecef-5dc93ad4ff83@redhat.com> In-Reply-To: <3f88ea40-fbc3-1ee7-ecef-5dc93ad4ff83@redhat.com> From: David Marchand Date: Fri, 22 Mar 2019 18:23:02 +0100 Message-ID: To: Maxime Coquelin Cc: dev , Wenzhuo Lu , Jingjing Wu , "Iremonger, Bernard" , Rami Rosen , Andrew Rybchenko , "Yigit, Ferruh" , dpdk stable Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v4 1/4] app/testpmd: add missing newline when showing statistics X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Fri, Mar 22, 2019 at 6:17 PM Maxime Coquelin wrote: > > > On 3/22/19 2:37 PM, David Marchand wrote: > > Having the standard stats and the rx burst stats on the same line gives a > > really long line and is not consistent with the rest. > > > > Before: > > RX-packets: 3542977 TX-packets: 3542971 TX-dropped: 6 > RX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts + 61% of > others] > > TX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts + 61% of others] > > > > After: > > RX-packets: 4629969 TX-packets: 4629969 TX-dropped: 0 > > RX-bursts : 663328 [19% of 2 pkts + 17% of 3 pkts + 64% of others] > > TX-bursts : 663328 [19% of 2 pkts + 17% of 3 pkts + 64% of others] > > > > Fixes: af75078fece3 ("first public release") > > Cc:stable@dpdk.org > > While the patch is good, I wonder whether we should backport it. > Indeed, it might break some scripts parsing testpmd output. > > Any thoughts? > It seems unlikely, this feature is disabled by default. But yes, I would avoid backporting it. -- David Marchand