From: David Marchand <david.marchand@redhat.com>
To: Luca Boccassi <luca.boccassi@gmail.com>
Cc: dpdk stable <stable@dpdk.org>, Kevin Traynor <ktraynor@redhat.com>
Subject: Re: [dpdk-stable] [PATCH 18.11] Revert "common/octeontx: add missing public symbol"
Date: Mon, 2 Mar 2020 11:23:42 +0100 [thread overview]
Message-ID: <CAJFAV8x4cj+A_079Nr_U8=pL61wFaABTOr1=gH6Ni2rp-hNhDw@mail.gmail.com> (raw)
In-Reply-To: <20200228182016.30328-1-luca.boccassi@gmail.com>
On Fri, Feb 28, 2020 at 7:20 PM <luca.boccassi@gmail.com> wrote:
>
> From: Luca Boccassi <luca.boccassi@microsoft.com>
>
> This reverts commit bd979fff652326e042c21aaaf3df1f515ffdff6e.
>
> It changed the public symbol version from @Base to @DPDK_18.05,
> breaking ABI compatibility.
This symbol is exported through private macro logs used by octeontx drivers.
The drivers are all built at once and released together.
The symbol is not exported in a public header.
This is not an application ABI breakage.
>
> Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
> ---
> drivers/common/octeontx/rte_common_octeontx_version.map | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/common/octeontx/rte_common_octeontx_version.map b/drivers/common/octeontx/rte_common_octeontx_version.map
> index a9b3cff9bc..f04b3b7f8a 100644
> --- a/drivers/common/octeontx/rte_common_octeontx_version.map
> +++ b/drivers/common/octeontx/rte_common_octeontx_version.map
> @@ -1,7 +1,6 @@
> DPDK_18.05 {
> global:
>
> - octeontx_logtype_mbox;
> octeontx_mbox_set_ram_mbox_base;
> octeontx_mbox_set_reg;
> octeontx_mbox_send;
> --
> 2.20.1
>
--
David Marchand
next prev parent reply other threads:[~2020-03-02 10:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 18:20 luca.boccassi
2020-02-28 18:33 ` Kevin Traynor
2020-03-02 10:23 ` David Marchand [this message]
2020-03-02 10:45 ` Luca Boccassi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8x4cj+A_079Nr_U8=pL61wFaABTOr1=gH6Ni2rp-hNhDw@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=ktraynor@redhat.com \
--cc=luca.boccassi@gmail.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).