From: David Marchand <david.marchand@redhat.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH] app/dumpcap: remove unused struct array
Date: Wed, 6 Nov 2024 21:35:25 +0100 [thread overview]
Message-ID: <CAJFAV8x5SAxk0q5VNx21vHuGCK11EOkohj+Zj+JwFsft_iWEyQ@mail.gmail.com> (raw)
In-Reply-To: <20241106101836.0f66c457@hermes.local>
On Wed, Nov 6, 2024 at 7:18 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> On Tue, 5 Nov 2024 11:27:21 +0000
> Bruce Richardson <bruce.richardson@intel.com> wrote:
>
> > The callbacks(rx_cb) member of struct interface was unused inside
> > dumpcap, but was taking up a lot of memory space, since it was scaled
> > according to RTE_MAX_QUEUES_PER_PORT, which is 1k by default. Save
> > memory by removing the whole array.
> >
> > Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application")
> > Cc: stable@dpdk.org
> >
> > Suggested-by: Stephen Hemminger <stephen@networkplumber.org>
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Applied, thanks.
--
David Marchand
prev parent reply other threads:[~2024-11-06 20:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 11:27 Bruce Richardson
2024-11-06 18:18 ` Stephen Hemminger
2024-11-06 20:35 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8x5SAxk0q5VNx21vHuGCK11EOkohj+Zj+JwFsft_iWEyQ@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).