From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3F95445C9E for ; Wed, 6 Nov 2024 21:35:42 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 371D342EBA; Wed, 6 Nov 2024 21:35:42 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 4806442EB5 for ; Wed, 6 Nov 2024 21:35:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730925340; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gaFojhW6i1DtSfkzRm1cc6syv/vPfZhUSvZ/z7ccOqA=; b=JqucrCnfVPl4JFGemASFG81BzKngWgE649TBheDNX/M2CBsXNFZAcHmkQ2/9UnzKkcw8x1 YSGvaI70b0A25Vn2fqMKaTNeavD3aJpVx2KGnx648/ZNydZtDWYzbUElnARt9UByHNKvTG 6yYDqSmyiYmlSheVwKYa+lmj/9ikblw= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-470-no89OPHYNjWHgM93sKVk7A-1; Wed, 06 Nov 2024 15:35:38 -0500 X-MC-Unique: no89OPHYNjWHgM93sKVk7A-1 X-Mimecast-MFC-AGG-ID: no89OPHYNjWHgM93sKVk7A Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-53a246ecb7bso64691e87.2 for ; Wed, 06 Nov 2024 12:35:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730925337; x=1731530137; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gaFojhW6i1DtSfkzRm1cc6syv/vPfZhUSvZ/z7ccOqA=; b=Y+ImXFSElZPA4z0KnuZEwtZsY3FFRMZrn0dnqbLH3iR9twIRozDi2Zb+BX+LPWfU35 E79LGioJWjxGpYQfYATlZyO1xv4DUbR2zJUgwt2H9f7ONcAmZnaEDGQzy3wXhPjbM6K6 fsKIeRCGRIn2+8UneI0LjgMzudRTvQ4JUCHGmGxuKlx5xwCsr05oFc6mQ4Qqj8VfebA+ 2+1MsuwmEGTOfZ3aW/qhtnuRqXEhAVtcddMaFuynhkpySMx9rG67Fi8okWsTtbkGy2i1 iHOIIFiZpWP+lwcUr/lKWBNMh0WHEKMoAtz60FHkssyh+j8Q1epDCViXmdoyEz6AMEDI nWAQ== X-Forwarded-Encrypted: i=1; AJvYcCW0+qcSIhtcA8JMeuYW+LJPK7vUzPaE+Jq/kE0pHDUYXsljhK+yQNDQtT527oa1t+hWkyu38NA=@dpdk.org X-Gm-Message-State: AOJu0YyTpetAsI1nYi63ieqUMn4uZZxlTgymr2B8oeBy+HtnKaWpkUOj bPnu8rNVwsqOZveuR4mBkP0U6nftNjFpaK7dA4IfYO/6xwZamArTeP/2dU8cE7rvY0YZhPiwhbd ZMn4wWZptJ6vZgf4HaQBcWvwEtNc6H4lardERqlBdoRXwq08d5FgiSDSOSYPpE1icE5QWqPQaO7 mA8MAKyjEDyVo2HsjjvOw= X-Received: by 2002:a05:6512:ac3:b0:536:56d8:24b4 with SMTP id 2adb3069b0e04-53c79e15746mr11869864e87.5.1730925336948; Wed, 06 Nov 2024 12:35:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IEly95rGszFwIeHs31lnGjcQ9dnZXUMz6y61lIYt1uIgYYVkABHWslSKKD9gHWwyWJOEZfSjEQtF58OipKo9Ac= X-Received: by 2002:a05:6512:ac3:b0:536:56d8:24b4 with SMTP id 2adb3069b0e04-53c79e15746mr11869854e87.5.1730925336514; Wed, 06 Nov 2024 12:35:36 -0800 (PST) MIME-Version: 1.0 References: <20241105112721.373285-1-bruce.richardson@intel.com> <20241106101836.0f66c457@hermes.local> In-Reply-To: <20241106101836.0f66c457@hermes.local> From: David Marchand Date: Wed, 6 Nov 2024 21:35:25 +0100 Message-ID: Subject: Re: [PATCH] app/dumpcap: remove unused struct array To: Bruce Richardson Cc: dev@dpdk.org, stable@dpdk.org, Stephen Hemminger X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: LnpyrLZkeCYWse5LJG3eRuX2jPgZkyfWL2qL0WoJ0OM_1730925337 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Wed, Nov 6, 2024 at 7:18=E2=80=AFPM Stephen Hemminger wrote: > > On Tue, 5 Nov 2024 11:27:21 +0000 > Bruce Richardson wrote: > > > The callbacks(rx_cb) member of struct interface was unused inside > > dumpcap, but was taking up a lot of memory space, since it was scaled > > according to RTE_MAX_QUEUES_PER_PORT, which is 1k by default. Save > > memory by removing the whole array. > > > > Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application") > > Cc: stable@dpdk.org > > > > Suggested-by: Stephen Hemminger > > Signed-off-by: Bruce Richardson > Acked-by: Stephen Hemminger Applied, thanks. --=20 David Marchand