patches for DPDK stable branches
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Wisam Jaddo <wisamm@mellanox.com>
Cc: dev <dev@dpdk.org>, Raslan <rasland@mellanox.com>,
	 Thomas Monjalon <thomas@monjalon.net>,
	Olivier Matz <olivier.matz@6wind.com>,
	 "Iremonger, Bernard" <bernard.iremonger@intel.com>,
	dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v3] cmdline: increase maximum line length
Date: Sat, 22 Feb 2020 16:28:15 +0100
Message-ID: <CAJFAV8x7HwFAiz9nw=zQ1t7ZzSwbJCuQGKf0XTv3o4SEU4y6mw@mail.gmail.com> (raw)
In-Reply-To: <1582210386-27331-1-git-send-email-wisamm@mellanox.com>

This patch is flagged as an ABI breakage:
https://travis-ci.com/ovsrobot/dpdk/jobs/289313318#L2273


On Thu, Feb 20, 2020 at 3:53 PM Wisam Jaddo <wisamm@mellanox.com> wrote:
>
> This increase due to the usage of cmdline in dpdk applications
> as config commands such as testpmd do for rte_flow rules creation.
>
> The current size of buffer is not enough to fill
> many cases of rte_flow commands validation/creation.
>
> rte_flow now can have outer items, inner items, modify
> actions, meta data actions, duplicate action, fate action and
> more in one single rte flow, thus 512 char will not be enough
> to validate such rte flow rules.
>
> Such change shouldn't affect the memory since the cmdline
> reading again using the same buffer.

I don't get your point here.


> Cc: stable@dpdk.org

This is not a fix.


-- 
David Marchand


  reply	other threads:[~2020-02-22 15:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-20 13:18 [dpdk-stable] [PATCH] lib/cmdline_rdline: increase command line buf size Wisam Jaddo
2020-02-20 13:42 ` Thomas Monjalon
2020-02-20 14:06   ` Wisam Monther
2020-02-20 14:53 ` [dpdk-stable] [PATCH v3] cmdline: increase maximum line length Wisam Jaddo
2020-02-22 15:28   ` David Marchand [this message]
2020-07-31 12:55     ` [dpdk-stable] [dpdk-dev] " Olivier Matz
2020-07-31 13:00       ` David Marchand
2020-07-31 15:46       ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8x7HwFAiz9nw=zQ1t7ZzSwbJCuQGKf0XTv3o4SEU4y6mw@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=bernard.iremonger@intel.com \
    --cc=dev@dpdk.org \
    --cc=olivier.matz@6wind.com \
    --cc=rasland@mellanox.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    --cc=wisamm@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git