From: David Marchand <david.marchand@redhat.com>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
"Dmitry Malloy (MESHCHANINOV)" <dmitrym@microsoft.com>,
Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
Pallavi Kadam <pallavi.kadam@intel.com>
Cc: dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org>,
Qiming Yang <qiming.yang@intel.com>,
Qi Zhang <qi.z.zhang@intel.com>,
Haiyue Wang <haiyue.wang@intel.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-stable] [PATCH 2/2] net/ice: fix leak on thread termination
Date: Fri, 7 May 2021 10:13:16 +0200 [thread overview]
Message-ID: <CAJFAV8x9P5gN6rjDC8kgRW618qP2XKZhijn8oQZqvO_-=nFcVQ@mail.gmail.com> (raw)
In-Reply-To: <20210506094452.1689-3-david.marchand@redhat.com>
On Thu, May 6, 2021 at 11:45 AM David Marchand
<david.marchand@redhat.com> wrote:
>
> A terminated pthread should be joined or detached so that its associated
> resources are released.
>
> The "ice-reset-<vf_id>" threads are used to service some reset task in the
> background, but they are never joined by the thread that created them.
> The easiest solution is to detach new threads.
Not so "easy" for Windows.
I think I'll simply #ifndef WINDOWS my addition.
Maybe the leak does not exist on Windows? but if it does, the
situation won't change by doing nothing on Windows.
If there is strong objection, I'll need some help to add a
pthread_detach() wrapper in windows EAL.
From my quick read at the API, I'd say I need to find the current
thread handle (via OpenThread) then CloseHandle it.
But does it work from "pthread_self()" ?
Since a new API thread is in preparation, the "thread detaching" from
the pthread API is something to consider.
I could not find it in Narcissa series.
--
David Marchand
next prev parent reply other threads:[~2021-05-07 8:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210506094452.1689-1-david.marchand@redhat.com>
2021-05-06 9:44 ` [dpdk-stable] [PATCH 1/2] net/ark: " David Marchand
2021-05-11 17:55 ` Ed Czeck
2021-05-06 9:44 ` [dpdk-stable] [PATCH 2/2] net/ice: " David Marchand
2021-05-06 10:31 ` Wang, Haiyue
2021-05-07 8:13 ` David Marchand [this message]
2021-05-07 17:14 ` Dmitry Kozlyuk
[not found] ` <20210511113358.2485-1-david.marchand@redhat.com>
2021-05-11 11:33 ` [dpdk-stable] [PATCH v2 1/2] net/ark: " David Marchand
2021-05-11 11:33 ` [dpdk-stable] [PATCH v2 2/2] net/ice: " David Marchand
2021-05-11 17:34 ` Dmitry Kozlyuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8x9P5gN6rjDC8kgRW618qP2XKZhijn8oQZqvO_-=nFcVQ@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=haiyue.wang@intel.com \
--cc=navasile@linux.microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).