From: David Marchand <david.marchand@redhat.com>
To: Xiaoyun Li <xiaoyun.li@intel.com>
Cc: Jingjing Wu <jingjing.wu@intel.com>,
Xiaolong Ye <xiaolong.ye@intel.com>, dev <dev@dpdk.org>,
dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] examples/ntb: fix no return check
Date: Sun, 27 Oct 2019 14:02:56 +0100 [thread overview]
Message-ID: <CAJFAV8x9paUaB0kvOf_7vOod6GHQkFxL9mS9W8AhsCyJYQJfSQ@mail.gmail.com> (raw)
In-Reply-To: <20191025070101.34281-1-xiaoyun.li@intel.com>
On Fri, Oct 25, 2019 at 9:03 AM Xiaoyun Li <xiaoyun.li@intel.com> wrote:
> This patch adds return value checking and error handling for
> rte_rawdev_en/dequeue_buffers() and rte_eth_link_get().
Different class of issues are fixed in this patch, but the initial
commit mixed different features too...
Please split your patches in the future.
> Coverity issue: 350247, 350250, 350251, 350252, 350253, 350254
> Fixes: 5194299d6ef5 ("examples/ntb: support more functions")
> Cc: stable@dpdk.org
No need for copying stable, the fixed commit is only in master and was
not a fix itself.
> Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
Applied, thanks.
It is probably worth revisiting this code and validate the malloc()
failures, or rework this and get rid of malloc.
--
David Marchand
prev parent reply other threads:[~2019-10-27 13:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 7:01 [dpdk-stable] " Xiaoyun Li
2019-10-27 13:02 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8x9paUaB0kvOf_7vOod6GHQkFxL9mS9W8AhsCyJYQJfSQ@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=stable@dpdk.org \
--cc=xiaolong.ye@intel.com \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).