From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 901F1A009E for ; Sun, 27 Oct 2019 14:03:14 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 43F521BF24; Sun, 27 Oct 2019 14:03:14 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id AC24E1BF1B for ; Sun, 27 Oct 2019 14:03:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1572181390; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X0m+YJjuUa9PntMt+ulU14MjSWUqzvmkjsq6Os06O0c=; b=EAdEpz63XHirEpFRF82KepYnv+gKFhSopWujLnw/hONnWCItM7tmrduM34GU2AtYQnzQUx s2gTw33HEI7mOKvcerIlQPLVeJCPucgZ1TnvxCF1vMOfpojqk8x8+mrDsP+tpptKrJl6kA 9XjrbPPLKGKBpKL+LS2IOK1gW8H6cyg= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-247-uQSejv9VO7qJpRLzgMvZCw-1; Sun, 27 Oct 2019 09:03:08 -0400 Received: by mail-vk1-f197.google.com with SMTP id u23so3561426vkl.2 for ; Sun, 27 Oct 2019 06:03:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=u62tLW4Cgw9sRkNNPMJc8ZNbIEqpW4u14Jwl0ZL5IzU=; b=iuJ0vI/rNaIncALEhjsxkBfJEs0ETS/RQr0m+t5PAuAYlY/q7ZXnrKqOVoxHn5nGNz dF6+jGs7EHO4EO4sSsd9JexHigNiynIUKeWRDUK+RNpis/kTiNmUSDjifx0kQ6WiUMXC CtT0bUrRiyPLPv6yWiZVncxMnaSJMo7u05v9bPtHq8DhSozBgwH7ps180IPp2JdUpDun 9eoDdMvHIVOLU+TH19Myk5EQ9LNaFADSqSL1XN5azQbl6MsW8H/PyW19fJZi8T9vTcJI dcG+UHYx3v+rr5++fRQSNu1E+yS+R02pHMDuaKyP3FUuQPBXiI5flnVrMe6vFGd56uRP lUcQ== X-Gm-Message-State: APjAAAXyx4tmxTvlgsRHbIOfvtVc+EWcP5c9GJ363ZwyunmgfGFrW/6b SZZ+i98nJP2MpLq0dZ6ckzlMGB0o8LBYulcaOV928TLHNnX0DrBLtfzk55+8nWFafbeQUyoUUJy dyFLcqcd0eotE8wrF0ZqCZVw= X-Received: by 2002:a05:6102:d8:: with SMTP id u24mr2602140vsp.180.1572181388207; Sun, 27 Oct 2019 06:03:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqyDVlBjt9YGnj8cYxpb5AjUOZUK3TYChbw9nISLeHEUW2uSOIn3JEpDQjGXo2WhATxJDEwVcxOff4Ag2rPaioI= X-Received: by 2002:a05:6102:d8:: with SMTP id u24mr2602122vsp.180.1572181387760; Sun, 27 Oct 2019 06:03:07 -0700 (PDT) MIME-Version: 1.0 References: <20191025070101.34281-1-xiaoyun.li@intel.com> In-Reply-To: <20191025070101.34281-1-xiaoyun.li@intel.com> From: David Marchand Date: Sun, 27 Oct 2019 14:02:56 +0100 Message-ID: To: Xiaoyun Li Cc: Jingjing Wu , Xiaolong Ye , dev , dpdk stable X-MC-Unique: uQSejv9VO7qJpRLzgMvZCw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] examples/ntb: fix no return check X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Fri, Oct 25, 2019 at 9:03 AM Xiaoyun Li wrote: > This patch adds return value checking and error handling for > rte_rawdev_en/dequeue_buffers() and rte_eth_link_get(). Different class of issues are fixed in this patch, but the initial commit mixed different features too... Please split your patches in the future. > Coverity issue: 350247, 350250, 350251, 350252, 350253, 350254 > Fixes: 5194299d6ef5 ("examples/ntb: support more functions") > Cc: stable@dpdk.org No need for copying stable, the fixed commit is only in master and was not a fix itself. > Signed-off-by: Xiaoyun Li Applied, thanks. It is probably worth revisiting this code and validate the malloc() failures, or rework this and get rid of malloc. --=20 David Marchand