From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C8198A034C for ; Wed, 21 Dec 2022 16:03:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C1A44410D3; Wed, 21 Dec 2022 16:03:35 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 11BD740A7A for ; Wed, 21 Dec 2022 16:03:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671635014; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FlPNg8ip0znARRPlsaQduJRQqN77GyRDVQLuItqQPWI=; b=EgM5RC7/GVvq3aRdxtsEmxWYI0v2e5sfPCwyPly8GdTzDGcJVT/cIYt6Sk0miLmuIyy7N1 SIKCfZzyz223g8AITpKOewUpwkxlj7dFZDZJup8taduwE9inEEcHv7Zp3bKzn50h3tKXIA 0aH6Vy7/vU52EaEidlOyriSpMJDJ/AU= Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-611-NnFuZjzWPYOH9SE1aTzRLQ-1; Wed, 21 Dec 2022 10:03:32 -0500 X-MC-Unique: NnFuZjzWPYOH9SE1aTzRLQ-1 Received: by mail-pg1-f200.google.com with SMTP id 38-20020a630b26000000b004773803dda1so9008781pgl.17 for ; Wed, 21 Dec 2022 07:03:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FlPNg8ip0znARRPlsaQduJRQqN77GyRDVQLuItqQPWI=; b=x8AkwnKNSXzHaP1SFiiOl77laHZ6SsorpNUxa+PE2+BbQnwQZw6gXgJg88b/maN3bB eYJCtMn7UJHvAjr2iKpjCXJSoV83u4V+c3vnqCzrehbemzV7pIbTPLl8MDunsyWSiqBg SE38WJsGBD9j/DewS+SVU/GsBscdWv2K1Gkh2aCoLGBAibHVPjrYfqXH1VPJ0HABHtUg JvMQthBpA17wA+6sT1qbWr/cj6jrUBRo69vZNdGIwgEGXKH/qo0AQsWp+sHuEr400Q8U f1t/AJGOj5obCZjE2zE0JcrUGKJ8ZcZevd2O1X5q44hkh6ayxEG3GCu1J5vYkPolzjyt hVXg== X-Gm-Message-State: AFqh2kqxLMYJUFMqTrND1Sf5AIUsdKpuye4DbcoxqEK1FpTQTGDnsFXK SAAeeV0A96qrqh0xcyT23F7WzW/TkjNnsA8sX2XLS3zwBMnp/KRkHUs/yIbjDqJSEAXBNwbhJRp mgKGoGbKx2rrTCzUtmG0wMTY= X-Received: by 2002:a63:a23:0:b0:484:83e4:4ca1 with SMTP id 35-20020a630a23000000b0048483e44ca1mr67563pgk.178.1671635011755; Wed, 21 Dec 2022 07:03:31 -0800 (PST) X-Google-Smtp-Source: AMrXdXt1pxTners6k8Kk/6S4BdaIJYPM9X8LfZF8iazHsMa5tYpqvLu7ReG1Vewu+HqOLMNafCDuhUaejFf8hqkU0Xc= X-Received: by 2002:a63:a23:0:b0:484:83e4:4ca1 with SMTP id 35-20020a630a23000000b0048483e44ca1mr67559pgk.178.1671635011507; Wed, 21 Dec 2022 07:03:31 -0800 (PST) MIME-Version: 1.0 References: <1670287169-15325-1-git-send-email-roretzla@linux.microsoft.com> <1671211000-14856-1-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: <1671211000-14856-1-git-send-email-roretzla@linux.microsoft.com> From: David Marchand Date: Wed, 21 Dec 2022 16:03:20 +0100 Message-ID: Subject: Re: [PATCH v2 0/2] Enable the lcores test on Windows instead of skipping it. To: Tyler Retzlaff Cc: dev@dpdk.org, stable@dpdk.org, dmitry.kozliuk@gmail.com, stephen@networkplumber.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Fri, Dec 16, 2022 at 6:16 PM Tyler Retzlaff wrote: > > Two bugs are fixed to allow this test to build, run & pass. > * Mark memory configuration complete during rte_eal_init() > * Use rte thread api to get a proper implementation of thread join. > > v2: > * update commit message to clarify why this test is beneficial on Windows. > * add missing Fixes tag > > Tyler Retzlaff (2): > eal: add missing call marking memory config complete > test: enable lcores test on Windows > > app/test/test_lcores.c | 28 +++++++++++++--------------- > lib/eal/windows/eal.c | 3 +++ > 2 files changed, 16 insertions(+), 15 deletions(-) For the series, Acked-by: David Marchand I added review tags from Stephen from v1. Series applied, thanks. -- David Marchand