From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 74FD3425B7 for ; Wed, 4 Oct 2023 09:36:43 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6DD7D402CC; Wed, 4 Oct 2023 09:36:43 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id A1BFC40289 for ; Wed, 4 Oct 2023 09:36:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696405001; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GVNkx1KCd0Bnh5pnId3FOrLkyLg1J1qrj+rS3it4B3A=; b=eNR0IKkJbXm5BZdWMgmMRazDFn9afqklm44FJHWZyaqBK9SzTZmQLoTW3rz0o2ALy16j8g 90u47H+w4cMhCfLaxoG6no2zDJI9aMO0SKHIOv3CmtChl/uKChgBp5fnBQJ926liAscR/L Veu7kijrPQSs+bl4GaMtG3IIl1E9q8Q= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-511-Z4pO-pbSOPa3GjII_vfccg-1; Wed, 04 Oct 2023 03:36:40 -0400 X-MC-Unique: Z4pO-pbSOPa3GjII_vfccg-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2c12a8576d4so15333881fa.3 for ; Wed, 04 Oct 2023 00:36:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696404998; x=1697009798; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GVNkx1KCd0Bnh5pnId3FOrLkyLg1J1qrj+rS3it4B3A=; b=gZ7IepAozPLRVbRy5HCiaqrtro8UCCBf1iMgwNYkOvRWbTeBpEnqcqQIOV/sPJXN8u Y6liYt9mywvJvWloUg7in5aE0SIZcVAqLOaURZXeEOVygCzn+eO5FTzOj+S5ZwYrypoM UwBJ98RqYgLu7Uqr6NQSvp90tUQk3lWuw8TGXc8LLQ1h8JBB7avgyxINDfKLpkZzeU5C OQngqWgB3YU8OnIEJGyyG/0tRwWdM1XpbXrbxC330Dk9Thv1ZV6oxqrks++DqCAWS+JM E4RofL9e2Rr0ui9K74lGDOpDnoWZ9Euwuj+qm9WwYywLPSY/ZOz3XL9fKDq8qGh9Af1L cMHw== X-Gm-Message-State: AOJu0YyW+ooOsjEIiFvNDab1JvecqutcppO0np6mVVJLD6+OCxbrNuTt iPHTH2rT0lO0Ki3xkN+9PtRzconEbCuxyHf8BcgjwNkrD611DCYaidrKViQl1HFvTSppemZe9t/ LA2DNZqx+Khu73PfQfRo2bis= X-Received: by 2002:a2e:8e89:0:b0:2bc:ffe5:54a1 with SMTP id z9-20020a2e8e89000000b002bcffe554a1mr1237519ljk.32.1696404998688; Wed, 04 Oct 2023 00:36:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHvkAvxZG84BG5IVstKLjP3uBKlLx2Xu1cEkOiAVKvN62fCecNAwJk6/q5R4J4OdE0angD4sTgs+kfN7/xtvXI= X-Received: by 2002:a2e:8e89:0:b0:2bc:ffe5:54a1 with SMTP id z9-20020a2e8e89000000b002bcffe554a1mr1237498ljk.32.1696404998367; Wed, 04 Oct 2023 00:36:38 -0700 (PDT) MIME-Version: 1.0 References: <20231003183956.1270510-1-jerinj@marvell.com> In-Reply-To: From: David Marchand Date: Wed, 4 Oct 2023 09:36:26 +0200 Message-ID: Subject: Re: [dpdk-dev] [PATCH] common/cnxk: fix direct rte symbol usage To: Jerin Jacob , Thomas Monjalon Cc: jerinj@marvell.com, dev@dpdk.org, Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Long Li , Tyler Retzlaff , Konstantin Ananyev , =?UTF-8?Q?Morten_Br=C3=B8rup?= , Andrew Rybchenko , Liron Himi , stable@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Wed, Oct 4, 2023 at 8:43=E2=80=AFAM Jerin Jacob = wrote: > > > diff --git a/drivers/common/cnxk/roc_nix_inl_dev.c b/drivers/common/c= nxk/roc_nix_inl_dev.c > > > index 6aa191410b..614d0858e5 100644 > > > --- a/drivers/common/cnxk/roc_nix_inl_dev.c > > > +++ b/drivers/common/cnxk/roc_nix_inl_dev.c > > > @@ -826,7 +826,7 @@ nix_inl_outb_poll_thread_setup(struct nix_inl_dev= *inl_dev) > > > soft_exp_consumer_cnt =3D 0; > > > soft_exp_poll_thread_exit =3D false; > > > rc =3D plt_thread_create_control(&inl_dev->soft_exp_poll_thre= ad, > > > - "outb-poll", nix_inl_outb_poll_thread, inl_de= v); > > > + "outb-soft-exp-poll", nix_inl_outb_poll_threa= d, inl_dev); > > > > Such a thread name is too long. > > This is reverting Thomas change. > > > > Is this intentional? > > Yes, as mentioned in git commit log. Are 19 characters OK, right? If The commitlog was ambiguous. > not, I will reduce it, "outb-poll" too generic. The thread name max length in pthread API is 16 bytes (including the trailing \0). Besides, looking again at this driver, I suspect Thomas missed it because of the plt_ prefix, when doing ce703c47de95 ("eal: force prefix for internal threads"). Converting to the internal API would restrict the name down to 11 bytes (including \0). --=20 David Marchand