From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1618346424 for ; Wed, 19 Mar 2025 16:42:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0DA464026B; Wed, 19 Mar 2025 16:42:47 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id B90AB4026B for ; Wed, 19 Mar 2025 16:42:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742398965; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dTIkQcMWvnyc0YENeXm3aJ6ABCAXUuOu7IHeWoDlB5s=; b=ioovi56jd/n1a0rSK7lxcaMERGTN1N+MOfwtT9OAeObOD05hmXz9cun4kOplR8SkPNgJ0c rKBSgisAXcBbi796yIbUE/Mx7Tw2e6E5n1cNYkq5DevcyWINdr1iYuztGMWUHgQARlMzBj ec+VihAWmWgjZF/6+PiSM9qOXncsRUs= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-96-po0ULM_UOlK5q8Z1Tg-QGQ-1; Wed, 19 Mar 2025 11:42:43 -0400 X-MC-Unique: po0ULM_UOlK5q8Z1Tg-QGQ-1 X-Mimecast-MFC-AGG-ID: po0ULM_UOlK5q8Z1Tg-QGQ_1742398956 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-5498b25aae9so3197961e87.2 for ; Wed, 19 Mar 2025 08:42:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742398956; x=1743003756; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dTIkQcMWvnyc0YENeXm3aJ6ABCAXUuOu7IHeWoDlB5s=; b=v+IqO5+wf4WNdeRgo7o4PeHxoXZWbsQYMj1Y8prw3tdbOiRH9z215zXeov/ZTAd980 Z6tXN5lpRMvykqh869XLDeCskj8xjjFjxJW5TKno1niZIg923xluWkUtnek6DRHejzZK CktuzbugAMF9ID9eaAxl01w2/UfFt1Y8EAdEWPIFqTvDnEOj1DkTDIeDNkEE44lZqFn4 clJBpGWmTFhyKqsvzXzKXefx7FOkJuz83tcPuup0hINNqyrpezk6mw90trrqazRNk/rx MjkuL/FxGWUp0GRb+IkudE+ZXaWC3grm7y/oeTjKVOjzCBob8UuLWinwSMg9GWEGfM7J 0kgg== X-Forwarded-Encrypted: i=1; AJvYcCVwC7a3WgrneJ+lBhNT3roKwi3ZY5wYtT08V0ptGrw4K7Y2SJsX4hPv/IvXvq/+qU08TYsuECo=@dpdk.org X-Gm-Message-State: AOJu0YyVMJBWY2nrsQeadO0hbBxDp/8+RUK0r9PPZraEBWK8u6os59ww SP/Nk8+Sn97pnwH+HK5LFsWHjBcH0uh7bOoiX3rM2nBATpodR8mYdzEXBvBOy1taM/eEdgJf885 UYkvNQm3PNKh/ZgLOU223ZFJ8z2d6bVSJqkKGc23b9IoiSDpa7CfbsLZzZdMGO4js1M7tVjeLpK haE02mY+ABxq456mabxTI= X-Gm-Gg: ASbGncv6CAFbb6xTkfioH1jeF4lzAIFHjcXco1jnfpT2OYQxDgu8fuMUPxbprvDHVm2 HvYzO8p1nVeXQ8QAE8Z5dXpxlLvl+JIaUfePBEbv5H6LQYRHOPrigwSXIaLPxWaWRUJk/QIuofg k= X-Received: by 2002:a05:6512:1392:b0:54a:c835:cc4d with SMTP id 2adb3069b0e04-54acb21bbc6mr1437807e87.49.1742398955711; Wed, 19 Mar 2025 08:42:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGPw7TuOhHelH50FHleo1M/WlKYhWB2p4CEov8wVI3CyfUxwheKS6qoG66zGvx1d4KxRsUUPfCpL65oojzZxGE= X-Received: by 2002:a05:6512:1392:b0:54a:c835:cc4d with SMTP id 2adb3069b0e04-54acb21bbc6mr1437784e87.49.1742398955313; Wed, 19 Mar 2025 08:42:35 -0700 (PDT) MIME-Version: 1.0 References: <20250305134720.907347-1-bruce.richardson@intel.com> <20250305162458.1059282-1-bruce.richardson@intel.com> In-Reply-To: From: David Marchand Date: Wed, 19 Mar 2025 16:42:23 +0100 X-Gm-Features: AQ5f1JqDlk8sCTkb8_lZll-4OfhHbKbB2snAN38EcJI39-viHc_0PdJIZL-OceA Message-ID: Subject: Re: [PATCH v2] eal: fix undetected NUMA nodes To: Bruce Richardson Cc: dev@dpdk.org, Anatoly Burakov , stable@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: E0axu8V9chuBFQJxqQSZekwWWP-Xu81pvuad1iA8cSo_1742398956 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Tue, Mar 18, 2025 at 6:42=E2=80=AFPM Bruce Richardson wrote: > > On Wed, Mar 05, 2025 at 04:24:58PM +0000, Bruce Richardson wrote: > > In cases where the number of cores on a given socket is greater than > > RTE_MAX_LCORES, then EAL will be unaware of all the sockets/numa nodes > > on a system. Fix this limitation by having the EAL probe the NUMA node > > for cores it isn't going to use, and recording that for completeness. > > > > This is necessary as memory is tracked per node, and with the --lcores > > parameters our app lcores may be on different sockets than the lcore id= s > > may imply. For example, lcore 0 is on socket zero, but if app is run > > with --lcores=3D0@64, then DPDK lcore 0 may be on socket one, so DPDK > > needs to be aware of that socket. > > > > Fixes: 952b20777255 ("eal: provide API for querying valid socket ids") > > Cc: stable@dpdk.org > > > > Signed-off-by: Bruce Richardson > > > > --- > > v2: handle case where RTE_MAX_LCORE > CPU_SETSIZE (i.e. >1024) > > --- > > lib/eal/common/eal_common_lcore.c | 17 ++++++++++++----- > > 1 file changed, 12 insertions(+), 5 deletions(-) > > > Ping for review. > > For anyone wanting to test: > To reproduce the issue, do a build of DPDK with max_lcores optio= n > set to less than the number of physical cores you have on a socket. You also need to have those cores contiguous for a numa node which is quite frequent on the systems in my lab. But anyway, the bug is not hard to understand, I'll reply on the patch itse= lf. --=20 David Marchand