From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1A3E2A0C47 for ; Thu, 14 Oct 2021 13:20:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0B65F41235; Thu, 14 Oct 2021 13:20:55 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id BBC7E41235 for ; Thu, 14 Oct 2021 13:20:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634210453; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uSQ1q0QE34hWl9+1tBnMnYMkSU3fM1ibQPTwtSGX6fU=; b=HWfXlmn/z77gI42R15UOcj0xRGrXjXZuzbYa9IyYuqzlnxRJdvo3XtBJkW6TAtDPdChbj6 pP/eo+pRD0+SqQAw1kx0mwcVz11EkxvtH0dRLtiMV2RgoZ5yU+Y/NNItJZRuoZYu7NrlsB 3yJ42jvIusye1lbZm3BG8DHJhakhpzg= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-504-AMrd5fsrOXOO1W99pxbtPg-1; Thu, 14 Oct 2021 07:20:50 -0400 X-MC-Unique: AMrd5fsrOXOO1W99pxbtPg-1 Received: by mail-lf1-f69.google.com with SMTP id i6-20020a056512318600b003fd8c8c2677so4140326lfe.1 for ; Thu, 14 Oct 2021 04:20:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uSQ1q0QE34hWl9+1tBnMnYMkSU3fM1ibQPTwtSGX6fU=; b=0OUoNGg77qnlRpEB9fUXXiD/zdhMFFqiV7hLHB7+5cbJJPlKIxvHC1zmVzRf0OyLUB Yjsc2X6YYh73NhJ/JEGxFh17TGpB1nL3ePCuzewd8Zk1SGKBGrUsjHfVrtirBe6PEiBI jZXaUYMLLF7n9OYl3z9h8TBVguAOvr1HLa2yJrCOfH2lmKAfCo59KvAI9vOexJXYckWE kmjkTTx19N0tPI3yfiEPgyFZ+LAQO/QqpyKA80rmAByFrNJz0KCjpRW9bm+1MnZVSTV+ 9XHRyIv7yXjbfldcUveYsz2324xMK+vFXPxLBEr5Gkh4hBXMWoQ88uwMQ74nnj9KTqy/ adgg== X-Gm-Message-State: AOAM531j9Ow/WBzOYpdjUeJQBq7pZSqZ7BW6ueGD9OvNO8KYFSFG+BuQ DDzwk7t0uZNC7EaThBT3F1AERd51uARnNHs/Pq0hkNLz7JytlAWIo4babvX8V3tX3gKd9AwloMV A5u2EgrhmflC8ko6YpbyYf4k= X-Received: by 2002:a2e:9018:: with SMTP id h24mr3616984ljg.477.1634210448571; Thu, 14 Oct 2021 04:20:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJynQ1ixS4tkiY4MxLJJ8T4cDrgOEKVLN2UQJ2UeRp91qI773xFgj27xqrqO//Moi/1MC2WhiV+ZKfzn+Sbm8TM= X-Received: by 2002:a2e:9018:: with SMTP id h24mr3616962ljg.477.1634210448333; Thu, 14 Oct 2021 04:20:48 -0700 (PDT) MIME-Version: 1.0 References: <20211014085026.2991677-1-dkozlyuk@nvidia.com> <20211014085528.2992805-1-dkozlyuk@nvidia.com> In-Reply-To: <20211014085528.2992805-1-dkozlyuk@nvidia.com> From: David Marchand Date: Thu, 14 Oct 2021 13:20:37 +0200 Message-ID: To: Dmitry Kozlyuk Cc: dev , Raslan Darawsheh , Xueming Li , dpdk stable , Harman Kalra , Thomas Monjalon , Matan Azrad , Viacheslav Ovsiienko Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [PATCH v2] net/mlx5: close tools socket with the last device X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Thu, Oct 14, 2021 at 10:55 AM Dmitry Kozlyuk wrote: > > MLX5 PMD exposes a socket for external tools to dump port state. > Socket events are listened using an interrupt source of EXT type. > The socket was closed and the interrupt callback was unregistered > at program exit, which is incorrect because DPDK could be already > shut down at this point. Move actions performed at program exit > to the moment the last MLX5 port is closed. The socket will be opened > again if later a new MLX5 device is plugged in and probed. > Also fix comments that were deceisively talking > about secondary processes instead of external tools. +1 for fixing those comments. > > Fixes: e6cdc54cc0ef ("net/mlx5: add socket server for external tools") > Cc: Xueming Li > Cc: stable@dpdk.org > > Reported-by: Harman Kalra > Signed-off-by: Dmitry Kozlyuk > Acked-by: Thomas Monjalon The fix lgtm, thanks. There is a separate issue I spotted while reviewing. I'll send a separate fix. -- David Marchand