From: David Marchand <david.marchand@redhat.com>
To: Chenbo Xia <chenbox@nvidia.com>
Cc: dev@dpdk.org, oss-drivers@corigine.com,
Zerun Fu <zerun.fu@corigine.com>,
mukawa@igel.co.jp, stable@dpdk.org,
Long Wu <long.wu@corigine.com>,
Peng Zhang <peng.zhang@corigine.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
Chaoyong He <chaoyong.he@corigine.com>
Subject: Re: [PATCH v6 2/2] bus/pci: fix secondary process save 'FD' problem
Date: Fri, 12 Jul 2024 19:30:32 +0200 [thread overview]
Message-ID: <CAJFAV8xL3Uv_S1TYWGZHWX16GBaOnnfLgbQHumXePRCXNv8SDg@mail.gmail.com> (raw)
In-Reply-To: <20240702074007.1547-3-chaoyong.he@corigine.com>
Hello,
On Tue, Jul 2, 2024 at 9:40 AM Chaoyong He <chaoyong.he@corigine.com> wrote:
>
> From: Zerun Fu <zerun.fu@corigine.com>
>
> In the previous logic the 'fd' was only saved in the primary process,
> but for some devices this value is also used in the secondary logic.
>
> For example, the call of 'rte_pci_find_ext_capability()' will fail in
> the secondary process.
>
> Fix this problem by getting and saving the value of 'fd' also in the
> secondary process logic.
>
> Fixes: 9b957f378abf ("pci: merge uio functions for linux and bsd")
> Cc: mukawa@igel.co.jp
> Cc: stable@dpdk.org
>
> Signed-off-by: Zerun Fu <zerun.fu@corigine.com>
> Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
> Reviewed-by: Long Wu <long.wu@corigine.com>
> Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
Chenbo,
Are you ok with this fix?
Thanks.
--
David Marchand
next prev parent reply other threads:[~2024-07-12 17:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 10:45 [PATCH] bus/pci: fix secondary process PCI uio resource map problem Chaoyong He
[not found] ` <20240129092231.3531217-1-chaoyong.he@corigine.com>
2024-01-29 9:22 ` [PATCH v2 1/2] " Chaoyong He
2024-01-30 4:00 ` fengchengwen
2024-01-30 7:12 ` huangdengdui
2024-03-14 10:55 ` Burakov, Anatoly
2024-01-29 9:22 ` [PATCH v2 2/2] bus/pci: fix secondary process save 'FD' problem Chaoyong He
2024-01-30 6:16 ` fengchengwen
2024-03-14 11:01 ` Burakov, Anatoly
[not found] ` <20240419032630.1215256-1-chaoyong.he@corigine.com>
2024-04-19 3:26 ` [PATCH v3 1/2] bus/pci: fix secondary process PCI uio resource map problem Chaoyong He
2024-06-27 14:00 ` Thomas Monjalon
2024-06-28 1:03 ` Chaoyong He
2024-04-19 3:26 ` [PATCH v3 2/2] bus/pci: fix secondary process save 'FD' problem Chaoyong He
[not found] ` <20240628073624.4122899-1-chaoyong.he@corigine.com>
2024-06-28 7:36 ` [PATCH v4 2/3] bus/pci: fix secondary process PCI uio resource map problem Chaoyong He
2024-06-28 7:36 ` [PATCH v4 3/3] bus/pci: fix secondary process save 'FD' problem Chaoyong He
2024-07-01 14:14 ` David Marchand
2024-07-02 1:53 ` Chaoyong He
[not found] ` <20240702021946.4194102-1-chaoyong.he@corigine.com>
2024-07-02 2:19 ` [PATCH v5 2/3] bus/pci: fix secondary process PCI uio resource map problem Chaoyong He
2024-07-02 2:19 ` [PATCH v5 3/3] bus/pci: fix secondary process save 'FD' problem Chaoyong He
[not found] ` <20240702074007.1547-1-chaoyong.he@corigine.com>
2024-07-02 7:40 ` [PATCH v6 1/2] bus/pci: fix secondary process PCI uio resource map problem Chaoyong He
2024-07-04 9:00 ` Chenbo Xia
2024-07-02 7:40 ` [PATCH v6 2/2] bus/pci: fix secondary process save 'FD' problem Chaoyong He
2024-07-12 17:30 ` David Marchand [this message]
2024-07-15 2:24 ` Chenbo Xia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xL3Uv_S1TYWGZHWX16GBaOnnfLgbQHumXePRCXNv8SDg@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=chaoyong.he@corigine.com \
--cc=chenbox@nvidia.com \
--cc=dev@dpdk.org \
--cc=long.wu@corigine.com \
--cc=mukawa@igel.co.jp \
--cc=oss-drivers@corigine.com \
--cc=peng.zhang@corigine.com \
--cc=stable@dpdk.org \
--cc=zerun.fu@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).