From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F02A845EEE for ; Thu, 19 Dec 2024 16:37:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E70EB402A0; Thu, 19 Dec 2024 16:37:56 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id AB3A54025F for ; Thu, 19 Dec 2024 16:37:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734622674; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AyVoEbCEpu3Rb0uS8rzMw7w71+GCUovb8sZtp9hGfQw=; b=G/KdY8rNodA6r0gJy9Cz13Tor8QbajUenHXKm/im4Yq4OcVzDk+Hib4aRxMj1Aaxk0eYE0 CpTSr+V4lGs34Bu5IRWstwsKsnpVB2SKQMZ6k/7AHGU2hA8jGbWtPpKwhyPB0XCHy0DtI+ uUid95YSaEUEnVSpA5H7uUNDLrx+oWM= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-615-J3De4ZfrN4KyFLta7Ooa1g-1; Thu, 19 Dec 2024 10:37:52 -0500 X-MC-Unique: J3De4ZfrN4KyFLta7Ooa1g-1 X-Mimecast-MFC-AGG-ID: J3De4ZfrN4KyFLta7Ooa1g Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-53e3aa7d016so375470e87.3 for ; Thu, 19 Dec 2024 07:37:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734622671; x=1735227471; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AyVoEbCEpu3Rb0uS8rzMw7w71+GCUovb8sZtp9hGfQw=; b=EBolTMKVGH+MOB8cctUOFlFm+OB113GfXXPhioViYAwbD8sr2uunyVCrep3jLD4knr y4JmH5NwWmBcjDjkLdrmUTQree1WyHRJvFQiv1L/CrMB3Ou+306X3+xOMRxNQ4Lo1pCp GBqXt2TnF1lqErTjAk7zP4tC7D0QDtUw00SphjFcxxenXegoJ9Tk7lWpQrcD96MBajn2 g1sEviVlUCArHeTNv5FEQAb9bWE4HIX6lU8SNTrcRvqnmgIX+i3D5uIdGfmx4xez9M8U KFk/aS+ZNHrieMmtduat5ZPyp6fHJriTWt/3+lWZIuUrsqV0F3tTgXMxvG7mjIGp3t8N 5CrQ== X-Forwarded-Encrypted: i=1; AJvYcCWqqhiweWek2RUgqncw/6iJlQCPBDuSqoGa3DUIioQETCQUbQFoNblVNO30SMLd/aSP2mMjHQY=@dpdk.org X-Gm-Message-State: AOJu0YzKuvk0MIastU1z7gkWr+/6oO5M8FWEDztEi//rbpJPAFPHByXY XYa64AOlivUM+zTgUBZrQV+BYUirL2iF4CBPfJOgeU1c6jHyivSem49sTcoRnyNMkWoypL1QylN 67x4vN2dlcueY7sjMnmaFyOsBCChoaAmjl56T9zJnLBL2sOQhDIeWCsGfXKZS3yEI3BFX3HhoEa QqEptDM/J2Y4nFUPfoPdI= X-Gm-Gg: ASbGncvb835F/aoaWPnUTn0a3dgjZK+RqkjF/0pOhTyo7E4ckirLFJlZkeQSByJvBUV pPE68rUdwDtug3rKe1YiUfS+GdS3J3e1+ZAjTa3Ma X-Received: by 2002:a05:6512:ba4:b0:541:21f9:45b6 with SMTP id 2adb3069b0e04-541ed8f73a3mr2391172e87.37.1734622670960; Thu, 19 Dec 2024 07:37:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IHo6aYHml8EKJVR2T5zgKpttmGYTtPd8PLRz0fjdSp/BUFoG9oEMckXxCSt/Wwgk3YoKUH2Dq6sv6siKUaqQdk= X-Received: by 2002:a05:6512:ba4:b0:541:21f9:45b6 with SMTP id 2adb3069b0e04-541ed8f73a3mr2391163e87.37.1734622670566; Thu, 19 Dec 2024 07:37:50 -0800 (PST) MIME-Version: 1.0 References: <20241219133139.420001-1-thomas@monjalon.net> In-Reply-To: <20241219133139.420001-1-thomas@monjalon.net> From: David Marchand Date: Thu, 19 Dec 2024 16:37:39 +0100 Message-ID: Subject: Re: [PATCH v2] cryptodev: fix C++ include To: Thomas Monjalon Cc: dev@dpdk.org, stable@dpdk.org, Zhigang Hu , Akhil Goyal , Fan Zhang , =?UTF-8?Q?Morten_Br=C3=B8rup?= , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: -EEB5qlnR3GUIDE3Ih3dv_8MzhlIwankQlf9tiSnbJ4_1734622671 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Thu, Dec 19, 2024 at 2:31=E2=80=AFPM Thomas Monjalon wrote: > > Some cryptodev functions were not included in an extern "C" block. > > There are 2 blocks, the second one being fast path inline functions, > preceded with an include of the required rte_cryptodev_core.h file. > > Fixes: 719834a6849e ("use C linkage where appropriate in headers") > Cc: stable@dpdk.org > > Reported-by: Zhigang Hu > Signed-off-by: Thomas Monjalon I wonder if there is also an issue with lib/cryptodev/rte_crypto_asym.h, for symbols rte_crypto_asym_ke_strings and rte_crypto_asym_op_strings. But at least this patch looks fine to me. Reviewed-by: David Marchand --=20 David Marchand