From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93E1EA0C4A for ; Thu, 8 Jul 2021 11:54:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6EF664069C; Thu, 8 Jul 2021 11:54:59 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id C0DB64069C for ; Thu, 8 Jul 2021 11:54:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625738096; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0Kc2PI/5XRZ80NzDFmzXyafAP352PWuKLrZzmWSmKYo=; b=OmNwFpPCSpH705mlLIs6FQMgXsdWXQlF7afmDGWIqXDpZKPDb+HIKRazimgy0AjLInHY8D O0t7YnQzIZh8BNnrQkcUuhZUS/2PrggYixKjXJpt2n2W+CAURAkK7UoZRHzdw3pbxbf+Or ETx/96CJwYrbs4+3/feY4lW0gBZe+G4= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-479-yk2CtLOTM-OFi6RU-eg3kA-1; Thu, 08 Jul 2021 05:54:53 -0400 X-MC-Unique: yk2CtLOTM-OFi6RU-eg3kA-1 Received: by mail-vk1-f200.google.com with SMTP id j9-20020a1f6e090000b02902581d95f3fdso976263vkc.11 for ; Thu, 08 Jul 2021 02:54:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0Kc2PI/5XRZ80NzDFmzXyafAP352PWuKLrZzmWSmKYo=; b=B1xMgB04E1R6yAfUk7pFdc+AeR4KcNUwF/NyN/NPzE3ASYeQRrBEeckfIgvmbumaI1 s0JtefgUCf3bBgJJXWlBai/P2s+0dbmRv51dofbjqfpUwpACQSQJ6xN2wcSxqusPgkb5 agXDGClZIesk6LJUKOtfsH0ggr3F/UOr4+hHpTbeAtBKl+LvKp2+ISTdAb/BVVhZ6YL3 nW0UcQAPM4fchQT8mVcOQHuj1vIi5jpKnVgSW2VJggbLNRSyFhQat9xB3uGCJGtEzH+x dSlLf8gF0KXPSUYR2spaYHOCVeKEnbKOVjzeAcVOIXL0EShPzOJmgCHoe3NN3LwsX6WR iHiQ== X-Gm-Message-State: AOAM533YYy0V3QLYYQAwiP8DYrctXi0YR+pBFzGUCEFD29EUOrhuk2zu 1n6p0Nr9WvX6u68yVJ7B+Cc7kWQc4TUNMYDLmpImImcDJyhXIFnIQwimEh5l85EL6EXuj9J4K/H N5yU8MID9WULJJ5FpuRu37g8= X-Received: by 2002:a05:6102:3196:: with SMTP id c22mr19469525vsh.27.1625738093200; Thu, 08 Jul 2021 02:54:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxm/lTW6iZhQ1s1LKhZRaz5YdYF81RUxdtwT4R4cbk+/vCFNAWN0JNKfCAR8Fk7hlUvKSmTvRoV1ngMQDJk8tQ= X-Received: by 2002:a05:6102:3196:: with SMTP id c22mr19469511vsh.27.1625738092963; Thu, 08 Jul 2021 02:54:52 -0700 (PDT) MIME-Version: 1.0 References: <20210614091213.3953-1-david.marchand@redhat.com> <20210707110230.8695-1-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Thu, 8 Jul 2021 11:54:41 +0200 Message-ID: To: dev Cc: "Burakov, Anatoly" , Owen Hilyard , dpdk stable , Qi Zhang , Maxime Coquelin Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] ipc: stop mp control thread on cleanup X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Thu, Jul 8, 2021 at 9:23 AM Maxime Coquelin wrote: > On 7/7/21 1:02 PM, David Marchand wrote: > > When calling rte_eal_cleanup, the mp channel cleanup routine only sets > > mp_fd to -1 leaving the rte_mp_handle control thread running. > > This control thread can spew warnings on reading on an invalid fd. > > This is especially noticed with ASAN enabled. > > > > To handle this situation, set mp_fd to -1 to signal the control thread > > it should exit, but since this thread might be sleeping on the socket, > > cancel the thread too. > > > > Fixes: 85d6815fa6d0 ("eal: close multi-process socket during cleanup") > > Cc: stable@dpdk.org > > > > Reported-by: Owen Hilyard > > Signed-off-by: David Marchand > Reviewed-by: Maxime Coquelin Applied, thanks. -- David Marchand