From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0E9D6A00BE for ; Wed, 30 Oct 2019 09:01:32 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 93CEA1BEF5; Wed, 30 Oct 2019 09:01:31 +0100 (CET) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id F289B1BDAC for ; Wed, 30 Oct 2019 09:01:26 +0100 (CET) Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5DF1337F75 for ; Wed, 30 Oct 2019 08:01:26 +0000 (UTC) Received: by mail-ua1-f72.google.com with SMTP id p9so249218uar.8 for ; Wed, 30 Oct 2019 01:01:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OrlUb2DqZHjbOY5wtImnlGyDMUmYzMJSbWQDDaPhVAM=; b=RKwVdsSNzWGVJIYfMitp1Q21Ep/gPtXcVZrsayHt2z8iRlJOd3tRRHLxa0Jgosb4pF nZIQzdNV2rW5UcqOTDUtSNQa9I0kdejnnQ7ZGHwsdYZUceXPi7itYvAt+65YtrXckmnU F+5FB77dcrkp4WJ5hSj9gE6YNxucdo7Wp1P6IGJuC/eb4WNPSDDw/MORZrGgJFbSiame QaKSx5ATAKOCGlQ7QilQnig0Jj1whITlAnyh8zXea3t2IZnpO2y3QKQLX77sZwqtVitV zmxx2q6A/qc9xIYUIbLBWltanGvR0mL+kM3ifx1J/49D+24magxT78D52HrkcW48goeI 0TYA== X-Gm-Message-State: APjAAAVGMe00oP3PMAnPEtCHHuRDk/WeCGgEtsIfD7E1Hv2GWVf3dGNW r9VgsT1hkWBOh8BWmo4Ldiqhbii1nkSf+avOXKb6I4rQLn44fBY4ZKuvM9uMrdy0IYcviyc/lO7 44S3s1NeUzGUwNLicVcxyF5I= X-Received: by 2002:a67:7d95:: with SMTP id y143mr4383345vsc.39.1572422485408; Wed, 30 Oct 2019 01:01:25 -0700 (PDT) X-Google-Smtp-Source: APXvYqzZl8Nd7QPrJ5HS7khjBhm2Ah4Y0eI+aKmopMb9iNf4YLijE+BWe/VHWc3Rqw4Xf40GCs7YyfKxnqMc3GlNNxY= X-Received: by 2002:a67:7d95:: with SMTP id y143mr4383320vsc.39.1572422485075; Wed, 30 Oct 2019 01:01:25 -0700 (PDT) MIME-Version: 1.0 References: <20191001125315.6191-1-ktraynor@redhat.com> <20191001130405.7076-1-ktraynor@redhat.com> <20191001130405.7076-4-ktraynor@redhat.com> In-Reply-To: <20191001130405.7076-4-ktraynor@redhat.com> From: David Marchand Date: Wed, 30 Oct 2019 09:01:13 +0100 Message-ID: To: Kevin Traynor Cc: dev , Rosen Xu , dpdk stable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [PATCH 5/9] net/ipn3ke: remove useless if statement X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Tue, Oct 1, 2019 at 3:04 PM Kevin Traynor wrote: > > Coverity complains that this statement is not needed as the goto > label is on the next line anyway. Remove the if statement. > > 653 ret = ipn3ke_cfg_parse_i40e_pf_ethdev(afu_name, pf_name); > CID 337930 (#1 of 1): Identical code for different branches > (IDENTICAL_BRANCHES)identical_branches: The same code is executed > when the condition ret is true or false, because the code in the > if-then branch and after the if statement is identical. Should > the if statement be removed? > 654 if (ret) > 655 goto end; > implicit_else: The code from the above if-then branch is identical > to the code after the if statement. > 656end: > > Coverity issue: 337930 > Fixes: c01c748e4ae6 ("net/ipn3ke: add new driver") > Cc: rosen.xu@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Kevin Traynor > --- > drivers/net/ipn3ke/ipn3ke_ethdev.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/ipn3ke/ipn3ke_ethdev.c b/drivers/net/ipn3ke/ipn3ke_ethdev.c > index c226d6313..282295f49 100644 > --- a/drivers/net/ipn3ke/ipn3ke_ethdev.c > +++ b/drivers/net/ipn3ke/ipn3ke_ethdev.c > @@ -652,6 +652,5 @@ ipn3ke_cfg_probe(struct rte_vdev_device *dev) > > ret = ipn3ke_cfg_parse_i40e_pf_ethdev(afu_name, pf_name); > - if (ret) > - goto end; > + > end: > if (kvlist) > -- > 2.21.0 > Reviewed-by: David Marchand -- David Marchand